Patchwork [meta-oe,v2,2/2] usb-modeswitch: Upgrade to latest version

login
register
mail settings
Submitter Jukka Rissanen
Date July 10, 2014, 11:09 a.m.
Message ID <1404990575-2064-2-git-send-email-jukka.rissanen@linux.intel.com>
Download mbox | patch
Permalink /patch/75315/
State Accepted, archived
Headers show

Comments

Jukka Rissanen - July 10, 2014, 11:09 a.m.
Use the latest version of usb-modeswitch (2.2.0) and
usb-modeswitch-data (20140529). The data package depends
on new usb-modeswitch version so upgrade both of them at
the same time.

Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
---
 ...odeswitch-data_20130807.bb => usb-modeswitch-data_20140529.bb} | 8 ++++----
 .../{usb-modeswitch_2.0.1.bb => usb-modeswitch_2.2.0.bb}          | 6 +++---
 2 files changed, 7 insertions(+), 7 deletions(-)
 rename meta-oe/recipes-support/usb-modeswitch/{usb-modeswitch-data_20130807.bb => usb-modeswitch-data_20140529.bb} (52%)
 rename meta-oe/recipes-support/usb-modeswitch/{usb-modeswitch_2.0.1.bb => usb-modeswitch_2.2.0.bb} (68%)
Martin Jansa - July 10, 2014, 12:06 p.m.
On Thu, Jul 10, 2014 at 02:09:35PM +0300, Jukka Rissanen wrote:
> Use the latest version of usb-modeswitch (2.2.0) and
> usb-modeswitch-data (20140529). The data package depends
> on new usb-modeswitch version so upgrade both of them at
> the same time.
> 
> Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
> ---
>  ...odeswitch-data_20130807.bb => usb-modeswitch-data_20140529.bb} | 8 ++++----
>  .../{usb-modeswitch_2.0.1.bb => usb-modeswitch_2.2.0.bb}          | 6 +++---
>  2 files changed, 7 insertions(+), 7 deletions(-)
>  rename meta-oe/recipes-support/usb-modeswitch/{usb-modeswitch-data_20130807.bb => usb-modeswitch-data_20140529.bb} (52%)
>  rename meta-oe/recipes-support/usb-modeswitch/{usb-modeswitch_2.0.1.bb => usb-modeswitch_2.2.0.bb} (68%)
> 
> diff --git a/meta-oe/recipes-support/usb-modeswitch/usb-modeswitch-data_20130807.bb b/meta-oe/recipes-support/usb-modeswitch/usb-modeswitch-data_20140529.bb
> similarity index 52%
> rename from meta-oe/recipes-support/usb-modeswitch/usb-modeswitch-data_20130807.bb
> rename to meta-oe/recipes-support/usb-modeswitch/usb-modeswitch-data_20140529.bb
> index e33f296..a265411 100644
> --- a/meta-oe/recipes-support/usb-modeswitch/usb-modeswitch-data_20130807.bb
> +++ b/meta-oe/recipes-support/usb-modeswitch/usb-modeswitch-data_20140529.bb
> @@ -4,14 +4,14 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f"
>  
>  inherit allarch
>  
> -SRC_URI = "http://www.draisberghof.de/usb_modeswitch/usb-modeswitch-data-${PV}.tar.bz2"
> -SRC_URI[md5sum] = "91feff51deba6e48e78506b8f4db2274"
> -SRC_URI[sha256sum] = "a3114e2c1f38eed3ad0067df30e53a96313908a9539a8ea5d94a4d35651699eb"
> +SRC_URI = "http://www.draisberghof.de/usb_modeswitch/${BP}.tar.bz2"
> +SRC_URI[md5sum] = "dff94177781298aaf0b3c2a3c3dea6b2"
> +SRC_URI[sha256sum] = "53889157937109e04dafe897c098ec94f3f44f9c0c83fc6ec8417aa9a587e536"
>  
>  do_install() {
>      oe_runmake install DESTDIR=${D}
>  }
>  
> -RDEPENDS_${PN} = "usb-modeswitch"
> +RDEPENDS_${PN} = "usb-modeswitch (>= 2.2.0)"

Do we really need the version here?

If yes then add comment explaining why.

>  FILES_${PN} += "${base_libdir}/udev/rules.d/ \
>                  ${datadir}/usb_modeswitch"
> diff --git a/meta-oe/recipes-support/usb-modeswitch/usb-modeswitch_2.0.1.bb b/meta-oe/recipes-support/usb-modeswitch/usb-modeswitch_2.2.0.bb
> similarity index 68%
> rename from meta-oe/recipes-support/usb-modeswitch/usb-modeswitch_2.0.1.bb
> rename to meta-oe/recipes-support/usb-modeswitch/usb-modeswitch_2.2.0.bb
> index 61caa84..5e95bb9 100644
> --- a/meta-oe/recipes-support/usb-modeswitch/usb-modeswitch_2.0.1.bb
> +++ b/meta-oe/recipes-support/usb-modeswitch/usb-modeswitch_2.2.0.bb
> @@ -4,9 +4,9 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f"
>  
>  DEPENDS = "libusb1"
>  
> -SRC_URI = "http://www.draisberghof.de/usb_modeswitch/usb-modeswitch-${PV}.tar.bz2"
> -SRC_URI[md5sum] = "e48d4419d0574d342bb183f7465556d0"
> -SRC_URI[sha256sum] = "4706c9cfe825263e189f55730ea3d1d8634aeb15645a1098532e946e770f7f95"
> +SRC_URI = "http://www.draisberghof.de/usb_modeswitch/${BP}.tar.bz2"
> +SRC_URI[md5sum] = "f323fe700edd6ea404c40934ddf32b22"
> +SRC_URI[sha256sum] = "2752103de171ed5f6c8d6a6e3e73e16c9ee3e8e394dd39c5991f7680eb908a3a"
>  
>  EXTRA_OEMAKE = "TCL=${bindir}/tclsh"
>  
> -- 
> 1.8.3.1
> 
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Jukka Rissanen - July 10, 2014, 1:16 p.m.
On to, 2014-07-10 at 14:06 +0200, Martin Jansa wrote:
> On Thu, Jul 10, 2014 at 02:09:35PM +0300, Jukka Rissanen wrote:
> > Use the latest version of usb-modeswitch (2.2.0) and
> > usb-modeswitch-data (20140529). The data package depends
> > on new usb-modeswitch version so upgrade both of them at
> > the same time.
> > 
> >  
> > -RDEPENDS_${PN} = "usb-modeswitch"
> > +RDEPENDS_${PN} = "usb-modeswitch (>= 2.2.0)"
> 
> Do we really need the version here?
> 
> If yes then add comment explaining why.


Hmm, I thought the commit message already states that. Do you want that
also in the recipe itself?


Cheers,
Jukka
Martin Jansa - July 10, 2014, 1:57 p.m.
On Thu, Jul 10, 2014 at 04:16:20PM +0300, Jukka Rissanen wrote:
> On to, 2014-07-10 at 14:06 +0200, Martin Jansa wrote:
> > On Thu, Jul 10, 2014 at 02:09:35PM +0300, Jukka Rissanen wrote:
> > > Use the latest version of usb-modeswitch (2.2.0) and
> > > usb-modeswitch-data (20140529). The data package depends
> > > on new usb-modeswitch version so upgrade both of them at
> > > the same time.
> > > 
> > >  
> > > -RDEPENDS_${PN} = "usb-modeswitch"
> > > +RDEPENDS_${PN} = "usb-modeswitch (>= 2.2.0)"
> > 
> > Do we really need the version here?
> > 
> > If yes then add comment explaining why.
> 
> 
> Hmm, I thought the commit message already states that. Do you want that
> also in the recipe itself?

I read it as explanation why you're upgrading 2 recipes in the same
commit, but it doesn't say why you need explicit version in
RDEPENDS_${PN} (instead of letting bitbake do it automatically).

Cheers,

Patch

diff --git a/meta-oe/recipes-support/usb-modeswitch/usb-modeswitch-data_20130807.bb b/meta-oe/recipes-support/usb-modeswitch/usb-modeswitch-data_20140529.bb
similarity index 52%
rename from meta-oe/recipes-support/usb-modeswitch/usb-modeswitch-data_20130807.bb
rename to meta-oe/recipes-support/usb-modeswitch/usb-modeswitch-data_20140529.bb
index e33f296..a265411 100644
--- a/meta-oe/recipes-support/usb-modeswitch/usb-modeswitch-data_20130807.bb
+++ b/meta-oe/recipes-support/usb-modeswitch/usb-modeswitch-data_20140529.bb
@@ -4,14 +4,14 @@  LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f"
 
 inherit allarch
 
-SRC_URI = "http://www.draisberghof.de/usb_modeswitch/usb-modeswitch-data-${PV}.tar.bz2"
-SRC_URI[md5sum] = "91feff51deba6e48e78506b8f4db2274"
-SRC_URI[sha256sum] = "a3114e2c1f38eed3ad0067df30e53a96313908a9539a8ea5d94a4d35651699eb"
+SRC_URI = "http://www.draisberghof.de/usb_modeswitch/${BP}.tar.bz2"
+SRC_URI[md5sum] = "dff94177781298aaf0b3c2a3c3dea6b2"
+SRC_URI[sha256sum] = "53889157937109e04dafe897c098ec94f3f44f9c0c83fc6ec8417aa9a587e536"
 
 do_install() {
     oe_runmake install DESTDIR=${D}
 }
 
-RDEPENDS_${PN} = "usb-modeswitch"
+RDEPENDS_${PN} = "usb-modeswitch (>= 2.2.0)"
 FILES_${PN} += "${base_libdir}/udev/rules.d/ \
                 ${datadir}/usb_modeswitch"
diff --git a/meta-oe/recipes-support/usb-modeswitch/usb-modeswitch_2.0.1.bb b/meta-oe/recipes-support/usb-modeswitch/usb-modeswitch_2.2.0.bb
similarity index 68%
rename from meta-oe/recipes-support/usb-modeswitch/usb-modeswitch_2.0.1.bb
rename to meta-oe/recipes-support/usb-modeswitch/usb-modeswitch_2.2.0.bb
index 61caa84..5e95bb9 100644
--- a/meta-oe/recipes-support/usb-modeswitch/usb-modeswitch_2.0.1.bb
+++ b/meta-oe/recipes-support/usb-modeswitch/usb-modeswitch_2.2.0.bb
@@ -4,9 +4,9 @@  LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f"
 
 DEPENDS = "libusb1"
 
-SRC_URI = "http://www.draisberghof.de/usb_modeswitch/usb-modeswitch-${PV}.tar.bz2"
-SRC_URI[md5sum] = "e48d4419d0574d342bb183f7465556d0"
-SRC_URI[sha256sum] = "4706c9cfe825263e189f55730ea3d1d8634aeb15645a1098532e946e770f7f95"
+SRC_URI = "http://www.draisberghof.de/usb_modeswitch/${BP}.tar.bz2"
+SRC_URI[md5sum] = "f323fe700edd6ea404c40934ddf32b22"
+SRC_URI[sha256sum] = "2752103de171ed5f6c8d6a6e3e73e16c9ee3e8e394dd39c5991f7680eb908a3a"
 
 EXTRA_OEMAKE = "TCL=${bindir}/tclsh"