Patchwork [dora,backport,from,master] apmd.service: Fix typo (not mandatory EnvironmentFile prefix)

login
register
mail settings
Submitter Sébastien Mennetrier
Date July 9, 2014, 2:24 p.m.
Message ID <1404915889-26159-1-git-send-email-smennetrier@connected-labs.com>
Download mbox | patch
Permalink /patch/75255/
State New
Headers show

Comments

Sébastien Mennetrier - July 9, 2014, 2:24 p.m.
From: Tobias Blom <tobias.blom@techne-dev.se>

Prefix to EnvironmentFile should be preciding the filenamn.

(From OE-Core rev: 1f694e4cb493b0737b6009382c0957e6837ebbed)

Signed-off-by: Tobias Blom <tobias.blom@techne-dev.se>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 meta/recipes-bsp/apmd/apmd-3.2.2-14/apmd.service | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Sébastien Mennetrier - July 18, 2014, 7:30 a.m.
Ping

Is it possible to cherry-pick this patch from Master to Dora ?

Commit : b21468434c519927dace6a1433786ca7a0501172


Regards,
Seb M


2014-07-09 16:24 GMT+02:00 Sébastien Mennetrier <
smennetrier@connected-labs.com>:

> From: Tobias Blom <tobias.blom@techne-dev.se>
>
> Prefix to EnvironmentFile should be preciding the filenamn.
>
> (From OE-Core rev: 1f694e4cb493b0737b6009382c0957e6837ebbed)
>
> Signed-off-by: Tobias Blom <tobias.blom@techne-dev.se>
> Signed-off-by: Saul Wold <sgw@linux.intel.com>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
>  meta/recipes-bsp/apmd/apmd-3.2.2-14/apmd.service | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-bsp/apmd/apmd-3.2.2-14/apmd.service
> b/meta/recipes-bsp/apmd/apmd-3.2.2-14/apmd.service
> index 62d6af1..ffab823 100644
> --- a/meta/recipes-bsp/apmd/apmd-3.2.2-14/apmd.service
> +++ b/meta/recipes-bsp/apmd/apmd-3.2.2-14/apmd.service
> @@ -3,5 +3,5 @@ Description=Advanced Power Management daemon
>  After=remote-fs.target
>
>  [Service]
> -EnvironmentFile-= @SYSCONFDIR@/default/apmd
> +EnvironmentFile=-@SYSCONFDIR@/default/apmd
>  ExecStart=@SBINDIR@/apmd -P @SYSCONFDIR@/apm/apmd_proxy $APMD
> --
> 1.8.3.2
>
>
Robert Yang - July 30, 2014, 2:37 a.m.
Sorry for the late response, it worked well for me, I will confirm
with RP.

// Robert

On 07/18/2014 03:30 PM, Sébastien Mennetrier wrote:
> Ping
>
> Is it possible to cherry-pick this patch from Master to Dora ?
>
> Commit : b21468434c519927dace6a1433786ca7a0501172
>
>
> Regards,
> Seb M
>
>
> 2014-07-09 16:24 GMT+02:00 Sébastien Mennetrier <smennetrier@connected-labs.com
> <mailto:smennetrier@connected-labs.com>>:
>
>     From: Tobias Blom <tobias.blom@techne-dev.se <mailto:tobias.blom@techne-dev.se>>
>
>     Prefix to EnvironmentFile should be preciding the filenamn.
>
>     (From OE-Core rev: 1f694e4cb493b0737b6009382c0957e6837ebbed)
>
>     Signed-off-by: Tobias Blom <tobias.blom@techne-dev.se
>     <mailto:tobias.blom@techne-dev.se>>
>     Signed-off-by: Saul Wold <sgw@linux.intel.com <mailto:sgw@linux.intel.com>>
>     Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org
>     <mailto:richard.purdie@linuxfoundation.org>>
>     ---
>       meta/recipes-bsp/apmd/apmd-3.2.2-14/apmd.service | 2 +-
>       1 file changed, 1 insertion(+), 1 deletion(-)
>
>     diff --git a/meta/recipes-bsp/apmd/apmd-3.2.2-14/apmd.service
>     b/meta/recipes-bsp/apmd/apmd-3.2.2-14/apmd.service
>     index 62d6af1..ffab823 100644
>     --- a/meta/recipes-bsp/apmd/apmd-3.2.2-14/apmd.service
>     +++ b/meta/recipes-bsp/apmd/apmd-3.2.2-14/apmd.service
>     @@ -3,5 +3,5 @@ Description=Advanced Power Management daemon
>       After=remote-fs.target
>
>       [Service]
>     -EnvironmentFile-= @SYSCONFDIR@/default/apmd
>     +EnvironmentFile=-@SYSCONFDIR@/default/apmd
>       ExecStart=@SBINDIR@/apmd -P @SYSCONFDIR@/apm/apmd_proxy $APMD
>     --
>     1.8.3.2
>
>
>
>
Sébastien Mennetrier - Sept. 25, 2014, 3:06 p.m.
Ping. Can someone accept this patch in dora branch please?

Thanks.

Regards,
Seb M

2014-07-30 4:37 GMT+02:00 Robert Yang <liezhi.yang@windriver.com>:

>
> Sorry for the late response, it worked well for me, I will confirm
> with RP.
>
> // Robert
>
> On 07/18/2014 03:30 PM, Sébastien Mennetrier wrote:
>
>> Ping
>>
>> Is it possible to cherry-pick this patch from Master to Dora ?
>>
>> Commit : b21468434c519927dace6a1433786ca7a0501172
>>
>>
>> Regards,
>> Seb M
>>
>>
>> 2014-07-09 16:24 GMT+02:00 Sébastien Mennetrier <
>> smennetrier@connected-labs.com
>> <mailto:smennetrier@connected-labs.com>>:
>>
>>     From: Tobias Blom <tobias.blom@techne-dev.se <mailto:
>> tobias.blom@techne-dev.se>>
>>
>>     Prefix to EnvironmentFile should be preciding the filenamn.
>>
>>     (From OE-Core rev: 1f694e4cb493b0737b6009382c0957e6837ebbed)
>>
>>     Signed-off-by: Tobias Blom <tobias.blom@techne-dev.se
>>     <mailto:tobias.blom@techne-dev.se>>
>>     Signed-off-by: Saul Wold <sgw@linux.intel.com <mailto:
>> sgw@linux.intel.com>>
>>     Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org
>>     <mailto:richard.purdie@linuxfoundation.org>>
>>     ---
>>       meta/recipes-bsp/apmd/apmd-3.2.2-14/apmd.service | 2 +-
>>       1 file changed, 1 insertion(+), 1 deletion(-)
>>
>>     diff --git a/meta/recipes-bsp/apmd/apmd-3.2.2-14/apmd.service
>>     b/meta/recipes-bsp/apmd/apmd-3.2.2-14/apmd.service
>>     index 62d6af1..ffab823 100644
>>     --- a/meta/recipes-bsp/apmd/apmd-3.2.2-14/apmd.service
>>     +++ b/meta/recipes-bsp/apmd/apmd-3.2.2-14/apmd.service
>>     @@ -3,5 +3,5 @@ Description=Advanced Power Management daemon
>>       After=remote-fs.target
>>
>>       [Service]
>>     -EnvironmentFile-= @SYSCONFDIR@/default/apmd
>>     +EnvironmentFile=-@SYSCONFDIR@/default/apmd
>>       ExecStart=@SBINDIR@/apmd -P @SYSCONFDIR@/apm/apmd_proxy $APMD
>>     --
>>     1.8.3.2
>>
>>
>>
>>
>>

Patch

diff --git a/meta/recipes-bsp/apmd/apmd-3.2.2-14/apmd.service b/meta/recipes-bsp/apmd/apmd-3.2.2-14/apmd.service
index 62d6af1..ffab823 100644
--- a/meta/recipes-bsp/apmd/apmd-3.2.2-14/apmd.service
+++ b/meta/recipes-bsp/apmd/apmd-3.2.2-14/apmd.service
@@ -3,5 +3,5 @@  Description=Advanced Power Management daemon
 After=remote-fs.target
 
 [Service]
-EnvironmentFile-= @SYSCONFDIR@/default/apmd
+EnvironmentFile=-@SYSCONFDIR@/default/apmd
 ExecStart=@SBINDIR@/apmd -P @SYSCONFDIR@/apm/apmd_proxy $APMD