Patchwork [1/2] lz4: update to latest version 119

login
register
mail settings
Submitter Armin Kuster
Date July 7, 2014, 9:33 p.m.
Message ID <1404768785-24026-2-git-send-email-akuster@mvista.com>
Download mbox | patch
Permalink /patch/75135/
State New
Headers show

Comments

Armin Kuster - July 7, 2014, 9:33 p.m.
Update SRC_URI to github as googlecode does not have this version
Minor clean to reflect non-svn fetch

Signed-off-by: Armin Kuster <akuster@mvista.com>
---
 meta/recipes-support/lz4/{lz4_svn.bb => lz4_r119.bb} | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
 rename meta/recipes-support/lz4/{lz4_svn.bb => lz4_r119.bb} (63%)
Ross Burton - July 8, 2014, 10:15 a.m.
On 7 July 2014 22:33, Armin Kuster <akuster@mvista.com> wrote:
> -LIC_FILES_CHKSUM = "file://LICENSE;md5=2008d2325e11691e17fcaa3a6046f850"
> +LIC_FILES_CHKSUM = "file://LICENSE;md5=0b0d063f37a4477b54af2459477dcafd"

Please add a comment in the commit message explaining why the checksum
has changed.

> -SRC_URI = "svn://lz4.googlecode.com/svn/;module=trunk;protocol=http"
> +SRC_URI = "https://github.com/Cyan4973/lz4/archive/${PV}.tar.gz"

Github archives can't be trusted as they can be re-generated at any
time by github (and the checksums will change).  If upstream doesn't
provide static tarballs then use the git fetcher and checkout the
release tag.

> +S = "${WORKDIR}/${BPN}-${PV}"

This is the default value.

Ross
Armin Kuster - July 8, 2014, 8:39 p.m.
On 07/08/2014 03:15 AM, Burton, Ross wrote:
> On 7 July 2014 22:33, Armin Kuster <akuster@mvista.com> wrote:
>> -LIC_FILES_CHKSUM = "file://LICENSE;md5=2008d2325e11691e17fcaa3a6046f850"
>> +LIC_FILES_CHKSUM = "file://LICENSE;md5=0b0d063f37a4477b54af2459477dcafd"
>
> Please add a comment in the commit message explaining why the checksum
> has changed.

ok, will do.

>
>> -SRC_URI = "svn://lz4.googlecode.com/svn/;module=trunk;protocol=http"
>> +SRC_URI = "https://github.com/Cyan4973/lz4/archive/${PV}.tar.gz"
>
> Github archives can't be trusted as they can be re-generated at any
> time by github (and the checksums will change).  If upstream doesn't
> provide static tarballs then use the git fetcher and checkout the
> release tag.
>
Thanks for the info. I will look for a different solution.

- Armin

>> +S = "${WORKDIR}/${BPN}-${PV}"
>
> This is the default value.
>
> Ross
>

Patch

diff --git a/meta/recipes-support/lz4/lz4_svn.bb b/meta/recipes-support/lz4/lz4_r119.bb
similarity index 63%
rename from meta/recipes-support/lz4/lz4_svn.bb
rename to meta/recipes-support/lz4/lz4_r119.bb
index 38e36d8..dfc155e 100644
--- a/meta/recipes-support/lz4/lz4_svn.bb
+++ b/meta/recipes-support/lz4/lz4_r119.bb
@@ -2,15 +2,15 @@  SUMMARY = "Extremely Fast Compression algorithm"
 DESCRIPTION = "LZ4 is a very fast lossless compression algorithm, providing compression speed at 400 MB/s per core, scalable with multi-cores CPU. It also features an extremely fast decoder, with speed in multiple GB/s per core, typically reaching RAM speed limits on multi-core systems."
 
 LICENSE = "BSD"
-LIC_FILES_CHKSUM = "file://LICENSE;md5=2008d2325e11691e17fcaa3a6046f850"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=0b0d063f37a4477b54af2459477dcafd"
 
-# Upstream names releases after SVN revs
-SRCREV = "112"
-PV = "r${SRCREV}"
 
-SRC_URI = "svn://lz4.googlecode.com/svn/;module=trunk;protocol=http"
+SRC_URI = "https://github.com/Cyan4973/lz4/archive/${PV}.tar.gz"
 
-S = "${WORKDIR}/trunk"
+SRC_URI[md5sum] = "3fc4ed20cb98dba909896f485b25d0f1"
+SRC_URI[sha256sum] = "1deb77e5cc7b41422c02dd3d56e7e0f0deb20723a54cad4ad5a65fb1f4805b1c"
+
+S = "${WORKDIR}/${BPN}-${PV}"
 
 EXTRA_OEMAKE = "PREFIX=${prefix} CC='${CC}' DESTDIR=${D} LIBDIR=${libdir} INCLUDEDIR=${includedir}"