Patchwork [1/1] image.bbclass/buildtools-tarball: cleanup the RDEPENDS

login
register
mail settings
Submitter Robert Yang
Date July 4, 2014, 9:16 a.m.
Message ID <28a4822de67dfb01eddd7cc9f10bd820411e1425.1404465351.git.liezhi.yang@windriver.com>
Download mbox | patch
Permalink /patch/75009/
State New
Headers show

Comments

Robert Yang - July 4, 2014, 9:16 a.m.
The "RDEPENDS =" should be replaced by RDEPENDS_${PN}, the similar to
RRECOMMENDS

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
 meta/classes/image.bbclass                   |    4 ++--
 meta/recipes-core/meta/buildtools-tarball.bb |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
Richard Purdie - July 7, 2014, 11:37 p.m.
On Fri, 2014-07-04 at 02:16 -0700, Robert Yang wrote:
> The "RDEPENDS =" should be replaced by RDEPENDS_${PN}, the similar to
> RRECOMMENDS

Why?

PACKAGES = "" for these recipes so there is no ${PN} package to add
these dependencies too?

I suspect this is from your image class modifications but did you test
without those modifications?

Cheers,

Richard
Robert Yang - July 8, 2014, 1:47 a.m.
On 07/08/2014 07:37 AM, Richard Purdie wrote:
> On Fri, 2014-07-04 at 02:16 -0700, Robert Yang wrote:
>> The "RDEPENDS =" should be replaced by RDEPENDS_${PN}, the similar to
>> RRECOMMENDS
>
> Why?
>
> PACKAGES = "" for these recipes so there is no ${PN} package to add
> these dependencies too?

Ah, right, we should not set this if no PACKAGES.

>
> I suspect this is from your image class modifications but did you test
> without those modifications?

Yes, it is from the image class modifications. I tested it separately,
the bitbake core-image-minimal buildtools-tarball were the same w/o
these changes, I don't know why it works after your explanations, I
tried to print the self.rdepends_pkg from cache.py after patched:

self.rdepends_pkg: {'core-image-minimal': ['packagegroup-core-boot', 
'run-postinsts', 'run-postinsts']}

maybe that's why it works.

Anyway, we should drop this since PACKAGES = "".

// Robert

>
> Cheers,
>
> Richard
>
>
>

Patch

diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
index a03b880..136fe82 100644
--- a/meta/classes/image.bbclass
+++ b/meta/classes/image.bbclass
@@ -11,8 +11,8 @@  inherit gzipnative
 LICENSE = "MIT"
 PACKAGES = ""
 DEPENDS += "${MLPREFIX}qemuwrapper-cross ${MLPREFIX}depmodwrapper-cross"
-RDEPENDS += "${PACKAGE_INSTALL} ${LINGUAS_INSTALL}"
-RRECOMMENDS += "${PACKAGE_INSTALL_ATTEMPTONLY}"
+RDEPENDS_${PN} += "${PACKAGE_INSTALL} ${LINGUAS_INSTALL}"
+RRECOMMENDS_${PN} += "${PACKAGE_INSTALL_ATTEMPTONLY}"
 
 INHIBIT_DEFAULT_DEPS = "1"
 
diff --git a/meta/recipes-core/meta/buildtools-tarball.bb b/meta/recipes-core/meta/buildtools-tarball.bb
index 62e1e0b..7501525 100644
--- a/meta/recipes-core/meta/buildtools-tarball.bb
+++ b/meta/recipes-core/meta/buildtools-tarball.bb
@@ -45,7 +45,7 @@  TOOLCHAIN_HOST_TASK ?= "\
 
 TOOLCHAIN_OUTPUTNAME ?= "${SDK_NAME}-buildtools-nativesdk-standalone-${DISTRO_VERSION}"
 
-RDEPENDS = "${TOOLCHAIN_HOST_TASK}"
+RDEPENDS_${PN} = "${TOOLCHAIN_HOST_TASK}"
 
 EXCLUDE_FROM_WORLD = "1"