Patchwork [dora] e2fsprogs: Fix populate-extfs.sh

login
register
mail settings
Submitter Stéphane Cerveau
Date June 30, 2014, 2:18 p.m.
Message ID <1404137924-14085-1-git-send-email-scerveau@connected-labs.com>
Download mbox | patch
Permalink /patch/74479/
State New
Headers show

Comments

Stéphane Cerveau - June 30, 2014, 2:18 p.m.
Fix the use of command dirname on ubuntu 12.04.
dirname does not accept space in file name.

Signed-off-by: Stéphane Cerveau <scerveau@connected-labs.com>
---
 .../e2fsprogs/e2fsprogs-1.42.8/populate-extfs.sh   |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Stéphane Cerveau - June 30, 2014, 2:20 p.m.
This patch applies to master and daisy branches too.

On 06/30/2014 04:18 PM, Stéphane Cerveau wrote:
> Fix the use of command dirname on ubuntu 12.04.
> dirname does not accept space in file name.
>
> Signed-off-by: Stéphane Cerveau <scerveau@connected-labs.com>
> ---
>   .../e2fsprogs/e2fsprogs-1.42.8/populate-extfs.sh   |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.8/populate-extfs.sh b/meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.8/populate-extfs.sh
> index 26a8d89..47f5b5b 100644
> --- a/meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.8/populate-extfs.sh
> +++ b/meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.8/populate-extfs.sh
> @@ -28,7 +28,7 @@ DEBUGFS="debugfs"
>   		[ ! -z "$DIR" ] || continue
>   		[ ! -z "$TGT" ] || continue
>   
> -                DIR="$(dirname $DIR)"
> +                DIR="$(dirname "$DIR")"
>   
>   		if [ "$DIR" != "$CWD" ]; then
>   			echo "cd $DIR"
Richard Purdie - June 30, 2014, 2:51 p.m.
On Mon, 2014-06-30 at 16:20 +0200, Stephane Cerveau wrote:
> This patch applies to master and daisy branches too.

Really? 

That is a little odd since populate-extfs.sh was removed in them?

Cheers,

Richard
Stéphane Cerveau - June 30, 2014, 3:06 p.m.
Sorry i have been fooled by the poky web interface :(
Anyway the bug is real on dora branch.
Cheers

Stéphane

On 06/30/2014 04:51 PM, Richard Purdie wrote:
> On Mon, 2014-06-30 at 16:20 +0200, Stephane Cerveau wrote:
>> This patch applies to master and daisy branches too.
> Really?
>
> That is a little odd since populate-extfs.sh was removed in them?
>
> Cheers,
>
> Richard
>
Otavio Salvador - June 30, 2014, 3:08 p.m.
On Mon, Jun 30, 2014 at 12:06 PM, Stephane Cerveau
<scerveau@connected-labs.com> wrote:
> Sorry i have been fooled by the poky web interface :(
> Anyway the bug is real on dora branch.

Which branch did you test it?

You shouldn't say for backport something you didn't test.
Stéphane Cerveau - June 30, 2014, 3:11 p.m.
Dear Otavio,

I have been testing on dora branch.
I havent been testing on master and daisy, my mistake :(

On 06/30/2014 05:08 PM, Otavio Salvador wrote:
> On Mon, Jun 30, 2014 at 12:06 PM, Stephane Cerveau
> <scerveau@connected-labs.com> wrote:
>> Sorry i have been fooled by the poky web interface :(
>> Anyway the bug is real on dora branch.
> Which branch did you test it?
>
> You shouldn't say for backport something you didn't test.
>

Patch

diff --git a/meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.8/populate-extfs.sh b/meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.8/populate-extfs.sh
index 26a8d89..47f5b5b 100644
--- a/meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.8/populate-extfs.sh
+++ b/meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.8/populate-extfs.sh
@@ -28,7 +28,7 @@  DEBUGFS="debugfs"
 		[ ! -z "$DIR" ] || continue
 		[ ! -z "$TGT" ] || continue
 
-                DIR="$(dirname $DIR)"
+                DIR="$(dirname "$DIR")"
 
 		if [ "$DIR" != "$CWD" ]; then
 			echo "cd $DIR"