Patchwork image.bbclass: Ensure IMAGE_FSTYPES is fully evaluated before live/live logic

login
register
mail settings
Submitter Tom Rini
Date June 27, 2014, 12:42 p.m.
Message ID <20140627124209.GS9006@bill-the-cat>
Download mbox | patch
Permalink /patch/74429/
State New
Headers show

Comments

Tom Rini - June 27, 2014, 12:42 p.m.
On Thu, Jun 26, 2014 at 02:25:34PM -0300, Otavio Salvador wrote:
> On Thu, Jun 26, 2014 at 9:27 AM, Tom Rini <tom.rini@gmail.com> wrote:
> > Incase we have overrides applied to IMAGE_FSTYPES we need to make sure
> > that we evaluate it fully before performing the live and vmdk logic
> > checks.
> >
> > Signed-off-by: Tom Rini <tom.rini@gmail.com>
> 
> Do you have an example how it used to fail?

Sure:
And now you won't get vmdk images on qemux86-64 (same for live, did the
same proof-of-concept there when working up the patch).
Otavio Salvador - June 27, 2014, 1:11 p.m.
On Fri, Jun 27, 2014 at 9:42 AM, Tom Rini <tom.rini@gmail.com> wrote:
> On Thu, Jun 26, 2014 at 02:25:34PM -0300, Otavio Salvador wrote:
>> On Thu, Jun 26, 2014 at 9:27 AM, Tom Rini <tom.rini@gmail.com> wrote:
>> > Incase we have overrides applied to IMAGE_FSTYPES we need to make sure
>> > that we evaluate it fully before performing the live and vmdk logic
>> > checks.
>> >
>> > Signed-off-by: Tom Rini <tom.rini@gmail.com>
>>
>> Do you have an example how it used to fail?
>
> Sure:
> diff --git a/meta/recipes-core/images/build-appliance-image_8.0.bb b/meta/recipes-core/images/build-appliance-image_8.0.bb
> index 7b70025..23bb02e 100644
> --- a/meta/recipes-core/images/build-appliance-image_8.0.bb
> +++ b/meta/recipes-core/images/build-appliance-image_8.0.bb
> @@ -17,7 +17,7 @@ IMAGE_ROOTFS_EXTRA_SPACE = "41943040"
>  APPEND += "quiet"
>
>  DEPENDS = "zip-native"
> -IMAGE_FSTYPES = "vmdk"
> +IMAGE_FSTYPES_x86-64 = "vmdk"
>
>  inherit core-image
>
> And now you won't get vmdk images on qemux86-64 (same for live, did the
> same proof-of-concept there when working up the patch).

Isn't it a bug in BitBake?

I'd expect it to work fine. Richard, can you provide some feedback?

Patch

diff --git a/meta/recipes-core/images/build-appliance-image_8.0.bb b/meta/recipes-core/images/build-appliance-image_8.0.bb
index 7b70025..23bb02e 100644
--- a/meta/recipes-core/images/build-appliance-image_8.0.bb
+++ b/meta/recipes-core/images/build-appliance-image_8.0.bb
@@ -17,7 +17,7 @@  IMAGE_ROOTFS_EXTRA_SPACE = "41943040"
 APPEND += "quiet"
 
 DEPENDS = "zip-native"
-IMAGE_FSTYPES = "vmdk"
+IMAGE_FSTYPES_x86-64 = "vmdk"
 
 inherit core-image