Patchwork libusb: add missing build dependency on udev

login
register
mail settings
Submitter Fabien Chereau
Date June 26, 2014, 10:20 a.m.
Message ID <1403778002-10155-1-git-send-email-fabien.chereau@intel.com>
Download mbox | patch
Permalink /patch/74407/
State Accepted
Commit 20561edd64f01d3216aa4aa8c3b32393954f84cb
Headers show

Comments

Fabien Chereau - June 26, 2014, 10:20 a.m.
This fixes the ./configure error in case libusb is built before udev/systemd.

Signed-off-by: Fabien Chereau <fabien.chereau@intel.com>
---
 meta/recipes-support/libusb/libusb1_1.0.19.bb | 2 ++
 1 file changed, 2 insertions(+)
Richard Purdie - June 29, 2014, 9:05 a.m.
On Thu, 2014-06-26 at 12:20 +0200, Fabien Chereau wrote:
> This fixes the ./configure error in case libusb is built before udev/systemd.
> 
> Signed-off-by: Fabien Chereau <fabien.chereau@intel.com>
> ---
>  meta/recipes-support/libusb/libusb1_1.0.19.bb | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/meta/recipes-support/libusb/libusb1_1.0.19.bb b/meta/recipes-support/libusb/libusb1_1.0.19.bb
> index a20e1fc..be2be9d 100644
> --- a/meta/recipes-support/libusb/libusb1_1.0.19.bb
> +++ b/meta/recipes-support/libusb/libusb1_1.0.19.bb
> @@ -6,6 +6,8 @@ SECTION = "libs"
>  LICENSE = "LGPLv2.1+"
>  LIC_FILES_CHKSUM = "file://COPYING;md5=fbc093901857fcd118f065f900982c24"
>  
> +DEPENDS_append = " udev"
> +
>  BBCLASSEXTEND = "native nativesdk"
>  
>  SRC_URI = "${SOURCEFORGE_MIRROR}/libusb/libusb-${PV}.tar.bz2 \

This causes the build to explode with circular dependency issues. How
did you test this?

https://autobuilder.yoctoproject.org/main/builders/nightly-ppc-lsb/builds/147/steps/BuildImages/logs/stdio

There is a second error about a missing nativesdk-udev dependency (to
build nativesdk-libusb1) too.

Cheers,

Richard
Fabien Chereau - June 30, 2014, 2:10 p.m.
Hi Richard,

In fact I had an issue in case systemd was used instead of sysV but I can't reproduce this anymore after a full sstate clean.. I also had the same issue as you mention when using sysV.

So I clearly didn't tested the patch enough, sorry about that.

Fabien

Patch

diff --git a/meta/recipes-support/libusb/libusb1_1.0.19.bb b/meta/recipes-support/libusb/libusb1_1.0.19.bb
index a20e1fc..be2be9d 100644
--- a/meta/recipes-support/libusb/libusb1_1.0.19.bb
+++ b/meta/recipes-support/libusb/libusb1_1.0.19.bb
@@ -6,6 +6,8 @@  SECTION = "libs"
 LICENSE = "LGPLv2.1+"
 LIC_FILES_CHKSUM = "file://COPYING;md5=fbc093901857fcd118f065f900982c24"
 
+DEPENDS_append = " udev"
+
 BBCLASSEXTEND = "native nativesdk"
 
 SRC_URI = "${SOURCEFORGE_MIRROR}/libusb/libusb-${PV}.tar.bz2 \