Patchwork [V2] kernel.bbclass: add task dependency between bundle_initramfs and package

login
register
mail settings
Submitter Ming Liu
Date June 25, 2014, 1:57 a.m.
Message ID <1403661432-26466-1-git-send-email-ming.liu@windriver.com>
Download mbox | patch
Permalink /patch/74349/
State New
Headers show

Comments

Ming Liu - June 25, 2014, 1:57 a.m.
To ensure the bundled image to be packaged into kernel-image, otherwise, If
bundle_initramfs runs after do_package, the bundled kernel and initramfs
will not be part of the kernel-image package. This can result in boot
failures and other issues when the kernel-image is deployed.

Signed-off-by: Ming Liu <ming.liu@windriver.com>
---
 meta/classes/kernel.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Ming Liu - June 25, 2014, 7:13 a.m.
Please ignore this V2 too, I found a drawback that if the kernel-module* 
are added to the initramfs image, then it will lead us to a circular 
dependency risk, maybe we should not add this dependency at all.

//Ming Liu

On 06/25/2014 09:57 AM, Ming Liu wrote:
> To ensure the bundled image to be packaged into kernel-image, otherwise, If
> bundle_initramfs runs after do_package, the bundled kernel and initramfs
> will not be part of the kernel-image package. This can result in boot
> failures and other issues when the kernel-image is deployed.
>
> Signed-off-by: Ming Liu <ming.liu@windriver.com>
> ---
>   meta/classes/kernel.bbclass | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index 6ed1cb7..764a9ec 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -146,7 +146,7 @@ python do_devshell_prepend () {
>       os.environ["LDFLAGS"] = ''
>   }
>   
> -addtask bundle_initramfs after do_install before do_deploy
> +addtask bundle_initramfs after do_install before do_deploy do_package
>   
>   kernel_do_compile() {
>   	unset CFLAGS CPPFLAGS CXXFLAGS LDFLAGS MACHINE

Patch

diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
index 6ed1cb7..764a9ec 100644
--- a/meta/classes/kernel.bbclass
+++ b/meta/classes/kernel.bbclass
@@ -146,7 +146,7 @@  python do_devshell_prepend () {
     os.environ["LDFLAGS"] = ''
 }
 
-addtask bundle_initramfs after do_install before do_deploy
+addtask bundle_initramfs after do_install before do_deploy do_package
 
 kernel_do_compile() {
 	unset CFLAGS CPPFLAGS CXXFLAGS LDFLAGS MACHINE