Patchwork [0/5] Update iptables runtime recommends and add default init scripts and configs

login
register
mail settings
Submitter Kang Kai
Date June 23, 2014, 2:32 a.m.
Message ID <cover.1403490121.git.kai.kang@windriver.com>
Download mbox
Permalink /patch/74219/
State New
Headers show

Pull-request

git://git.pokylinux.org/poky-contrib kangkai/iptables

Comments

Kang Kai - June 23, 2014, 2:32 a.m.
Update iptables runtime recommends and add default init scripts and configs from redhat. That gives users rudimental configures and users only need to update their own iptables rules.

The following changes since commit 7c1a975a1c2fd884aa9f6f4736656d854a6c5edb:

  bitbake: toaster: Fix spacing and layout in no image files notification (2014-06-20 14:03:58 +0100)

are available in the git repository at:

  git://git.pokylinux.org/poky-contrib kangkai/iptables
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=kangkai/iptables

Kai Kang (5):
  iptables: update RRECOMMENDS
  iptables: add init script and configure file
  iptables: add default rules
  iptables: update rules for ip6tables
  iptables: update init script and bb file

 .../iptables/iptables/ip6tables.rules              |  31 ++
 .../iptables/iptables/iptables-config              |  54 +++
 .../iptables/iptables/iptables.init                | 445 +++++++++++++++++++++
 .../iptables/iptables/iptables.rules               |  30 ++
 meta/recipes-extended/iptables/iptables_1.4.21.bb  |  27 +-
 5 files changed, 586 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-extended/iptables/iptables/ip6tables.rules
 create mode 100644 meta/recipes-extended/iptables/iptables/iptables-config
 create mode 100755 meta/recipes-extended/iptables/iptables/iptables.init
 create mode 100644 meta/recipes-extended/iptables/iptables/iptables.rules
Ross Burton - June 23, 2014, 10:44 a.m.
> Kai Kang (5):
>   iptables: update RRECOMMENDS
>   iptables: add init script and configure file
>   iptables: update init script and bb file

Squash these so there's a single commit that adds and integrates a
working init script.

>   iptables: add default rules
>   iptables: update rules for ip6tables

Ditto, squash these into a single commit.

Ross
Kang Kai - June 24, 2014, 1:57 a.m.
On 2014?06?23? 18:44, Burton, Ross wrote:
>> Kai Kang (5):
>>    iptables: update RRECOMMENDS
>>    iptables: add init script and configure file
>>    iptables: update init script and bb file
> Squash these so there's a single commit that adds and integrates a
> working init script.

Though there is small change for init script, I still want to keep it 
that make clear which part is our modification.

I prefer to squash

iptables: update RRECOMMENDS
iptables: update init script and bb file

and keep
iptables: add init script and configure file




>
>>    iptables: add default rules
>>    iptables: update rules for ip6tables
> Ditto, squash these into a single commit.

I prefer to keep them too.

Regards,
Kai

>
> Ross
>
>