Patchwork [1/1] insane.bbclass: skip rdepends QA checks for kernel / modules

login
register
mail settings
Submitter Paul Eggleton
Date July 12, 2011, 1:29 p.m.
Message ID <901d1d04284eaa806af61557f46bf35c07970b01.1310477287.git.paul.eggleton@linux.intel.com>
Download mbox | patch
Permalink /patch/7411/
State Accepted
Headers show

Comments

Paul Eggleton - July 12, 2011, 1:29 p.m.
The kernel and module recipes have very few dbg/dev packages, however
they can easily have false positive results from the rdepends QA checks
(e.g. kernel-module-lirc-dev). Thus disable these tests for any recipe
that inherits kernel or module-base.

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
---
 meta/classes/insane.bbclass |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
Richard Purdie - July 12, 2011, 2:22 p.m.
On Tue, 2011-07-12 at 14:29 +0100, Paul Eggleton wrote:
> The kernel and module recipes have very few dbg/dev packages, however
> they can easily have false positive results from the rdepends QA checks
> (e.g. kernel-module-lirc-dev). Thus disable these tests for any recipe
> that inherits kernel or module-base.
> 
> Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
> ---
>  meta/classes/insane.bbclass |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)

Merged to master, thanks.

Richard

Patch

diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
index c1db1ca..aedd55c 100644
--- a/meta/classes/insane.bbclass
+++ b/meta/classes/insane.bbclass
@@ -416,6 +416,11 @@  def package_qa_walk(path, warnfuncs, errorfuncs, skip, package, d):
     return len(errors) == 0
 
 def package_qa_check_rdepends(pkg, pkgdest, skip, d):
+    # Don't do this check for kernel/module recipes, there aren't too many debug/development
+    # packages and you can get false positives e.g. on kernel-module-lirc-dev
+    if bb.data.inherits_class("kernel", d) or bb.data.inherits_class("module-base", d):
+        return True
+
     sane = True
     if not "-dbg" in pkg and not "task-" in pkg and not "-image" in pkg:
         # Copied from package_ipk.bbclass