Patchwork [dora,2/2] error out if debugfs encounters some error

mail settings
Date June 19, 2014, 2:11 a.m.
Message ID <>
Download mbox | patch
Permalink /patch/74047/
State New
Headers show

Comments - June 19, 2014, 2:11 a.m.
Previously, even if we encounter some error when populating the
ext filesystem, we don't error out and the rootfs process still

However, what's really expected is that the script
should error out if something wrong happens when using `debugfs' to
generate the ext filesystem. For example, if there's not enough block
in the filesystem, and allocating a block for some file fails, the
failure should not be ignored. Otherwise, we will have a successful
build but a corrupted filesystem.

The debugfs returns 0 as long as the command is valid. That is, even
if the command fails, the debugfs still returns 0. That's really a
pain here. That's why this patch checks the error output to see whether
there's any error logged.

Signed-off-by: Chen Qi <>
 .../e2fsprogs/e2fsprogs-1.42.8/   |    7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)


diff --git a/meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.8/ b/meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.8/
index da3954e..23d97d3 100644
--- a/meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.8/
+++ b/meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.8/
@@ -94,4 +94,9 @@  DEBUGFS="debugfs"
 		echo "sif $SRC links_count $LN_CNT"
 	rm -fr $INODE_DIR
-} | $DEBUGFS -w -f - $DEVICE
+} | $DEBUGFS -w -f - $DEVICE 2>&1 1>/dev/null | grep '.*: .*'
+if [ $? = 0 ]; then
+    echo "Some error occured while executing [$DEBUGFS -w -f - $DEVICE]"
+    exit 1