Patchwork [1/3] perf: add slang to the dependencies

login
register
mail settings
Submitter Henning Heinold
Date June 9, 2014, 9:21 p.m.
Message ID <1402348889-26065-2-git-send-email-henning@itconsulting-heinold.de>
Download mbox | patch
Permalink /patch/73563/
State New
Headers show

Comments

Henning Heinold - June 9, 2014, 9:21 p.m.
* some kernels depends on newt, some on slang and some on boths
* changing TUI_DEFINES is not necessary, because NO_NEWT is
  compatible with all kernels

The patch was sponsored by sysmocom

Signed-off-by: Henning Heinold <henning@itconsulting-heinold.de>
---
 meta/recipes-kernel/perf/perf.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Richard Purdie - June 13, 2014, 4:43 p.m.
On Mon, 2014-06-09 at 23:21 +0200, Henning Heinold wrote:
> * some kernels depends on newt, some on slang and some on boths
> * changing TUI_DEFINES is not necessary, because NO_NEWT is
>   compatible with all kernels
> 
> The patch was sponsored by sysmocom
> 
> Signed-off-by: Henning Heinold <henning@itconsulting-heinold.de>
> ---
>  meta/recipes-kernel/perf/perf.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-kernel/perf/perf.bb b/meta/recipes-kernel/perf/perf.bb
> index ef21b6c..adbecfd 100644
> --- a/meta/recipes-kernel/perf/perf.bb
> +++ b/meta/recipes-kernel/perf/perf.bb
> @@ -15,7 +15,7 @@ require perf-features.inc
>  
>  BUILDPERF_libc-uclibc = "no"
>  
> -TUI_DEPENDS = "${@perf_feature_enabled('perf-tui', 'libnewt', '',d)}"
> +TUI_DEPENDS = "${@perf_feature_enabled('perf-tui', 'libnewt slang', '',d)}"
>  SCRIPTING_DEPENDS = "${@perf_feature_enabled('perf-scripting', 'perl python', '',d)}"

Can we put a comment in the recipe about the problem here so that we
remember why we have the dependencies when looking back in the future
please?

Cheers,

Richard

Patch

diff --git a/meta/recipes-kernel/perf/perf.bb b/meta/recipes-kernel/perf/perf.bb
index ef21b6c..adbecfd 100644
--- a/meta/recipes-kernel/perf/perf.bb
+++ b/meta/recipes-kernel/perf/perf.bb
@@ -15,7 +15,7 @@  require perf-features.inc
 
 BUILDPERF_libc-uclibc = "no"
 
-TUI_DEPENDS = "${@perf_feature_enabled('perf-tui', 'libnewt', '',d)}"
+TUI_DEPENDS = "${@perf_feature_enabled('perf-tui', 'libnewt slang', '',d)}"
 SCRIPTING_DEPENDS = "${@perf_feature_enabled('perf-scripting', 'perl python', '',d)}"
 
 DEPENDS = "virtual/kernel \