Patchwork [2/3] perf: fix broken shell comparsion in do_install

login
register
mail settings
Submitter Henning Heinold
Date June 9, 2014, 9:21 p.m.
Message ID <1402348889-26065-3-git-send-email-henning@itconsulting-heinold.de>
Download mbox | patch
Permalink /patch/73561/
State New
Headers show

Comments

Henning Heinold - June 9, 2014, 9:21 p.m.
The patch was sponsored by sysmocom

Signed-off-by: Henning Heinold <henning@itconsulting-heinold.de>
---
 meta/recipes-kernel/perf/perf.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Bruce Ashfield - June 10, 2014, 12:35 a.m.
When describing something as broken in the short log, it's typically a good
idea to also include the symptoms, and the fix. That way the log will tell
someone experience a particular problem that this change indeed addresses
their problem.

Bruce

On Mon, Jun 9, 2014 at 5:21 PM, Henning Heinold
<henning@itconsulting-heinold.de> wrote:
> The patch was sponsored by sysmocom
>
> Signed-off-by: Henning Heinold <henning@itconsulting-heinold.de>
> ---
>  meta/recipes-kernel/perf/perf.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-kernel/perf/perf.bb b/meta/recipes-kernel/perf/perf.bb
> index adbecfd..74686ca 100644
> --- a/meta/recipes-kernel/perf/perf.bb
> +++ b/meta/recipes-kernel/perf/perf.bb
> @@ -112,7 +112,7 @@ do_install() {
>         unset CFLAGS
>         oe_runmake DESTDIR=${D} install
>         # we are checking for this make target to be compatible with older perf versions
> -       if [ "${@perf_feature_enabled('perf-scripting', 1, 0, d)}" = "1" -a $(grep install-python_ext ${S}/tools/perf/Makefile) = "0"]; then
> +       if [ "${@perf_feature_enabled('perf-scripting', 1, 0, d)}" = "1" -a $(grep install-python_ext ${S}/tools/perf/Makefile) = "0" ]; then
>                 oe_runmake DESTDIR=${D} install-python_ext
>         fi
>  }
> --
> 1.9.1
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
Henning Heinold - June 10, 2014, 11:06 a.m.
On Mon, Jun 09, 2014 at 08:35:06PM -0400, Bruce Ashfield wrote:
> When describing something as broken in the short log, it's typically a good
> idea to also include the symptoms, and the fix. That way the log will tell
> someone experience a particular problem that this change indeed addresses
> their problem.
> 
> Bruce

Hi Bruce,

there was no error shown, the build succeeded always. I stumbled over it
by reading the bb file.

Bye Henning

Patch

diff --git a/meta/recipes-kernel/perf/perf.bb b/meta/recipes-kernel/perf/perf.bb
index adbecfd..74686ca 100644
--- a/meta/recipes-kernel/perf/perf.bb
+++ b/meta/recipes-kernel/perf/perf.bb
@@ -112,7 +112,7 @@  do_install() {
 	unset CFLAGS
 	oe_runmake DESTDIR=${D} install
 	# we are checking for this make target to be compatible with older perf versions
-	if [ "${@perf_feature_enabled('perf-scripting', 1, 0, d)}" = "1" -a $(grep install-python_ext ${S}/tools/perf/Makefile) = "0"]; then
+	if [ "${@perf_feature_enabled('perf-scripting', 1, 0, d)}" = "1" -a $(grep install-python_ext ${S}/tools/perf/Makefile) = "0" ]; then
 		oe_runmake DESTDIR=${D} install-python_ext
 	fi
 }