Patchwork cups: Fix build failure

login
register
mail settings
Submitter Armin Kuster
Date June 7, 2014, 2:30 p.m.
Message ID <1402151406-14527-1-git-send-email-akuster@mvista.com>
Download mbox | patch
Permalink /patch/73467/
State New
Headers show

Comments

Armin Kuster - June 7, 2014, 2:30 p.m.
The follwing error was seen when no crypt dependency was included.

In file included from cups-private.h:29:0,
|                  from attr.c:26:
| http-private.h:83:24: fatal error: gcrypt.h: No such file or directory
|  #    include <gcrypt.h>
|                         ^

Add bcrypt to DEPENDS

Signed-off-by: Armin Kuster <akuster@mvista.com>
---
 meta/recipes-extended/cups/cups.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Saul Wold - June 8, 2014, 4:02 a.m.
On 06/07/2014 07:30 AM, Armin Kuster wrote:
> The follwing error was seen when no crypt dependency was included.
>
> In file included from cups-private.h:29:0,
> |                  from attr.c:26:
> | http-private.h:83:24: fatal error: gcrypt.h: No such file or directory
> |  #    include <gcrypt.h>
> |                         ^
>
> Add bcrypt to DEPENDS
>
> Signed-off-by: Armin Kuster <akuster@mvista.com>
> ---
>   meta/recipes-extended/cups/cups.inc | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-extended/cups/cups.inc b/meta/recipes-extended/cups/cups.inc
> index fd88552..249eac4 100644
> --- a/meta/recipes-extended/cups/cups.inc
> +++ b/meta/recipes-extended/cups/cups.inc
> @@ -1,7 +1,7 @@
>   SUMMARY = "An Internet printing system for Unix"
>   SECTION = "console/utils"
>   LICENSE = "GPLv2 & LGPLv2"
> -DEPENDS = "gnutls libpng jpeg dbus dbus-glib zlib libusb"
> +DEPENDS = "gnutls libpng jpeg dbus dbus-glib zlib libusb bcrypt"

Do we really want to enable crypt here or make it optional?  If we set 
ac_cv_search_crypt=no on the EXTRA_OECONF line, then we can remove this 
floating dependency or make it a PACKAGECONFIG setting

Sau!

>   PROVIDES = "cups14"
>
>   SRC_URI = "http://www.cups.org/software/${PV}/${BP}-source.tar.bz2 \
>
Armin Kuster - June 8, 2014, 7:50 p.m.
On 06/07/2014 09:02 PM, Saul Wold wrote:
> On 06/07/2014 07:30 AM, Armin Kuster wrote:
>> The follwing error was seen when no crypt dependency was included.
>>
>> In file included from cups-private.h:29:0,
>> |                  from attr.c:26:
>> | http-private.h:83:24: fatal error: gcrypt.h: No such file or directory
>> |  #    include <gcrypt.h>
>> |                         ^
>>
>> Add bcrypt to DEPENDS
>>
>> Signed-off-by: Armin Kuster <akuster@mvista.com>
>> ---
>>   meta/recipes-extended/cups/cups.inc | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-extended/cups/cups.inc 
>> b/meta/recipes-extended/cups/cups.inc
>> index fd88552..249eac4 100644
>> --- a/meta/recipes-extended/cups/cups.inc
>> +++ b/meta/recipes-extended/cups/cups.inc
>> @@ -1,7 +1,7 @@
>>   SUMMARY = "An Internet printing system for Unix"
>>   SECTION = "console/utils"
>>   LICENSE = "GPLv2 & LGPLv2"
>> -DEPENDS = "gnutls libpng jpeg dbus dbus-glib zlib libusb"
>> +DEPENDS = "gnutls libpng jpeg dbus dbus-glib zlib libusb bcrypt"
>
> Do we really want to enable crypt here or make it optional?

Good question.
> If we set ac_cv_search_crypt=no on the EXTRA_OECONF line, then we can 
> remove this floating dependency or make it a PACKAGECONFIG setting
Ok.  let me work on this a bit more.

- Armin

>
> Sau!
>
>>   PROVIDES = "cups14"
>>
>>   SRC_URI = "http://www.cups.org/software/${PV}/${BP}-source.tar.bz2 \
>>
Armin Kuster - June 9, 2014, 8:22 p.m.
Saul,

I found a fix from cups.org to address this. I have back ported the 
patch and will submit a v2  cups patch

thanks,
- Armin

On 06/07/2014 09:02 PM, Saul Wold wrote:
> On 06/07/2014 07:30 AM, Armin Kuster wrote:
>> The follwing error was seen when no crypt dependency was included.
>>
>> In file included from cups-private.h:29:0,
>> |                  from attr.c:26:
>> | http-private.h:83:24: fatal error: gcrypt.h: No such file or directory
>> |  #    include <gcrypt.h>
>> |                         ^
>>
>> Add bcrypt to DEPENDS
>>
>> Signed-off-by: Armin Kuster <akuster@mvista.com>
>> ---
>>   meta/recipes-extended/cups/cups.inc | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-extended/cups/cups.inc 
>> b/meta/recipes-extended/cups/cups.inc
>> index fd88552..249eac4 100644
>> --- a/meta/recipes-extended/cups/cups.inc
>> +++ b/meta/recipes-extended/cups/cups.inc
>> @@ -1,7 +1,7 @@
>>   SUMMARY = "An Internet printing system for Unix"
>>   SECTION = "console/utils"
>>   LICENSE = "GPLv2 & LGPLv2"
>> -DEPENDS = "gnutls libpng jpeg dbus dbus-glib zlib libusb"
>> +DEPENDS = "gnutls libpng jpeg dbus dbus-glib zlib libusb bcrypt"
>
> Do we really want to enable crypt here or make it optional?  If we set 
> ac_cv_search_crypt=no on the EXTRA_OECONF line, then we can remove 
> this floating dependency or make it a PACKAGECONFIG setting
>
> Sau!
>
>>   PROVIDES = "cups14"
>>
>>   SRC_URI = "http://www.cups.org/software/${PV}/${BP}-source.tar.bz2 \
>>

Patch

diff --git a/meta/recipes-extended/cups/cups.inc b/meta/recipes-extended/cups/cups.inc
index fd88552..249eac4 100644
--- a/meta/recipes-extended/cups/cups.inc
+++ b/meta/recipes-extended/cups/cups.inc
@@ -1,7 +1,7 @@ 
 SUMMARY = "An Internet printing system for Unix"
 SECTION = "console/utils"
 LICENSE = "GPLv2 & LGPLv2"
-DEPENDS = "gnutls libpng jpeg dbus dbus-glib zlib libusb"
+DEPENDS = "gnutls libpng jpeg dbus dbus-glib zlib libusb bcrypt"
 PROVIDES = "cups14"
 
 SRC_URI = "http://www.cups.org/software/${PV}/${BP}-source.tar.bz2 \