Patchwork lvm2.inc: EXTRA_OECONF is been overwrited

login
register
mail settings
Submitter yaoxp
Date June 6, 2014, 3:26 a.m.
Message ID <1402025177-7694-1-git-send-email-yaoxp@cn.fujitsu.com>
Download mbox | patch
Permalink /patch/73369/
State New
Headers show

Comments

yaoxp - June 6, 2014, 3:26 a.m.
EXTRA_OECONF has been assigned before ‘EXTRA_OECONF = "--with-usrlibdir=${libdir}"’.

So, ‘EXTRA_OECONF = "--with-usrlibdir=${libdir}"’ should be changed to
‘EXTRA_OECONF += "--with-usrlibdir=${libdir}"’.

Signed-off-by: Yao Xinpan <yaoxp@cn.fujitsu.com>
---
 meta-oe/recipes-support/lvm2/lvm2.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Martin Jansa - June 6, 2014, 9:17 a.m.
On Thu, Jun 05, 2014 at 11:26:17PM -0400, Yao Xinpan wrote:
> EXTRA_OECONF has been assigned before ‘EXTRA_OECONF = "--with-usrlibdir=${libdir}"’.
> 
> So, ‘EXTRA_OECONF = "--with-usrlibdir=${libdir}"’ should be changed to
> ‘EXTRA_OECONF += "--with-usrlibdir=${libdir}"’.
> 
> Signed-off-by: Yao Xinpan <yaoxp@cn.fujitsu.com>
> ---
>  meta-oe/recipes-support/lvm2/lvm2.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta-oe/recipes-support/lvm2/lvm2.inc b/meta-oe/recipes-support/lvm2/lvm2.inc
> index c6a9ec0..71f782a 100644
> --- a/meta-oe/recipes-support/lvm2/lvm2.inc
> +++ b/meta-oe/recipes-support/lvm2/lvm2.inc
> @@ -47,4 +47,4 @@ FILES_${PN} += "${libdir}/device-mapper/*.so ${base_libdir}/udev"
>  FILES_${PN}-dbg += "${libdir}/device-mapper/.debug"
>  
>  RDEPENDS_${PN} = "bash"
> -EXTRA_OECONF = "--with-usrlibdir=${libdir}"
> +EXTRA_OECONF += "--with-usrlibdir=${libdir}"

Please send it to openembedded-devel@lists.openembedded.org with right
subject tag (see README file)

> -- 
> 1.8.4.2
> 
> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
Koen Kooi - June 6, 2014, 9:27 a.m.
Op 6 jun. 2014, om 11:17 heeft Martin Jansa <martin.jansa@gmail.com> het volgende geschreven:

> On Thu, Jun 05, 2014 at 11:26:17PM -0400, Yao Xinpan wrote:
>> EXTRA_OECONF has been assigned before ‘EXTRA_OECONF = "--with-usrlibdir=${libdir}"’.
>> 
>> So, ‘EXTRA_OECONF = "--with-usrlibdir=${libdir}"’ should be changed to
>> ‘EXTRA_OECONF += "--with-usrlibdir=${libdir}"’.
>> 
>> Signed-off-by: Yao Xinpan <yaoxp@cn.fujitsu.com>
>> ---
>> meta-oe/recipes-support/lvm2/lvm2.inc | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/meta-oe/recipes-support/lvm2/lvm2.inc b/meta-oe/recipes-support/lvm2/lvm2.inc
>> index c6a9ec0..71f782a 100644
>> --- a/meta-oe/recipes-support/lvm2/lvm2.inc
>> +++ b/meta-oe/recipes-support/lvm2/lvm2.inc
>> @@ -47,4 +47,4 @@ FILES_${PN} += "${libdir}/device-mapper/*.so ${base_libdir}/udev"
>> FILES_${PN}-dbg += "${libdir}/device-mapper/.debug"
>> 
>> RDEPENDS_${PN} = "bash"
>> -EXTRA_OECONF = "--with-usrlibdir=${libdir}"
>> +EXTRA_OECONF += "--with-usrlibdir=${libdir}"
> 
> Please send it to openembedded-devel@lists.openembedded.org with right
> subject tag (see README file)


And just collaps the 2 lines into a single EXTRA_OECONF. I don't know how that EXTRA_OECONF below RDEPENDS got through review, but it shouldn't have.

Patch

diff --git a/meta-oe/recipes-support/lvm2/lvm2.inc b/meta-oe/recipes-support/lvm2/lvm2.inc
index c6a9ec0..71f782a 100644
--- a/meta-oe/recipes-support/lvm2/lvm2.inc
+++ b/meta-oe/recipes-support/lvm2/lvm2.inc
@@ -47,4 +47,4 @@  FILES_${PN} += "${libdir}/device-mapper/*.so ${base_libdir}/udev"
 FILES_${PN}-dbg += "${libdir}/device-mapper/.debug"
 
 RDEPENDS_${PN} = "bash"
-EXTRA_OECONF = "--with-usrlibdir=${libdir}"
+EXTRA_OECONF += "--with-usrlibdir=${libdir}"