Patchwork [meta-oe] dfu-util 0.7 recipe, remove old 0.1 recipe

login
register
mail settings
Submitter Chris Morgan
Date June 1, 2014, 5:42 p.m.
Message ID <CAAPegz1J+4vrvOF3F9Rj11_0-Lhd0ybFFci-_UXgLtVBhxreYg@mail.gmail.com>
Download mbox | patch
Permalink /patch/73051/
State Accepted, archived
Headers show

Comments

Chris Morgan - June 1, 2014, 5:42 p.m.
dfu-util 0.7 is the latest release of dfu-util

Remove old dfu-util 0.1 recipe

Signed-off-by: Chris Morgan <chmorgan@gmail.com>
---
 meta-oe/recipes-support/dfu-util/dfu-util_0.1.bb | 10 ----------
 meta-oe/recipes-support/dfu-util/dfu-util_0.7.bb |  6 ++++++
 2 files changed, 6 insertions(+), 10 deletions(-)
 delete mode 100644 meta-oe/recipes-support/dfu-util/dfu-util_0.1.bb
 create mode 100644 meta-oe/recipes-support/dfu-util/dfu-util_0.7.bb

"f52a2a5489fbf9f3204a6ada05e0b47ee322e19d81c712e0c58a332d80ec3eab"
Otavio Salvador - June 2, 2014, 1:28 p.m.
On Sun, Jun 1, 2014 at 2:42 PM, Chris Morgan <chmorgan@gmail.com> wrote:
> dfu-util 0.7 is the latest release of dfu-util
>
> Remove old dfu-util 0.1 recipe
>
> Signed-off-by: Chris Morgan <chmorgan@gmail.com>

From the previous discussion it seems there is not reason to keep 0.4
around. So maybe it'd be good to remove it as well here?
Chris Morgan - June 2, 2014, 1:37 p.m.
On Mon, Jun 2, 2014 at 9:28 AM, Otavio Salvador <otavio@ossystems.com.br> wrote:
> On Sun, Jun 1, 2014 at 2:42 PM, Chris Morgan <chmorgan@gmail.com> wrote:
>> dfu-util 0.7 is the latest release of dfu-util
>>
>> Remove old dfu-util 0.1 recipe
>>
>> Signed-off-by: Chris Morgan <chmorgan@gmail.com>
>
> From the previous discussion it seems there is not reason to keep 0.4
> around. So maybe it'd be good to remove it as well here?
>
> --
> Otavio Salvador                             O.S. Systems
> http://www.ossystems.com.br        http://code.ossystems.com.br
> Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel


If it has to happen to get this change in then I can look at doing
that today. If not then I'd prefer this went in and then I'd be back
in sync with meta-oe and could remove 0.4 in the next patch. I'm
always weary of stacking up too many changes together or having too
many pending at once since I'm really new to the project.

Chris
Otavio Salvador - June 2, 2014, 2:11 p.m.
On Mon, Jun 2, 2014 at 10:37 AM, Chris Morgan <chmorgan@gmail.com> wrote:
> On Mon, Jun 2, 2014 at 9:28 AM, Otavio Salvador <otavio@ossystems.com.br> wrote:
>> On Sun, Jun 1, 2014 at 2:42 PM, Chris Morgan <chmorgan@gmail.com> wrote:
>>> dfu-util 0.7 is the latest release of dfu-util
>>>
>>> Remove old dfu-util 0.1 recipe
>>>
>>> Signed-off-by: Chris Morgan <chmorgan@gmail.com>
>>
>> From the previous discussion it seems there is not reason to keep 0.4
>> around. So maybe it'd be good to remove it as well here?
>
> If it has to happen to get this change in then I can look at doing
> that today. If not then I'd prefer this went in and then I'd be back
> in sync with meta-oe and could remove 0.4 in the next patch. I'm
> always weary of stacking up too many changes together or having too
> many pending at once since I'm really new to the project.

Great.
Chris Morgan - June 2, 2014, 2:25 p.m.
On Mon, Jun 2, 2014 at 10:11 AM, Otavio Salvador
<otavio@ossystems.com.br> wrote:
> On Mon, Jun 2, 2014 at 10:37 AM, Chris Morgan <chmorgan@gmail.com> wrote:
>> On Mon, Jun 2, 2014 at 9:28 AM, Otavio Salvador <otavio@ossystems.com.br> wrote:
>>> On Sun, Jun 1, 2014 at 2:42 PM, Chris Morgan <chmorgan@gmail.com> wrote:
>>>> dfu-util 0.7 is the latest release of dfu-util
>>>>
>>>> Remove old dfu-util 0.1 recipe
>>>>
>>>> Signed-off-by: Chris Morgan <chmorgan@gmail.com>
>>>
>>> From the previous discussion it seems there is not reason to keep 0.4
>>> around. So maybe it'd be good to remove it as well here?
>>
>> If it has to happen to get this change in then I can look at doing
>> that today. If not then I'd prefer this went in and then I'd be back
>> in sync with meta-oe and could remove 0.4 in the next patch. I'm
>> always weary of stacking up too many changes together or having too
>> many pending at once since I'm really new to the project.
>
> Great.
>
>

So is this commit ok to go in or need to also address issues around
removing 0.4? ;-)

Chris
Martin Jansa - June 4, 2014, 9:37 a.m.
On Sun, Jun 01, 2014 at 01:42:34PM -0400, Chris Morgan wrote:
> dfu-util 0.7 is the latest release of dfu-util
> 
> Remove old dfu-util 0.1 recipe

Please use git send-email, see extra line feeds you have in
'SRC_URI[sha256sum]' lines, this time I'll apply it manually, but next
time I'll just reject them.

Thanks

> Signed-off-by: Chris Morgan <chmorgan@gmail.com>
> ---
>  meta-oe/recipes-support/dfu-util/dfu-util_0.1.bb | 10 ----------
>  meta-oe/recipes-support/dfu-util/dfu-util_0.7.bb |  6 ++++++
>  2 files changed, 6 insertions(+), 10 deletions(-)
>  delete mode 100644 meta-oe/recipes-support/dfu-util/dfu-util_0.1.bb
>  create mode 100644 meta-oe/recipes-support/dfu-util/dfu-util_0.7.bb
> 
> diff --git a/meta-oe/recipes-support/dfu-util/dfu-util_0.1.bb
> b/meta-oe/recipes-support/dfu-util/dfu-util_0.1.bb
> deleted file mode 100644
> index b63d74d..0000000
> --- a/meta-oe/recipes-support/dfu-util/dfu-util_0.1.bb
> +++ /dev/null
> @@ -1,10 +0,0 @@
> -require dfu-util.inc
> -
> -PR = "r1"
> -
> -DEPENDS = "virtual/libusb0 usbpath"
> -
> -BBCLASSEXTEND = "native"
> -
> -SRC_URI[md5sum] = "454b931249d29e4a6c2a2ade17858490"
> -SRC_URI[sha256sum] =
> "a27cc667be9b158fecf0ed066698e30eca0c0b3cd7a85aad2058d47ffe16f0e1"
> diff --git a/meta-oe/recipes-support/dfu-util/dfu-util_0.7.bb
> b/meta-oe/recipes-support/dfu-util/dfu-util_0.7.bb
> new file mode 100644
> index 0000000..c4c030d
> --- /dev/null
> +++ b/meta-oe/recipes-support/dfu-util/dfu-util_0.7.bb
> @@ -0,0 +1,6 @@
> +require dfu-util.inc
> +
> +DEPENDS = "libusb1"
> +
> +SRC_URI[md5sum] = "56844020177d4db4c1ea2e926fe9d588"
> +SRC_URI[sha256sum] =
> "f52a2a5489fbf9f3204a6ada05e0b47ee322e19d81c712e0c58a332d80ec3eab"
> -- 
> 1.9.3
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Chris Morgan - June 4, 2014, 10:48 a.m.
On Wed, Jun 4, 2014 at 5:37 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
> On Sun, Jun 01, 2014 at 01:42:34PM -0400, Chris Morgan wrote:
>> dfu-util 0.7 is the latest release of dfu-util
>>
>> Remove old dfu-util 0.1 recipe
>
> Please use git send-email, see extra line feeds you have in
> 'SRC_URI[sha256sum]' lines, this time I'll apply it manually, but next
> time I'll just reject them.
>
> Thanks
>
>> Signed-off-by: Chris Morgan <chmorgan@gmail.com>
>> ---
>>  meta-oe/recipes-support/dfu-util/dfu-util_0.1.bb | 10 ----------
>>  meta-oe/recipes-support/dfu-util/dfu-util_0.7.bb |  6 ++++++
>>  2 files changed, 6 insertions(+), 10 deletions(-)
>>  delete mode 100644 meta-oe/recipes-support/dfu-util/dfu-util_0.1.bb
>>  create mode 100644 meta-oe/recipes-support/dfu-util/dfu-util_0.7.bb
>>
>> diff --git a/meta-oe/recipes-support/dfu-util/dfu-util_0.1.bb
>> b/meta-oe/recipes-support/dfu-util/dfu-util_0.1.bb
>> deleted file mode 100644
>> index b63d74d..0000000
>> --- a/meta-oe/recipes-support/dfu-util/dfu-util_0.1.bb
>> +++ /dev/null
>> @@ -1,10 +0,0 @@
>> -require dfu-util.inc
>> -
>> -PR = "r1"
>> -
>> -DEPENDS = "virtual/libusb0 usbpath"
>> -
>> -BBCLASSEXTEND = "native"
>> -
>> -SRC_URI[md5sum] = "454b931249d29e4a6c2a2ade17858490"
>> -SRC_URI[sha256sum] =
>> "a27cc667be9b158fecf0ed066698e30eca0c0b3cd7a85aad2058d47ffe16f0e1"
>> diff --git a/meta-oe/recipes-support/dfu-util/dfu-util_0.7.bb
>> b/meta-oe/recipes-support/dfu-util/dfu-util_0.7.bb
>> new file mode 100644
>> index 0000000..c4c030d
>> --- /dev/null
>> +++ b/meta-oe/recipes-support/dfu-util/dfu-util_0.7.bb
>> @@ -0,0 +1,6 @@
>> +require dfu-util.inc
>> +
>> +DEPENDS = "libusb1"
>> +
>> +SRC_URI[md5sum] = "56844020177d4db4c1ea2e926fe9d588"
>> +SRC_URI[sha256sum] =
>> "f52a2a5489fbf9f3204a6ada05e0b47ee322e19d81c712e0c58a332d80ec3eab"
>> --
>> 1.9.3
>> --
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
> --
> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>


Sorry about that. I had switched from attaching the file to using git
imap-send but I used git send-email and gmail's smtp server for the
resubmission of removing the dfu svn recipe patch.

Chris

Patch

diff --git a/meta-oe/recipes-support/dfu-util/dfu-util_0.1.bb
b/meta-oe/recipes-support/dfu-util/dfu-util_0.1.bb
deleted file mode 100644
index b63d74d..0000000
--- a/meta-oe/recipes-support/dfu-util/dfu-util_0.1.bb
+++ /dev/null
@@ -1,10 +0,0 @@ 
-require dfu-util.inc
-
-PR = "r1"
-
-DEPENDS = "virtual/libusb0 usbpath"
-
-BBCLASSEXTEND = "native"
-
-SRC_URI[md5sum] = "454b931249d29e4a6c2a2ade17858490"
-SRC_URI[sha256sum] =
"a27cc667be9b158fecf0ed066698e30eca0c0b3cd7a85aad2058d47ffe16f0e1"
diff --git a/meta-oe/recipes-support/dfu-util/dfu-util_0.7.bb
b/meta-oe/recipes-support/dfu-util/dfu-util_0.7.bb
new file mode 100644
index 0000000..c4c030d
--- /dev/null
+++ b/meta-oe/recipes-support/dfu-util/dfu-util_0.7.bb
@@ -0,0 +1,6 @@ 
+require dfu-util.inc
+
+DEPENDS = "libusb1"
+
+SRC_URI[md5sum] = "56844020177d4db4c1ea2e926fe9d588"
+SRC_URI[sha256sum] =