Patchwork [v2] gzip: Avoid host contamination during build

login
register
mail settings
Submitter danismostlikely@gmail.com
Date May 30, 2014, 9:39 p.m.
Message ID <CACS+7ZSNrb+Q7NkPpd3rz17ky6=DAuQY2mo0iF-2Mc9cUUxgeQ@mail.gmail.com>
Download mbox | patch
Permalink /patch/73035/
State New
Headers show

Comments

danismostlikely@gmail.com - May 30, 2014, 9:39 p.m.
From: Dan McGregor <dan.mcgregor@usask.ca>

On systems with /bin and /usr/bin merged the gzip recipe may find grep
in /usr/bin, while OE puts it in /bin. Force the recipe to find grep in
the correct place.

Signed-off-by: Dan McGregor <dan.mcgregor@usask.ca>
---
 meta/recipes-extended/gzip/gzip.inc | 2 ++
 1 file changed, 2 insertions(+)
Otavio Salvador - June 2, 2014, 11:10 a.m.
On Fri, May 30, 2014 at 6:39 PM, Dan McGregor <danismostlikely@gmail.com> wrote:
> From: Dan McGregor <dan.mcgregor@usask.ca>
>
> On systems with /bin and /usr/bin merged the gzip recipe may find grep
> in /usr/bin, while OE puts it in /bin. Force the recipe to find grep in
> the correct place.
>
> Signed-off-by: Dan McGregor <dan.mcgregor@usask.ca>

Great fix. It seems like a good patch to backport to Daisy  (adding Saul in Cc).

Patch

diff --git a/meta/recipes-extended/gzip/gzip.inc
b/meta/recipes-extended/gzip/gzip.inc
index 920b256..5f0a5ca 100644
--- a/meta/recipes-extended/gzip/gzip.inc
+++ b/meta/recipes-extended/gzip/gzip.inc
@@ -12,6 +12,8 @@  SRC_URI = "${GNU_MIRROR}/gzip/${BP}.tar.gz"

 inherit autotools texinfo

+EXTRA_OEMAKE_class-target = "GREP=${base_bindir}/grep"
+
 do_install_append () {
  # Rename and move files into /bin (FHS), which is typical place for gzip
  install -d ${D}${base_bindir}