Patchwork [4/4] autoconf: don't disable the autoheader warnings

login
register
mail settings
Submitter Ross Burton
Date May 28, 2014, 11:56 a.m.
Message ID <a12ceb971fefe2b2f412f46b82c0d5ea6043ad62.1401277810.git.ross.burton@intel.com>
Download mbox | patch
Permalink /patch/72899/
State Accepted
Commit e2485940f980f462ca4b7894864d808dba605de8
Headers show

Comments

Ross Burton - May 28, 2014, 11:56 a.m.
The usual autoheader warning is due to AC_DEFINE variables not having a
description.  This results in no variable being defined in config.h, which leads
to code behaving as if the test failed when it actually succeeded.

This patch was introduced to OpenEmbedded back in 2004:

http://git.openembedded.org/openembedded/commit/?id=5eab06d132cb2895fd579f5cedffbb54c27794f8

There is no rationale for the patch so I suspect this is due to the warnings
being fatal and the submitter not understanding that the problem is more than
cosmetic.

Signed-off-by: Ross Burton <ross.burton@intel.com>
---
 .../autoconf/autoheader-nonfatal-warnings.patch         |   15 ---------------
 meta/recipes-devtools/autoconf/autoconf_2.69.bb         |    1 -
 2 files changed, 16 deletions(-)
 delete mode 100644 meta/recipes-devtools/autoconf/autoconf/autoheader-nonfatal-warnings.patch

Patch

diff --git a/meta/recipes-devtools/autoconf/autoconf/autoheader-nonfatal-warnings.patch b/meta/recipes-devtools/autoconf/autoconf/autoheader-nonfatal-warnings.patch
deleted file mode 100644
index 8ae6d5c..0000000
--- a/meta/recipes-devtools/autoconf/autoconf/autoheader-nonfatal-warnings.patch
+++ /dev/null
@@ -1,15 +0,0 @@ 
-Upstream-Status: Pending
-
---- autoconf-2.59/bin/autoheader.in~	2003-10-10 14:52:56.000000000 +0100
-+++ autoconf-2.59/bin/autoheader.in	2004-05-03 01:36:45.000000000 +0100
-@@ -272,8 +272,8 @@
- 	}
- 
-     }
--  exit 1
--    if keys %symbol;
-+#  exit 1
-+#    if keys %symbol;
- }
- 
- update_file ("$tmp/config.hin", "$config_h_in");
diff --git a/meta/recipes-devtools/autoconf/autoconf_2.69.bb b/meta/recipes-devtools/autoconf/autoconf_2.69.bb
index a2ecd94..5c652d4 100644
--- a/meta/recipes-devtools/autoconf/autoconf_2.69.bb
+++ b/meta/recipes-devtools/autoconf/autoconf_2.69.bb
@@ -12,7 +12,6 @@  SRC_URI += "file://autoreconf-include.patch \
 	    file://autoreconf-exclude.patch \
 	    file://autoreconf-foreign.patch \
 	    file://autoreconf-gnuconfigize.patch \
-	    file://autoheader-nonfatal-warnings.patch \
             file://config_site.patch \
             file://remove-usr-local-lib-from-m4.patch \
             file://preferbash.patch \