Patchwork [0/4,RFT] Stop disabling autoheader warnings

login
register
mail settings
Submitter Ross Burton
Date May 28, 2014, 11:56 a.m.
Message ID <cover.1401277810.git.ross.burton@intel.com>
Download mbox
Permalink /patch/72891/
State New
Headers show

Pull-request

git://git.yoctoproject.org/poky-contrib ross/autoconf

Comments

Ross Burton - May 28, 2014, 11:56 a.m.
Hi,

When autoheader emits a warning along the lines of "missing template for
variable HAVE_FOO", it's not moaning that you need to be more verbose for nice
comments in the config.h files.  In fact it's saying that it's not writing that
symbol at all to config.h.in, so even if that test succeeds this isn't reflected
in config.h.

I removed the patch and did a build of core-image-sato: readline was the only
recipe that failed.  I'll spare you the anger but readline is special...  the
short version is that if an upstream package hand-maintains config.h.in instead
of using autoheader then set EXTRA_AUTORECONF += "--exclude=autoheader" and
autoheader won't be executed.

This is also a call out for a request for testing: I've done a core-image-sato
build with this but haven't yet done world or any other layers.  If there's
breakage it's often due to the upstream being unconventional so feel free to
prod me for help.

Ross

The following changes since commit c42df8cb48ceb6081680ffb802e85dad557cf29c:

  i2c-tools: Add i2c-tools to the core (2014-05-28 09:42:14 +0100)

are available in the git repository at:

  git://git.yoctoproject.org/poky-contrib ross/autoconf

for you to fetch changes up to a12ceb971fefe2b2f412f46b82c0d5ea6043ad62:

  autoconf: don't disable the autoheader warnings (2014-05-28 12:47:58 +0100)

----------------------------------------------------------------
Ross Burton (4):
      readline: add missing STRUCT_DIRENT_D_* symbols to config.h.in
      readline: exclude autoheader from autoreconf
      readline: use upstream's aclocal.m4 as acinclude.m4
      autoconf: don't disable the autoheader warnings

 meta/recipes-core/readline/files/acinclude.m4      | 1871 --------------------
 .../readline-6.3/config-dirent-symbols.patch       |   34 +
 meta/recipes-core/readline/readline.inc            |   10 +-
 .../autoconf/autoheader-nonfatal-warnings.patch    |   15 -
 meta/recipes-devtools/autoconf/autoconf_2.69.bb    |    1 -
 5 files changed, 41 insertions(+), 1890 deletions(-)
 delete mode 100644 meta/recipes-core/readline/files/acinclude.m4
 create mode 100644 meta/recipes-core/readline/readline-6.3/config-dirent-symbols.patch
 delete mode 100644 meta/recipes-devtools/autoconf/autoconf/autoheader-nonfatal-warnings.patch

Ross Burton (4):
  readline: add missing STRUCT_DIRENT_D_* symbols to config.h.in
  readline: exclude autoheader from autoreconf
  readline: use upstream's aclocal.m4 as acinclude.m4
  autoconf: don't disable the autoheader warnings

 meta/recipes-core/readline/files/acinclude.m4      | 1871 --------------------
 .../readline-6.3/config-dirent-symbols.patch       |   34 +
 meta/recipes-core/readline/readline.inc            |   10 +-
 .../autoconf/autoheader-nonfatal-warnings.patch    |   15 -
 meta/recipes-devtools/autoconf/autoconf_2.69.bb    |    1 -
 5 files changed, 41 insertions(+), 1890 deletions(-)
 delete mode 100644 meta/recipes-core/readline/files/acinclude.m4
 create mode 100644 meta/recipes-core/readline/readline-6.3/config-dirent-symbols.patch
 delete mode 100644 meta/recipes-devtools/autoconf/autoconf/autoheader-nonfatal-warnings.patch