Patchwork [1/1] strace: fix ptest execution failure

login
register
mail settings
Submitter Chong.Lu@windriver.com
Date May 27, 2014, 7:02 a.m.
Message ID <c1e7421f8317b0dfb0988044e511dc95e5265af1.1401174102.git.Chong.Lu@windriver.com>
Download mbox | patch
Permalink /patch/72789/
State New
Headers show

Comments

Chong.Lu@windriver.com - May 27, 2014, 7:02 a.m.
Modify ptest suite to make it execute successfully.

Signed-off-by: Chong Lu <Chong.Lu@windriver.com>
---
 meta/recipes-devtools/strace/strace-4.8/run-ptest | 2 +-
 meta/recipes-devtools/strace/strace_4.8.bb        | 6 ++++++
 2 files changed, 7 insertions(+), 1 deletion(-)
Tudor Florea - May 27, 2014, 3:16 p.m.
> -----Original Message-----
> From: openembedded-core-bounces@lists.openembedded.org
> [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf
> Of Chong Lu
> Sent: Tuesday, May 27, 2014 10:03
> To: openembedded-core@lists.openembedded.org
> Subject: [OE-core] [PATCH 1/1] strace: fix ptest execution failure
> 
> Modify ptest suite to make it execute successfully.
> 
> Signed-off-by: Chong Lu <Chong.Lu@windriver.com>
> ---
>  meta/recipes-devtools/strace/strace-4.8/run-ptest | 2 +-
>  meta/recipes-devtools/strace/strace_4.8.bb        | 6 ++++++
>  2 files changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-devtools/strace/strace-4.8/run-ptest
> b/meta/recipes-devtools/strace/strace-4.8/run-ptest
> index 133cf92..66639fb 100755
> --- a/meta/recipes-devtools/strace/strace-4.8/run-ptest
> +++ b/meta/recipes-devtools/strace/strace-4.8/run-ptest
> @@ -1,2 +1,2 @@
>  #!/bin/sh
> -make -C tests -k runtest-TESTS
> +make -C tests -k check-TESTS
I have the same comment as in the previous patch. I'd rather use serial-tests in configure.ac file instead of this change.

> diff --git a/meta/recipes-devtools/strace/strace_4.8.bb b/meta/recipes-
> devtools/strace/strace_4.8.bb
> index 71563d4..9769cd4 100644
> --- a/meta/recipes-devtools/strace/strace_4.8.bb
> +++ b/meta/recipes-devtools/strace/strace_4.8.bb
> @@ -41,6 +41,12 @@ do_compile_ptest() {
> 
>  do_install_ptest() {
>  	oe_runmake -C ${TESTDIR} install-ptest BUILDDIR=${B}
> DESTDIR=${D}${PTEST_PATH} TESTDIR=${TESTDIR}
> +	install ${S}/test-driver ${D}${PTEST_PATH}
> +	sed -e 's/bash/sh/' \
> +	    -e 's/gawk/awk/' \
> +	    -e 's/^top_srcdir = \(.*\)/top_srcdir = ../' \
> +	    -e '/^all:/a\\t@:' \
> +	    -i ${D}${PTEST_PATH}/${TESTDIR}/Makefile
>  }
> 
>  BBCLASSEXTEND = "native"
> --
> 1.8.1.2
> 
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
Saul Wold - May 27, 2014, 3:23 p.m.
On 05/27/2014 08:16 AM, Tudor Florea wrote:
>
>
>> -----Original Message-----
>> From: openembedded-core-bounces@lists.openembedded.org
>> [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf
>> Of Chong Lu
>> Sent: Tuesday, May 27, 2014 10:03
>> To: openembedded-core@lists.openembedded.org
>> Subject: [OE-core] [PATCH 1/1] strace: fix ptest execution failure
>>
>> Modify ptest suite to make it execute successfully.
>>
>> Signed-off-by: Chong Lu <Chong.Lu@windriver.com>
>> ---
>>   meta/recipes-devtools/strace/strace-4.8/run-ptest | 2 +-
>>   meta/recipes-devtools/strace/strace_4.8.bb        | 6 ++++++
>>   2 files changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-devtools/strace/strace-4.8/run-ptest
>> b/meta/recipes-devtools/strace/strace-4.8/run-ptest
>> index 133cf92..66639fb 100755
>> --- a/meta/recipes-devtools/strace/strace-4.8/run-ptest
>> +++ b/meta/recipes-devtools/strace/strace-4.8/run-ptest
>> @@ -1,2 +1,2 @@
>>   #!/bin/sh
>> -make -C tests -k runtest-TESTS
>> +make -C tests -k check-TESTS
> I have the same comment as in the previous patch. I'd rather use serial-tests in configure.ac file instead of this change.
>
You mentioned a past patch not merged, can you rebase against master and 
resent if it's still appropriate?

Thanks
	Sau!

>> diff --git a/meta/recipes-devtools/strace/strace_4.8.bb b/meta/recipes-
>> devtools/strace/strace_4.8.bb
>> index 71563d4..9769cd4 100644
>> --- a/meta/recipes-devtools/strace/strace_4.8.bb
>> +++ b/meta/recipes-devtools/strace/strace_4.8.bb
>> @@ -41,6 +41,12 @@ do_compile_ptest() {
>>
>>   do_install_ptest() {
>>   	oe_runmake -C ${TESTDIR} install-ptest BUILDDIR=${B}
>> DESTDIR=${D}${PTEST_PATH} TESTDIR=${TESTDIR}
>> +	install ${S}/test-driver ${D}${PTEST_PATH}
>> +	sed -e 's/bash/sh/' \
>> +	    -e 's/gawk/awk/' \
>> +	    -e 's/^top_srcdir = \(.*\)/top_srcdir = ../' \
>> +	    -e '/^all:/a\\t@:' \
>> +	    -i ${D}${PTEST_PATH}/${TESTDIR}/Makefile
>>   }
>>
>>   BBCLASSEXTEND = "native"
>> --
>> 1.8.1.2
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
Chong.Lu@windriver.com - May 28, 2014, 1:25 a.m.
On 05/27/2014 11:16 PM, Tudor Florea wrote:
>
>> -----Original Message-----
>> From: openembedded-core-bounces@lists.openembedded.org
>> [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf
>> Of Chong Lu
>> Sent: Tuesday, May 27, 2014 10:03
>> To: openembedded-core@lists.openembedded.org
>> Subject: [OE-core] [PATCH 1/1] strace: fix ptest execution failure
>>
>> Modify ptest suite to make it execute successfully.
>>
>> Signed-off-by: Chong Lu <Chong.Lu@windriver.com>
>> ---
>>   meta/recipes-devtools/strace/strace-4.8/run-ptest | 2 +-
>>   meta/recipes-devtools/strace/strace_4.8.bb        | 6 ++++++
>>   2 files changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-devtools/strace/strace-4.8/run-ptest
>> b/meta/recipes-devtools/strace/strace-4.8/run-ptest
>> index 133cf92..66639fb 100755
>> --- a/meta/recipes-devtools/strace/strace-4.8/run-ptest
>> +++ b/meta/recipes-devtools/strace/strace-4.8/run-ptest
>> @@ -1,2 +1,2 @@
>>   #!/bin/sh
>> -make -C tests -k runtest-TESTS
>> +make -C tests -k check-TESTS
> I have the same comment as in the previous patch. I'd rather use serial-tests in configure.ac file instead of this change.
Ok. Thanks for your suggestion.

Best Regards
Chong
>
>> diff --git a/meta/recipes-devtools/strace/strace_4.8.bb b/meta/recipes-
>> devtools/strace/strace_4.8.bb
>> index 71563d4..9769cd4 100644
>> --- a/meta/recipes-devtools/strace/strace_4.8.bb
>> +++ b/meta/recipes-devtools/strace/strace_4.8.bb
>> @@ -41,6 +41,12 @@ do_compile_ptest() {
>>
>>   do_install_ptest() {
>>   	oe_runmake -C ${TESTDIR} install-ptest BUILDDIR=${B}
>> DESTDIR=${D}${PTEST_PATH} TESTDIR=${TESTDIR}
>> +	install ${S}/test-driver ${D}${PTEST_PATH}
>> +	sed -e 's/bash/sh/' \
>> +	    -e 's/gawk/awk/' \
>> +	    -e 's/^top_srcdir = \(.*\)/top_srcdir = ../' \
>> +	    -e '/^all:/a\\t@:' \
>> +	    -i ${D}${PTEST_PATH}/${TESTDIR}/Makefile
>>   }
>>
>>   BBCLASSEXTEND = "native"
>> --
>> 1.8.1.2
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
Tudor Florea - May 28, 2014, 2:38 p.m.
> -----Original Message-----
> From: Saul Wold [mailto:sgw@linux.intel.com]
> Sent: Tuesday, May 27, 2014 18:23
> To: Tudor Florea; Chong Lu; openembedded-core@lists.openembedded.org
> Subject: Re: [OE-core] [PATCH 1/1] strace: fix ptest execution failure
> 
> On 05/27/2014 08:16 AM, Tudor Florea wrote:
> >
> >
> >> -----Original Message-----
> >> From: openembedded-core-bounces@lists.openembedded.org
> >> [mailto:openembedded-core-bounces@lists.openembedded.org] On
> Behalf
> >> Of Chong Lu
> >> Sent: Tuesday, May 27, 2014 10:03
> >> To: openembedded-core@lists.openembedded.org
> >> Subject: [OE-core] [PATCH 1/1] strace: fix ptest execution failure
> >>
> >> Modify ptest suite to make it execute successfully.
> >>
> >> Signed-off-by: Chong Lu <Chong.Lu@windriver.com>
> >> ---
> >>   meta/recipes-devtools/strace/strace-4.8/run-ptest | 2 +-
> >>   meta/recipes-devtools/strace/strace_4.8.bb        | 6 ++++++
> >>   2 files changed, 7 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/meta/recipes-devtools/strace/strace-4.8/run-ptest
> >> b/meta/recipes-devtools/strace/strace-4.8/run-ptest
> >> index 133cf92..66639fb 100755
> >> --- a/meta/recipes-devtools/strace/strace-4.8/run-ptest
> >> +++ b/meta/recipes-devtools/strace/strace-4.8/run-ptest
> >> @@ -1,2 +1,2 @@
> >>   #!/bin/sh
> >> -make -C tests -k runtest-TESTS
> >> +make -C tests -k check-TESTS
> > I have the same comment as in the previous patch. I'd rather use serial-
> tests in configure.ac file instead of this change.
> >
> You mentioned a past patch not merged, can you rebase against master and
> resent if it's still appropriate?
> 
> Thanks
> 	Sau!
> 
I'll review and resend the patch I a couple of days.
Regards,
Tudor.
> >> diff --git a/meta/recipes-devtools/strace/strace_4.8.bb b/meta/recipes-
> >> devtools/strace/strace_4.8.bb
> >> index 71563d4..9769cd4 100644
> >> --- a/meta/recipes-devtools/strace/strace_4.8.bb
> >> +++ b/meta/recipes-devtools/strace/strace_4.8.bb
> >> @@ -41,6 +41,12 @@ do_compile_ptest() {
> >>
> >>   do_install_ptest() {
> >>   	oe_runmake -C ${TESTDIR} install-ptest BUILDDIR=${B}
> >> DESTDIR=${D}${PTEST_PATH} TESTDIR=${TESTDIR}
> >> +	install ${S}/test-driver ${D}${PTEST_PATH}
> >> +	sed -e 's/bash/sh/' \
> >> +	    -e 's/gawk/awk/' \
> >> +	    -e 's/^top_srcdir = \(.*\)/top_srcdir = ../' \
> >> +	    -e '/^all:/a\\t@:' \
> >> +	    -i ${D}${PTEST_PATH}/${TESTDIR}/Makefile
> >>   }
> >>
> >>   BBCLASSEXTEND = "native"
> >> --
> >> 1.8.1.2
> >>
> >> --
> >> _______________________________________________
> >> Openembedded-core mailing list
> >> Openembedded-core@lists.openembedded.org
> >> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Patch

diff --git a/meta/recipes-devtools/strace/strace-4.8/run-ptest b/meta/recipes-devtools/strace/strace-4.8/run-ptest
index 133cf92..66639fb 100755
--- a/meta/recipes-devtools/strace/strace-4.8/run-ptest
+++ b/meta/recipes-devtools/strace/strace-4.8/run-ptest
@@ -1,2 +1,2 @@ 
 #!/bin/sh
-make -C tests -k runtest-TESTS
+make -C tests -k check-TESTS
diff --git a/meta/recipes-devtools/strace/strace_4.8.bb b/meta/recipes-devtools/strace/strace_4.8.bb
index 71563d4..9769cd4 100644
--- a/meta/recipes-devtools/strace/strace_4.8.bb
+++ b/meta/recipes-devtools/strace/strace_4.8.bb
@@ -41,6 +41,12 @@  do_compile_ptest() {
 
 do_install_ptest() {
 	oe_runmake -C ${TESTDIR} install-ptest BUILDDIR=${B} DESTDIR=${D}${PTEST_PATH} TESTDIR=${TESTDIR}
+	install ${S}/test-driver ${D}${PTEST_PATH}
+	sed -e 's/bash/sh/' \
+	    -e 's/gawk/awk/' \
+	    -e 's/^top_srcdir = \(.*\)/top_srcdir = ../' \
+	    -e '/^all:/a\\t@:' \
+	    -i ${D}${PTEST_PATH}/${TESTDIR}/Makefile
 }
 
 BBCLASSEXTEND = "native"