Patchwork [meta-xfce] xfce4-screenshooter: Ensure lib directory exists.

login
register
mail settings
Submitter Ash Charles
Date May 26, 2014, 5:43 p.m.
Message ID <1401126195-17846-1-git-send-email-ashcharles@gmail.com>
Download mbox | patch
Permalink /patch/72729/
State Accepted, archived
Headers show

Comments

Ash Charles - May 26, 2014, 5:43 p.m.
Screenshooter autogenerates screenshooter-marshal.[ch] in lib/ during
compilation.  The source directory contains a lib/ but this directory
doesn't exist in a build directory by default so we add one manually.
Really, this should be corrected in the upstream package.

Upstream-Status: pending

Signed-off-by: Ash Charles <ashcharles@gmail.com>
---
 .../recipes-apps/xfce4-screenshooter/xfce4-screenshooter_1.8.1.bb     | 4 ++++
 1 file changed, 4 insertions(+)
Martin Jansa - June 10, 2014, 11:21 a.m.
On Mon, May 26, 2014 at 10:43:15AM -0700, Ash Charles wrote:
> Screenshooter autogenerates screenshooter-marshal.[ch] in lib/ during
> compilation.  The source directory contains a lib/ but this directory
> doesn't exist in a build directory by default so we add one manually.
> Really, this should be corrected in the upstream package.
> 
> Upstream-Status: pending

Please create it only when it doesn't exist

ERROR: Logfile of failure stored in: /home/jenkins/oe/shr-core-branches/shr-core/tmp-eglibc/work/core2-64-oe-linux/xfce4-screenshooter/1.8.1-r0/temp/log.do_compile.3584
Log data follows:
| DEBUG: SITE files ['endian-little', 'common-linux', 'common-glibc', 'bit-64', 'x86_64-linux', 'common']
| DEBUG: Executing shell function do_compile
| mkdir: cannot create directory `lib': File exists
| WARNING: exit code 1 from a shell command.
| ERROR: Function failed: do_compile (log file is located at /home/jenkins/oe/shr-core-branches/shr-core/tmp-eglibc/work/core2-64-oe-linux/xfce4-screenshooter/1.8.1-r0/temp/log.do_compile.3584)
NOTE: recipe xfce4-screenshooter-1.8.1-r0: task do_compile: Failed


> 
> Signed-off-by: Ash Charles <ashcharles@gmail.com>
> ---
>  .../recipes-apps/xfce4-screenshooter/xfce4-screenshooter_1.8.1.bb     | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/meta-xfce/recipes-apps/xfce4-screenshooter/xfce4-screenshooter_1.8.1.bb b/meta-xfce/recipes-apps/xfce4-screenshooter/xfce4-screenshooter_1.8.1.bb
> index 4cda352..271f9c0 100644
> --- a/meta-xfce/recipes-apps/xfce4-screenshooter/xfce4-screenshooter_1.8.1.bb
> +++ b/meta-xfce/recipes-apps/xfce4-screenshooter/xfce4-screenshooter_1.8.1.bb
> @@ -11,5 +11,9 @@ SRC_URI += "file://0001-Fix-panel-plugin-build.patch"
>  SRC_URI[md5sum] = "d0ffea2052a8e70154cf13789070711f"
>  SRC_URI[sha256sum] = "40419892bd28989315eed053c159bba0f4264ed8c6c6738806024e481eab9492"
>  
> +do_compile_prepend() {
> +	mkdir lib
> +}
> +
>  FILES_${PN} += "${datadir}/xfce4/panel/plugins \
>          ${libdir}/xfce4/panel/plugins"
> -- 
> 1.8.3.2
> 
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Patch

diff --git a/meta-xfce/recipes-apps/xfce4-screenshooter/xfce4-screenshooter_1.8.1.bb b/meta-xfce/recipes-apps/xfce4-screenshooter/xfce4-screenshooter_1.8.1.bb
index 4cda352..271f9c0 100644
--- a/meta-xfce/recipes-apps/xfce4-screenshooter/xfce4-screenshooter_1.8.1.bb
+++ b/meta-xfce/recipes-apps/xfce4-screenshooter/xfce4-screenshooter_1.8.1.bb
@@ -11,5 +11,9 @@  SRC_URI += "file://0001-Fix-panel-plugin-build.patch"
 SRC_URI[md5sum] = "d0ffea2052a8e70154cf13789070711f"
 SRC_URI[sha256sum] = "40419892bd28989315eed053c159bba0f4264ed8c6c6738806024e481eab9492"
 
+do_compile_prepend() {
+	mkdir lib
+}
+
 FILES_${PN} += "${datadir}/xfce4/panel/plugins \
         ${libdir}/xfce4/panel/plugins"