Patchwork [meta-fsl-arm] linux-imx: enable CONFIG_FHANDLE

login
register
mail settings
Submitter Maciej Borzecki
Date May 23, 2014, 8:54 a.m.
Message ID <1400835262-5893-1-git-send-email-maciej.borzecki@open-rnd.pl>
Download mbox | patch
Permalink /patch/72627/
State Accepted
Delegated to: Otavio Salvador
Headers show

Comments

Maciej Borzecki - May 23, 2014, 8:54 a.m.
Enable CONFIG_FHANDLE so that systemd can autostart
getty on serial interfaces like /dev/ttymxc*

Signed-off-by: Maciej Borzecki <maciej.borzecki@open-rnd.pl>
Signed-off-by: Maciej Borzecki <maciek.borzecki@gmail.com>
---
 recipes-kernel/linux/linux-imx-3.10.17/mx6/defconfig | 1 +
 1 file changed, 1 insertion(+)
Daiane Angolini - May 23, 2014, noon
> Enable CONFIG_FHANDLE so that systemd can autostart
> getty on serial interfaces like /dev/ttymxc*

How many imx6 boards/chips did you tested it?

Daiane
Fabio Estevam - May 23, 2014, 12:24 p.m.
On Fri, May 23, 2014 at 9:00 AM, Daiane Angolini <daiane.list@gmail.com> wrote:
>> Enable CONFIG_FHANDLE so that systemd can autostart
>> getty on serial interfaces like /dev/ttymxc*
>
> How many imx6 boards/chips did you tested it?

It seems that CONFIG_FHANDLE is needed when systemd version >= 210 is used.

Thiis is not mx6 specific.
Maciej Borzecki - May 23, 2014, 12:32 p.m.
On 05/23 09:00, Daiane Angolini wrote:
> > Enable CONFIG_FHANDLE so that systemd can autostart
> > getty on serial interfaces like /dev/ttymxc*
>
> How many imx6 boards/chips did you tested it?
I've tried mx6q and mx6dl. Both on custom as well as GENIVI builds
(gemini-image to be exact).

--
Maciej Borz?cki
Senior Software Developer at Open-RnD Sp. z o.o., Poland
www.open-rnd.pl
mobile: +48 889 117 365, fax: +48 42 657 9079


Niniejsza wiadomo?? wraz z za??cznikami mo?e
zawiera? chronione prawem lub poufne informacje i zosta?a
wys?ana wy??cznie do wiadomo?ci i u?ytku osób, do których
zosta?a zaadresowana. Je?li wiadomo?? zosta?a otrzymana
przypadkowo zabrania si? jej kopiowania lub rozsy?ania do osób
trzecich. W takim przypadku uprasza si? o natychmiastowe
zniszczenie wiadomo?ci oraz poinformowanie nadawcy o
zaistnia?ej sytuacji za pomoc? wiadomo?ci zwrotnej.
Dzi?kujemy.

This message, including any attachments hereto,
may contain privileged or confidential information and is sent
solely for the attention and use of the intended addressee(s).
If you are not an intended addressee, you may neither use this
message nor copy or deliver it to anyone. In such case, you
should immediately destroy this message and kindly notify the
sender by reply email. Thank you.
Maciej Borzecki - May 23, 2014, 12:48 p.m.
On 05/23 09:24, Fabio Estevam wrote:
> On Fri, May 23, 2014 at 9:00 AM, Daiane Angolini <daiane.list@gmail.com> wrote:
> >> Enable CONFIG_FHANDLE so that systemd can autostart
> >> getty on serial interfaces like /dev/ttymxc*
> >
> > How many imx6 boards/chips did you tested it?
>
> It seems that CONFIG_FHANDLE is needed when systemd version >= 210 is used.
>
> Thiis is not mx6 specific.
It is not, you're right. However, if it's not enabled than using the
system with systemd is a major PITA as getty will be started. No serial,
not access, provided you're using a headless setup.

Also, linux-wandboard and linux-congatec from meta-fsl-arm-extra already
have this enabled in respective defconfigs. Default linux-yocto (at
least 3.14) seemed to work on BeagleBone as well without any changes.

--
Maciej Borz?cki
Senior Software Developer at Open-RnD Sp. z o.o., Poland
www.open-rnd.pl
mobile: +48 889 117 365, fax: +48 42 657 9079


Niniejsza wiadomo?? wraz z za??cznikami mo?e
zawiera? chronione prawem lub poufne informacje i zosta?a
wys?ana wy??cznie do wiadomo?ci i u?ytku osób, do których
zosta?a zaadresowana. Je?li wiadomo?? zosta?a otrzymana
przypadkowo zabrania si? jej kopiowania lub rozsy?ania do osób
trzecich. W takim przypadku uprasza si? o natychmiastowe
zniszczenie wiadomo?ci oraz poinformowanie nadawcy o
zaistnia?ej sytuacji za pomoc? wiadomo?ci zwrotnej.
Dzi?kujemy.

This message, including any attachments hereto,
may contain privileged or confidential information and is sent
solely for the attention and use of the intended addressee(s).
If you are not an intended addressee, you may neither use this
message nor copy or deliver it to anyone. In such case, you
should immediately destroy this message and kindly notify the
sender by reply email. Thank you.
Daiane Angolini - May 23, 2014, 1:11 p.m.
>> Thiis is not mx6 specific.
> It is not, you're right. However, if it's not enabled than using the
> system with systemd is a major PITA as getty will be started. No serial,
> not access, provided you're using a headless setup.

I understand it´s not related with mx6. But this kind of change makes
our kernel to diverge from "the released kernel from freescale"

And I´m not sure I want this.

>
> Also, linux-wandboard and linux-congatec from meta-fsl-arm-extra already
> have this enabled in respective defconfigs. Default linux-yocto (at
> least 3.14) seemed to work on BeagleBone as well without any changes.

Yes, they have few boards and I´m sure they tested their boards.
For linux-imx we have several boards and we have users depending on
that kernel for their boards.

That´s the reason I asked for test scope :D

Daiane
Fabio Estevam - May 23, 2014, 1:15 p.m.
On Fri, May 23, 2014 at 10:11 AM, Daiane Angolini <daiane.list@gmail.com> wrote:
>>> Thiis is not mx6 specific.
>> It is not, you're right. However, if it's not enabled than using the
>> system with systemd is a major PITA as getty will be started. No serial,
>> not access, provided you're using a headless setup.
>
> I understand it´s not related with mx6. But this kind of change makes
> our kernel to diverge from "the released kernel from freescale"
>
> And I´m not sure I want this.

If you want a serial console working in Yocto then you want this
option selected :-)

Proabably the issue was not seen with the released kernel from FSL
because it hasn't been used against systemd version >=210.

Maciej's patch is the correct fix.
Jacob Kroon - May 23, 2014, 1:18 p.m.
On Fri, May 23, 2014 at 3:15 PM, Fabio Estevam <festevam@gmail.com> wrote:

> On Fri, May 23, 2014 at 10:11 AM, Daiane Angolini <daiane.list@gmail.com>
> wrote:
> >>> Thiis is not mx6 specific.
> >> It is not, you're right. However, if it's not enabled than using the
> >> system with systemd is a major PITA as getty will be started. No serial,
> >> not access, provided you're using a headless setup.
> >
> > I understand it´s not related with mx6. But this kind of change makes
> > our kernel to diverge from "the released kernel from freescale"
> >
> > And I´m not sure I want this.
>
> If you want a serial console working in Yocto then you want this
> option selected :-)
>
> Proabably the issue was not seen with the released kernel from FSL
> because it hasn't been used against systemd version >=210.
>
> Maciej's patch is the correct fix.
>

FWIW, +1 on getting Maciej's fix applied
Daiane Angolini - May 23, 2014, 1:26 p.m.
>> >>> Thiis is not mx6 specific.
>> >> It is not, you're right. However, if it's not enabled than using the
>> >> system with systemd is a major PITA as getty will be started. No
>> >> serial,
>> >> not access, provided you're using a headless setup.
>> >
>> > I understand it´s not related with mx6. But this kind of change makes
>> > our kernel to diverge from "the released kernel from freescale"
>> >
>> > And I´m not sure I want this.
>>
>> If you want a serial console working in Yocto then you want this
>> option selected :-)
>>
>> Proabably the issue was not seen with the released kernel from FSL
>> because it hasn't been used against systemd version >=210.
>>
>> Maciej's patch is the correct fix.
>
>
> FWIW, +1 on getting Maciej's fix applied

OK =D


(only to be completely clear, I was not *against* the patch. I only
asked how it was tested)


Daiane
Gary Thomas - May 23, 2014, 2:27 p.m.
On 2014-05-23 07:26, Daiane Angolini wrote:
>>>>>> Thiis is not mx6 specific.
>>>>> It is not, you're right. However, if it's not enabled than using the
>>>>> system with systemd is a major PITA as getty will be started. No
>>>>> serial,
>>>>> not access, provided you're using a headless setup.
>>>>
>>>> I understand it´s not related with mx6. But this kind of change makes
>>>> our kernel to diverge from "the released kernel from freescale"
>>>>
>>>> And I´m not sure I want this.
>>>
>>> If you want a serial console working in Yocto then you want this
>>> option selected :-)
>>>
>>> Proabably the issue was not seen with the released kernel from FSL
>>> because it hasn't been used against systemd version >=210.
>>>
>>> Maciej's patch is the correct fix.
>>
>>
>> FWIW, +1 on getting Maciej's fix applied
>
> OK =D
>
>
> (only to be completely clear, I was not *against* the patch. I only
> asked how it was tested)

+1 as well - I just tested it on SabreLite and it fixed a problem I was
seeing with no serial ports on login when using systemd.
Otavio Salvador - May 23, 2014, 3:19 p.m.
On Fri, May 23, 2014 at 10:11 AM, Daiane Angolini <daiane.list@gmail.com> wrote:
>>> Thiis is not mx6 specific.
>> It is not, you're right. However, if it's not enabled than using the
>> system with systemd is a major PITA as getty will be started. No serial,
>> not access, provided you're using a headless setup.
>
> I understand it´s not related with mx6. But this kind of change makes
> our kernel to diverge from "the released kernel from freescale"
>
> And I´m not sure I want this.

We don't have many options here. We need to apply it and prepare a
patch for the linux-imx to be send internally for review, I think.

>> Also, linux-wandboard and linux-congatec from meta-fsl-arm-extra already
>> have this enabled in respective defconfigs. Default linux-yocto (at
>> least 3.14) seemed to work on BeagleBone as well without any changes.
>
> Yes, they have few boards and I´m sure they tested their boards.
> For linux-imx we have several boards and we have users depending on
> that kernel for their boards.
>
> That´s the reason I asked for test scope :D

Indeed. We'll need to run some tests, for sure. :-(
Maciek Borzecki - May 23, 2014, 5 p.m.
On Fri, May 23, 2014 at 5:19 PM, Otavio Salvador
<otavio@ossystems.com.br> wrote:
> On Fri, May 23, 2014 at 10:11 AM, Daiane Angolini <daiane.list@gmail.com> wrote:
>>>> Thiis is not mx6 specific.
>>> It is not, you're right. However, if it's not enabled than using the
>>> system with systemd is a major PITA as getty will be started. No serial,
>>> not access, provided you're using a headless setup.
>>
>> I understand it´s not related with mx6. But this kind of change makes
>> our kernel to diverge from "the released kernel from freescale"
>>
>> And I´m not sure I want this.
>
> We don't have many options here. We need to apply it and prepare a
> patch for the linux-imx to be send internally for review, I think.
>
>>> Also, linux-wandboard and linux-congatec from meta-fsl-arm-extra already
>>> have this enabled in respective defconfigs. Default linux-yocto (at
>>> least 3.14) seemed to work on BeagleBone as well without any changes.
>>
>> Yes, they have few boards and I´m sure they tested their boards.
>> For linux-imx we have several boards and we have users depending on
>> that kernel for their boards.
>>
>> That´s the reason I asked for test scope :D
>
> Indeed. We'll need to run some tests, for sure. :-(

FWIW I have not seen any other problems systemd 212 so far.

Patch

diff --git a/recipes-kernel/linux/linux-imx-3.10.17/mx6/defconfig b/recipes-kernel/linux/linux-imx-3.10.17/mx6/defconfig
index b8d6ceb..fa2eada 100644
--- a/recipes-kernel/linux/linux-imx-3.10.17/mx6/defconfig
+++ b/recipes-kernel/linux/linux-imx-3.10.17/mx6/defconfig
@@ -355,3 +355,4 @@  CONFIG_CRC_CCITT=m
 CONFIG_CRC_T10DIF=y
 CONFIG_CRC7=m
 CONFIG_LIBCRC32C=m
+CONFIG_FHANDLE=y