Patchwork [0/2,PULL] alsa-tools: Fix recipe build error

login
register
mail settings
Submitter Dongxiao Xu
Date July 8, 2011, 2:11 a.m.
Message ID <cover.1310090994.git.dongxiao.xu@intel.com>
Download mbox
Permalink /patch/7223/
State New, archived
Headers show

Pull-request

git://git.pokylinux.org/poky-contrib dxu4/alsa-tools

Comments

Dongxiao Xu - July 8, 2011, 2:11 a.m.
Hi Saul,

This pull request fixes the alsa-tools recipe build error.
Please help to review and pull.

[YOCTO #1038]

Thanks,
Dongxiao

The following changes since commit 2c79c9eb7ef8ef0aef8c3096c3c4387e28e56ea2:

  pulseaudio: add 0.9.23 (2011-07-07 13:45:32 +0100)

are available in the git repository at:
  git://git.pokylinux.org/poky-contrib dxu4/alsa-tools
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=dxu4/alsa-tools

Dongxiao Xu (2):
  fltk: add this recipe for alsa-tools build
  alsa-tools: Fix recipe build error.

 .../alsa/alsa-tools-1.0.24.1/autotools.patch       |   31 ++++++++++++++++
 .../recipes-multimedia/alsa/alsa-tools_1.0.24.1.bb |   16 +++++++--
 .../fltk/fltk-1.1.10/disable_test.patch            |   18 +++++++++
 meta/recipes-multimedia/fltk/fltk_1.1.10.bb        |   38 ++++++++++++++++++++
 4 files changed, 100 insertions(+), 3 deletions(-)
 create mode 100644 meta/recipes-multimedia/alsa/alsa-tools-1.0.24.1/autotools.patch
 create mode 100644 meta/recipes-multimedia/fltk/fltk-1.1.10/disable_test.patch
 create mode 100644 meta/recipes-multimedia/fltk/fltk_1.1.10.bb
Richard Purdie - July 8, 2011, 3:45 p.m.
On Fri, 2011-07-08 at 10:11 +0800, Dongxiao Xu wrote:
> Hi Saul,
> 
> This pull request fixes the alsa-tools recipe build error.
> Please help to review and pull.
> 
> [YOCTO #1038]
> 
> Thanks,
> Dongxiao
> 
> The following changes since commit 2c79c9eb7ef8ef0aef8c3096c3c4387e28e56ea2:
> 
>   pulseaudio: add 0.9.23 (2011-07-07 13:45:32 +0100)
> 
> are available in the git repository at:
>   git://git.pokylinux.org/poky-contrib dxu4/alsa-tools
>   http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=dxu4/alsa-tools
> 
> Dongxiao Xu (2):
>   fltk: add this recipe for alsa-tools build
>   alsa-tools: Fix recipe build error.

I'd like to understand whether we need gtk and fltk tools from
alsa-tools at this point in time?

Could we just disable those?

Cheers,

Richard
Dongxiao Xu - July 12, 2011, 5:24 a.m.
Hi Richard,

> -----Original Message-----
> From: openembedded-core-bounces@lists.openembedded.org
> [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of
> Richard Purdie
> Sent: Friday, July 08, 2011 11:45 PM
> To: Patches and discussions about the oe-core layer
> Subject: Re: [OE-core] [PATCH 0/2][PULL] alsa-tools: Fix recipe build error
> 
> On Fri, 2011-07-08 at 10:11 +0800, Dongxiao Xu wrote:
> > Hi Saul,
> >
> > This pull request fixes the alsa-tools recipe build error.
> > Please help to review and pull.
> >
> > [YOCTO #1038]
> >
> > Thanks,
> > Dongxiao
> >
> > The following changes since commit
> 2c79c9eb7ef8ef0aef8c3096c3c4387e28e56ea2:
> >
> >   pulseaudio: add 0.9.23 (2011-07-07 13:45:32 +0100)
> >
> > are available in the git repository at:
> >   git://git.pokylinux.org/poky-contrib dxu4/alsa-tools
> >
> > http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=dxu4/alsa-tools
> >
> > Dongxiao Xu (2):
> >   fltk: add this recipe for alsa-tools build
> >   alsa-tools: Fix recipe build error.
> 
> I'd like to understand whether we need gtk and fltk tools from alsa-tools at this
> point in time?
> 
> Could we just disable those?

I added those dependencies in since alsa-tools is not in our reference images (sato, sato-sdk, etc.), and it may not impact our daily builds.

Actually alsa-tools is a set of subprojects, we can disable certain sub-projects in alsa-tools to avoid including gtk and fltk.

Thanks,
Dongxiao

> 
> Cheers,
> 
> Richard
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Saul Wold - July 12, 2011, 6:57 a.m.
On 07/11/2011 10:24 PM, Xu, Dongxiao wrote:
> Hi Richard,
>
>> -----Original Message-----
>> From: openembedded-core-bounces@lists.openembedded.org
>> [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of
>> Richard Purdie
>> Sent: Friday, July 08, 2011 11:45 PM
>> To: Patches and discussions about the oe-core layer
>> Subject: Re: [OE-core] [PATCH 0/2][PULL] alsa-tools: Fix recipe build error
>>
>> On Fri, 2011-07-08 at 10:11 +0800, Dongxiao Xu wrote:
>>> Hi Saul,
>>>
>>> This pull request fixes the alsa-tools recipe build error.
>>> Please help to review and pull.
>>>
>>> [YOCTO #1038]
>>>
>>> Thanks,
>>> Dongxiao
>>>
>>> The following changes since commit
>> 2c79c9eb7ef8ef0aef8c3096c3c4387e28e56ea2:
>>>
>>>    pulseaudio: add 0.9.23 (2011-07-07 13:45:32 +0100)
>>>
>>> are available in the git repository at:
>>>    git://git.pokylinux.org/poky-contrib dxu4/alsa-tools
>>>
>>> http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=dxu4/alsa-tools
>>>
>>> Dongxiao Xu (2):
>>>    fltk: add this recipe for alsa-tools build
>>>    alsa-tools: Fix recipe build error.
>>
>> I'd like to understand whether we need gtk and fltk tools from alsa-tools at this
>> point in time?
>>
>> Could we just disable those?
>
> I added those dependencies in since alsa-tools is not in our reference images (sato, sato-sdk, etc.), and it may not impact our daily builds.
>
> Actually alsa-tools is a set of subprojects, we can disable certain sub-projects in alsa-tools to avoid including gtk and fltk.
>
Which subprojects would you need to disable, there are others that use 
alsa-tools which is why it's in core.

Sau!

> Thanks,
> Dongxiao
>
>>
>> Cheers,
>>
>> Richard
>>
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>