Patchwork [8/8] libx11: enable xcb support

login
register
mail settings
Submitter Saul Wold
Date July 7, 2011, 11:31 p.m.
Message ID <0a996270e51deae8b1f22299e1e024dcb6c0be88.1310081443.git.sgw@linux.intel.com>
Download mbox | patch
Permalink /patch/7213/
State New, archived
Headers show

Comments

Saul Wold - July 7, 2011, 11:31 p.m.
[YOCTO #1196]

Signed-off-by: Saul Wold <sgw@linux.intel.com>
---
 meta/recipes-graphics/xorg-lib/libx11_1.3.4.bb |   11 ++++++++---
 1 files changed, 8 insertions(+), 3 deletions(-)
Phil Blundell - July 8, 2011, 1:57 p.m.
On Thu, 2011-07-07 at 16:31 -0700, Saul Wold wrote:
> [YOCTO #1196]
> 
> Signed-off-by: Saul Wold <sgw@linux.intel.com>

We seem to be seeing quite a lot of patches recently whose long-form
comment consists of a Yocto bug number, S-O-B line and nothing else.
That might be fine for the most notorious bugs, where even non-Yocto
people would immediately recognise the number, but in general it's a bit
tedious to keep having to go to the Yocto bugzilla to find out what the
patch is trying to do.  Would it be possible to get a slightly more
descriptive commit message for future changes?

See also the fine guidelines from our helpful TSC:

http://wiki.openembedded.org/index.php/Commit_Patch_Message_Guidelines

thanks

p.
Martin Jansa - July 18, 2011, 10:55 p.m.
On Thu, Jul 07, 2011 at 04:31:40PM -0700, Saul Wold wrote:
> [YOCTO #1196]
> 
> Signed-off-by: Saul Wold <sgw@linux.intel.com>
> ---
>  meta/recipes-graphics/xorg-lib/libx11_1.3.4.bb |   11 ++++++++---
>  1 files changed, 8 insertions(+), 3 deletions(-)
> 
> diff --git a/meta/recipes-graphics/xorg-lib/libx11_1.3.4.bb b/meta/recipes-graphics/xorg-lib/libx11_1.3.4.bb
> index 3e046a1..04d4a97 100644
> --- a/meta/recipes-graphics/xorg-lib/libx11_1.3.4.bb
> +++ b/meta/recipes-graphics/xorg-lib/libx11_1.3.4.bb
> @@ -5,7 +5,7 @@ LICENSE = "MIT & MIT-style & BSD"
>  LIC_FILES_CHKSUM = "file://COPYING;md5=bf75bfe4d05068311b5e6862d4b5f2c5"
>  
>  PE = "1"
> -PR = "r1"
> +PR = "r3"
>  
>  SRC_URI += "file://x11_disable_makekeys.patch \
>              file://nodolt.patch \
> @@ -16,8 +16,13 @@ SRC_URI[md5sum] = "f65c9c7ecbfb64c19dbd7927160d63fd"
>  SRC_URI[sha256sum] = "88d7238ce5f7cd123450567de7a3b56a43556e4ccc45df38b8324147c889a844"
>  
>  DEPENDS += "bigreqsproto xproto xextproto xtrans libxau xcmiscproto \
> -            libxdmcp xf86bigfontproto kbproto inputproto xproto-native"
> +            libxdmcp xf86bigfontproto kbproto inputproto xproto-native libxcb"
>  
> -EXTRA_OECONF += "--without-xcb"
> +DEPENDS_virtclass-native += "bigreqsproto-native xproto-native xextproto-native xtrans-native libxau-native xcmiscproto-native \
> +            libxdmcp-native xf86bigfontproto-native kbproto-native inputproto-native xproto-native"
> +
> +XCB = "--with-xcb"
> +XCB_virtclass-native = "--without-xcb"
> +EXTRA_OECONF += "${XCB}"
>  
>  BBCLASSEXTEND = "native nativesdk"

FWIW:

few months back I've replied on similar change that --without-xcb is not
available in newer libx11 and that it would be better to upgrade to
newer libx11 or keep xcb enabled for -native too and add 2
BBCLASSEXTENDS to needed xcb recipes..

Patch

diff --git a/meta/recipes-graphics/xorg-lib/libx11_1.3.4.bb b/meta/recipes-graphics/xorg-lib/libx11_1.3.4.bb
index 3e046a1..04d4a97 100644
--- a/meta/recipes-graphics/xorg-lib/libx11_1.3.4.bb
+++ b/meta/recipes-graphics/xorg-lib/libx11_1.3.4.bb
@@ -5,7 +5,7 @@  LICENSE = "MIT & MIT-style & BSD"
 LIC_FILES_CHKSUM = "file://COPYING;md5=bf75bfe4d05068311b5e6862d4b5f2c5"
 
 PE = "1"
-PR = "r1"
+PR = "r3"
 
 SRC_URI += "file://x11_disable_makekeys.patch \
             file://nodolt.patch \
@@ -16,8 +16,13 @@  SRC_URI[md5sum] = "f65c9c7ecbfb64c19dbd7927160d63fd"
 SRC_URI[sha256sum] = "88d7238ce5f7cd123450567de7a3b56a43556e4ccc45df38b8324147c889a844"
 
 DEPENDS += "bigreqsproto xproto xextproto xtrans libxau xcmiscproto \
-            libxdmcp xf86bigfontproto kbproto inputproto xproto-native"
+            libxdmcp xf86bigfontproto kbproto inputproto xproto-native libxcb"
 
-EXTRA_OECONF += "--without-xcb"
+DEPENDS_virtclass-native += "bigreqsproto-native xproto-native xextproto-native xtrans-native libxau-native xcmiscproto-native \
+            libxdmcp-native xf86bigfontproto-native kbproto-native inputproto-native xproto-native"
+
+XCB = "--with-xcb"
+XCB_virtclass-native = "--without-xcb"
+EXTRA_OECONF += "${XCB}"
 
 BBCLASSEXTEND = "native nativesdk"