Patchwork [v3] beagleboard-test-scripts: Add a script flash-fs.sh for flashing NAND

login
register
mail settings
Submitter Joel A Fernandes
Date July 7, 2011, 9:23 p.m.
Message ID <1310073836-11556-1-git-send-email-agnel.joel@gmail.com>
Download mbox | patch
Permalink /patch/7189/
State New, archived
Headers show

Comments

Joel A Fernandes - July 7, 2011, 9:23 p.m.
This script flashes the NAND of a BeagleBoard if:
  * The user-button is pressed
  * There is a valid image on the SD Card to flash
  * The board has NAND

Signed-off-by: Joel A Fernandes <agnel.joel@gmail.com>
---
Changes since v2:
  User button is checked before flashing of the board

This is based on Jason's review:
http://groups.google.com/group/beagleboard/msg/835de9a37c3a340a

 .../beagleboard/beagleboard-test-scripts_git.bb    |   14 +++++++++++---
 1 files changed, 11 insertions(+), 3 deletions(-)
Jason Kridner - July 8, 2011, 12:32 a.m.
On Thu, Jul 7, 2011 at 5:23 PM, Joel A Fernandes <agnel.joel@gmail.com> wrote:
> This script flashes the NAND of a BeagleBoard if:
>  * The user-button is pressed
>  * There is a valid image on the SD Card to flash
>  * The board has NAND
>
> Signed-off-by: Joel A Fernandes <agnel.joel@gmail.com>

Acked-by: Jason Kridner <jkridner@beagleboard.org>

> ---
> Changes since v2:
>  User button is checked before flashing of the board
>
> This is based on Jason's review:
> http://groups.google.com/group/beagleboard/msg/835de9a37c3a340a
>
>  .../beagleboard/beagleboard-test-scripts_git.bb    |   14 +++++++++++---
>  1 files changed, 11 insertions(+), 3 deletions(-)
>
> diff --git a/recipes/beagleboard/beagleboard-test-scripts_git.bb b/recipes/beagleboard/beagleboard-test-scripts_git.bb
> index be0d059..3f3cc56 100644
> --- a/recipes/beagleboard/beagleboard-test-scripts_git.bb
> +++ b/recipes/beagleboard/beagleboard-test-scripts_git.bb
> @@ -1,14 +1,18 @@
>  ## Reminder:  The correct spacing for a variable is FOO = "BAR"  in : PR="r1"
>  DESCRIPTION = "BeagleBoard test scripts"
>  HOMEPAGE = "http://beagleboad.org/support"
> -PR = "r2"
> +PR = "r3"
>
> -SRC_URI = "git://gitorious.org/beagleboard-validation/scripts.git;protocol=git \
> +SRC_URI = "git://gitorious.org/~joelf/beagleboard-validation/validation-scripts.git;protocol=git \
>  "
>
> -SRCREV = "473dd2ab20d866be6168c9f992c2c9e74e485c9d"
> +SRCREV = "513bfa2e99822150ea5845f3a33c349029cb7c13"

Thanks!

>  S = "${WORKDIR}/git"
>
> +inherit update-rc.d
> +INITSCRIPT_NAME = "flash-fs.sh"
> +INITSCRIPT_PARAMS = "start 99 2 3 4 5 ."
> +
>  do_install() {
>   TEST_FILES=" \
>     testaudio \
> @@ -28,4 +32,8 @@ do_install() {
>   for i in ${TEST_FILES}; do
>     install -m 0755 ${S}/${i} ${D}/${bindir}
>   done
> +  # A script to flash NAND if the board has it, and if there is valid image to flash on the SD Card.
> +  # We also register it as an init script so that the SD Card auto-flashes to NAND during boot.
> +  install -d ${D}/${sysconfdir}/init.d/
> +  install -m 0755 ${S}/flashing/flash-fs.sh ${D}/${sysconfdir}/init.d/flash-fs.sh
>  }
> --
> 1.7.0.4
Khem Raj - July 8, 2011, 12:47 a.m.
On Jul 7, 2011, at 5:32 PM, Jason Kridner <jkridner@beagleboard.org> wrote:

> On Thu, Jul 7, 2011 at 5:23 PM, Joel A Fernandes <agnel.joel@gmail.com> wrote:
>> This script flashes the NAND of a BeagleBoard if:
>>  * The user-button is pressed
>>  * There is a valid image on the SD Card to flash
>>  * The board has NAND
>> 
>> Signed-off-by: Joel A Fernandes <agnel.joel@gmail.com>
> 
> Acked-by: Jason Kridner <jkridner@beagleboard.org>
> 
>> ---
>> Changes since v2:
>>  User button is checked before flashing of the board
>> 
>> This is based on Jason's review:
>> http://groups.google.com/group/beagleboard/msg/835de9a37c3a340a
>> 
>>  .../beagleboard/beagleboard-test-scripts_git.bb    |   14 +++++++++++---
>>  1 files changed, 11 insertions(+), 3 deletions(-)
>> 
>> diff --git a/recipes/beagleboard/beagleboard-test-scripts_git.bb b/recipes/beagleboard/beagleboard-test-scripts_git.bb
>> index be0d059..3f3cc56 100644
>> --- a/recipes/beagleboard/beagleboard-test-scripts_git.bb
>> +++ b/recipes/beagleboard/beagleboard-test-scripts_git.bb
>> @@ -1,14 +1,18 @@
>>  ## Reminder:  The correct spacing for a variable is FOO = "BAR"  in : PR="r1"
>>  DESCRIPTION = "BeagleBoard test scripts"
>>  HOMEPAGE = "http://beagleboad.org/support"
>> -PR = "r2"
>> +PR = "r3"
>> 
>> -SRC_URI = "git://gitorious.org/beagleboard-validation/scripts.git;protocol=git \
>> +SRC_URI = "git://gitorious.org/~joelf/beagleboard-validation/validation-scripts.git;protocol=git \
>>  "
>> 
>> -SRCREV = "473dd2ab20d866be6168c9f992c2c9e74e485c9d"
>> +SRCREV = "513bfa2e99822150ea5845f3a33c349029cb7c13"
> 
> Thanks!
> 
>>  S = "${WORKDIR}/git"
>> 
>> +inherit update-rc.d
>> +INITSCRIPT_NAME = "flash-fs.sh"
>> +INITSCRIPT_PARAMS = "start 99 2 3 4 5 ."
>> +
>>  do_install() {
>>   TEST_FILES=" \
>>     testaudio \
>> @@ -28,4 +32,8 @@ do_install() {
>>   for i in ${TEST_FILES}; do
>>     install -m 0755 ${S}/${i} ${D}/${bindir}
>>   done
>> +  # A script to flash NAND if the board has it, and if there is valid image to flash on the SD Card.
>> +  # We also register it as an init script so that the SD Card auto-flashes to NAND during boot.
>> +  install -d ${D}/${sysconfdir}/init.d/
>> +  install -m 0755 ${S}/flashing/flash-fs.sh ${D}/${sysconfdir}/init.d/flash-fs.sh

Would it be better to call it flash-nand-fs.sh ? Or have NAND somewhere in it's name
>>  }
>> --
>> 1.7.0.4
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

Patch

diff --git a/recipes/beagleboard/beagleboard-test-scripts_git.bb b/recipes/beagleboard/beagleboard-test-scripts_git.bb
index be0d059..3f3cc56 100644
--- a/recipes/beagleboard/beagleboard-test-scripts_git.bb
+++ b/recipes/beagleboard/beagleboard-test-scripts_git.bb
@@ -1,14 +1,18 @@ 
 ## Reminder:  The correct spacing for a variable is FOO = "BAR"  in : PR="r1"
 DESCRIPTION = "BeagleBoard test scripts"
 HOMEPAGE = "http://beagleboad.org/support"
-PR = "r2"
+PR = "r3"
 
-SRC_URI = "git://gitorious.org/beagleboard-validation/scripts.git;protocol=git \
+SRC_URI = "git://gitorious.org/~joelf/beagleboard-validation/validation-scripts.git;protocol=git \
 "
 
-SRCREV = "473dd2ab20d866be6168c9f992c2c9e74e485c9d"
+SRCREV = "513bfa2e99822150ea5845f3a33c349029cb7c13"
 S = "${WORKDIR}/git"
 
+inherit update-rc.d
+INITSCRIPT_NAME = "flash-fs.sh"
+INITSCRIPT_PARAMS = "start 99 2 3 4 5 ."
+
 do_install() {
   TEST_FILES=" \
     testaudio \
@@ -28,4 +32,8 @@  do_install() {
   for i in ${TEST_FILES}; do
     install -m 0755 ${S}/${i} ${D}/${bindir}
   done
+  # A script to flash NAND if the board has it, and if there is valid image to flash on the SD Card.
+  # We also register it as an init script so that the SD Card auto-flashes to NAND during boot.
+  install -d ${D}/${sysconfdir}/init.d/
+  install -m 0755 ${S}/flashing/flash-fs.sh ${D}/${sysconfdir}/init.d/flash-fs.sh
 }