Patchwork [4/7] binutils: package unpackaged files

login
register
mail settings
Submitter Nitin A Kamble
Date July 7, 2011, 8:25 p.m.
Message ID <12dc19831b4766f0894ff43ae916150057a0e65e.1310070283.git.nitin.a.kamble@intel.com>
Download mbox | patch
Permalink /patch/7187/
State New, archived
Headers show

Comments

Nitin A Kamble - July 7, 2011, 8:25 p.m.
From: Nitin A Kamble <nitin.a.kamble@intel.com>

To fix these package qa warnings
WARNING: For recipe binutils, the following files were installed but not shipped in any package:
WARNING:   /usr/bin/ld.bfd
WARNING:   /usr/bin/elfedit

Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
---
 .../binutils/binutils-cross-canadian_2.21.1.bb     |    2 +-
 .../binutils/binutils-crosssdk_2.21.1.bb           |    2 +-
 meta/recipes-devtools/binutils/binutils.inc        |    2 ++
 meta/recipes-devtools/binutils/binutils_2.21.1.bb  |    2 +-
 4 files changed, 5 insertions(+), 3 deletions(-)
Khem Raj - July 7, 2011, 9:32 p.m.
On Thu, Jul 7, 2011 at 1:25 PM,  <nitin.a.kamble@intel.com> wrote:
> From: Nitin A Kamble <nitin.a.kamble@intel.com>
>
> To fix these package qa warnings
> WARNING: For recipe binutils, the following files were installed but not shipped in any package:
> WARNING:   /usr/bin/ld.bfd
> WARNING:   /usr/bin/elfedit
>
> Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
> ---
>  .../binutils/binutils-cross-canadian_2.21.1.bb     |    2 +-
>  .../binutils/binutils-crosssdk_2.21.1.bb           |    2 +-
>  meta/recipes-devtools/binutils/binutils.inc        |    2 ++
>  meta/recipes-devtools/binutils/binutils_2.21.1.bb  |    2 +-
>  4 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/meta/recipes-devtools/binutils/binutils-cross-canadian_2.21.1.bb b/meta/recipes-devtools/binutils/binutils-cross-canadian_2.21.1.bb
> index 7dad2a6..e91e7dc 100644
> --- a/meta/recipes-devtools/binutils/binutils-cross-canadian_2.21.1.bb
> +++ b/meta/recipes-devtools/binutils/binutils-cross-canadian_2.21.1.bb
> @@ -1,3 +1,3 @@
>  require binutils_${PV}.bb
>  require binutils-cross-canadian.inc
> -PR = "r0"
> +PR = "r1"
> diff --git a/meta/recipes-devtools/binutils/binutils-crosssdk_2.21.1.bb b/meta/recipes-devtools/binutils/binutils-crosssdk_2.21.1.bb
> index 0d6efff..21289cd 100644
> --- a/meta/recipes-devtools/binutils/binutils-crosssdk_2.21.1.bb
> +++ b/meta/recipes-devtools/binutils/binutils-crosssdk_2.21.1.bb
> @@ -4,7 +4,7 @@ inherit crosssdk
>
>  PROVIDES = "virtual/${TARGET_PREFIX}binutils-crosssdk"
>
> -PR = "r0"
> +PR = "r1"
>
>  do_configure_prepend () {
>        sed -i 's#/usr/local/lib /lib /usr/lib#${SDKPATHNATIVE}/lib ${SDKPATHNATIVE}/usr/lib /usr/local/lib /lib /usr/lib#' ${S}/ld/configure.tgt
> diff --git a/meta/recipes-devtools/binutils/binutils.inc b/meta/recipes-devtools/binutils/binutils.inc
> index 08c14b2..9a6b9c8 100644
> --- a/meta/recipes-devtools/binutils/binutils.inc
> +++ b/meta/recipes-devtools/binutils/binutils.inc
> @@ -35,11 +35,13 @@ FILES_${PN}-symlinks = " \
>        ${bindir}/c++filt \
>        ${bindir}/gprof \
>        ${bindir}/ld \
> +       ${bindir}/ld.bfd \
>        ${bindir}/nm \
>        ${bindir}/objcopy \
>        ${bindir}/objdump \
>        ${bindir}/ranlib \
>        ${bindir}/readelf \
> +       ${bindir}/elfedit \
>        ${bindir}/size \
>        ${bindir}/strip"
>

I wonder if symlinks is appropriate name for this Package if it does
not have symlinks

> diff --git a/meta/recipes-devtools/binutils/binutils_2.21.1.bb b/meta/recipes-devtools/binutils/binutils_2.21.1.bb
> index 368ec4a..4eb6566 100644
> --- a/meta/recipes-devtools/binutils/binutils_2.21.1.bb
> +++ b/meta/recipes-devtools/binutils/binutils_2.21.1.bb
> @@ -1,6 +1,6 @@
>  require binutils.inc
>
> -PR = "r0"
> +PR = "r1"
>
>  LIC_FILES_CHKSUM="\
>     file://src-release;endline=17;md5=4830a9ef968f3b18dd5e9f2c00db2d35\
> --
> 1.7.4.4
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
Richard Purdie - July 8, 2011, 3:26 p.m.
On Thu, 2011-07-07 at 13:25 -0700, nitin.a.kamble@intel.com wrote:
> From: Nitin A Kamble <nitin.a.kamble@intel.com>
> 
> To fix these package qa warnings
> WARNING: For recipe binutils, the following files were installed but not shipped in any package:
> WARNING:   /usr/bin/ld.bfd
> WARNING:   /usr/bin/elfedit
> 
> Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
> ---
>  .../binutils/binutils-cross-canadian_2.21.1.bb     |    2 +-
>  .../binutils/binutils-crosssdk_2.21.1.bb           |    2 +-
>  meta/recipes-devtools/binutils/binutils.inc        |    2 ++
>  meta/recipes-devtools/binutils/binutils_2.21.1.bb  |    2 +-
>  4 files changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/meta/recipes-devtools/binutils/binutils-cross-canadian_2.21.1.bb b/meta/recipes-devtools/binutils/binutils-cross-canadian_2.21.1.bb
> index 7dad2a6..e91e7dc 100644
> --- a/meta/recipes-devtools/binutils/binutils-cross-canadian_2.21.1.bb
> +++ b/meta/recipes-devtools/binutils/binutils-cross-canadian_2.21.1.bb
> @@ -1,3 +1,3 @@
>  require binutils_${PV}.bb
>  require binutils-cross-canadian.inc
> -PR = "r0"
> +PR = "r1"
> diff --git a/meta/recipes-devtools/binutils/binutils-crosssdk_2.21.1.bb b/meta/recipes-devtools/binutils/binutils-crosssdk_2.21.1.bb
> index 0d6efff..21289cd 100644
> --- a/meta/recipes-devtools/binutils/binutils-crosssdk_2.21.1.bb
> +++ b/meta/recipes-devtools/binutils/binutils-crosssdk_2.21.1.bb
> @@ -4,7 +4,7 @@ inherit crosssdk
>  
>  PROVIDES = "virtual/${TARGET_PREFIX}binutils-crosssdk"
>  
> -PR = "r0"
> +PR = "r1"
>  
>  do_configure_prepend () {
>  	sed -i 's#/usr/local/lib /lib /usr/lib#${SDKPATHNATIVE}/lib ${SDKPATHNATIVE}/usr/lib /usr/local/lib /lib /usr/lib#' ${S}/ld/configure.tgt
> diff --git a/meta/recipes-devtools/binutils/binutils.inc b/meta/recipes-devtools/binutils/binutils.inc
> index 08c14b2..9a6b9c8 100644
> --- a/meta/recipes-devtools/binutils/binutils.inc
> +++ b/meta/recipes-devtools/binutils/binutils.inc
> @@ -35,11 +35,13 @@ FILES_${PN}-symlinks = " \
>  	${bindir}/c++filt \
>  	${bindir}/gprof \
>  	${bindir}/ld \
> +	${bindir}/ld.bfd \
>  	${bindir}/nm \
>  	${bindir}/objcopy \
>  	${bindir}/objdump \
>  	${bindir}/ranlib \
>  	${bindir}/readelf \
> +	${bindir}/elfedit \
>  	${bindir}/size \
>  	${bindir}/strip"

Nitin, do you know if the ld.bfd above is a hardlinked copy of ld?

It may be better to turn this into a symlink if so (although our
packaging process should preserve hardlinks these days).

Cheers,

Richard
Phil Blundell - July 8, 2011, 3:34 p.m.
On Fri, 2011-07-08 at 16:26 +0100, Richard Purdie wrote:
> > @@ -35,11 +35,13 @@ FILES_${PN}-symlinks = " \
> >  	${bindir}/c++filt \
> >  	${bindir}/gprof \
> >  	${bindir}/ld \
> > +	${bindir}/ld.bfd \
> >  	${bindir}/nm \
> >  	${bindir}/objcopy \
> >  	${bindir}/objdump \
> >  	${bindir}/ranlib \
> >  	${bindir}/readelf \
> > +	${bindir}/elfedit \
> >  	${bindir}/size \
> >  	${bindir}/strip"
> 
> Nitin, do you know if the ld.bfd above is a hardlinked copy of ld?

If you're getting ld.bfd at all (at least with our current recipes) then
it probably means that ${bindir}/ld is gold.  So in that case they
oughtn't to be symlinked.

p.
Nitin A Kamble - July 8, 2011, 5:10 p.m.
> -----Original Message-----
> From: openembedded-core-bounces@lists.openembedded.org
> [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of
> Richard Purdie
> Sent: Friday, July 08, 2011 8:27 AM
> To: Patches and discussions about the oe-core layer
> Subject: Re: [OE-core] [PATCH 4/7] binutils: package unpackaged files
> 
> On Thu, 2011-07-07 at 13:25 -0700, nitin.a.kamble@intel.com wrote:
> > From: Nitin A Kamble <nitin.a.kamble@intel.com>
> >
> > To fix these package qa warnings
> > WARNING: For recipe binutils, the following files were installed but
> not shipped in any package:
> > WARNING:   /usr/bin/ld.bfd
> > WARNING:   /usr/bin/elfedit
> >
> > Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
> > ---
> >  .../binutils/binutils-cross-canadian_2.21.1.bb     |    2 +-
> >  .../binutils/binutils-crosssdk_2.21.1.bb           |    2 +-
> >  meta/recipes-devtools/binutils/binutils.inc        |    2 ++
> >  meta/recipes-devtools/binutils/binutils_2.21.1.bb  |    2 +-
> >  4 files changed, 5 insertions(+), 3 deletions(-)
> >
> > diff --git a/meta/recipes-devtools/binutils/binutils-cross-
> canadian_2.21.1.bb b/meta/recipes-devtools/binutils/binutils-cross-
> canadian_2.21.1.bb
> > index 7dad2a6..e91e7dc 100644
> > --- a/meta/recipes-devtools/binutils/binutils-cross-
> canadian_2.21.1.bb
> > +++ b/meta/recipes-devtools/binutils/binutils-cross-
> canadian_2.21.1.bb
> > @@ -1,3 +1,3 @@
> >  require binutils_${PV}.bb
> >  require binutils-cross-canadian.inc
> > -PR = "r0"
> > +PR = "r1"
> > diff --git a/meta/recipes-devtools/binutils/binutils-
> crosssdk_2.21.1.bb b/meta/recipes-devtools/binutils/binutils-
> crosssdk_2.21.1.bb
> > index 0d6efff..21289cd 100644
> > --- a/meta/recipes-devtools/binutils/binutils-crosssdk_2.21.1.bb
> > +++ b/meta/recipes-devtools/binutils/binutils-crosssdk_2.21.1.bb
> > @@ -4,7 +4,7 @@ inherit crosssdk
> >
> >  PROVIDES = "virtual/${TARGET_PREFIX}binutils-crosssdk"
> >
> > -PR = "r0"
> > +PR = "r1"
> >
> >  do_configure_prepend () {
> >  	sed -i 's#/usr/local/lib /lib /usr/lib#${SDKPATHNATIVE}/lib
> ${SDKPATHNATIVE}/usr/lib /usr/local/lib /lib /usr/lib#'
> ${S}/ld/configure.tgt
> > diff --git a/meta/recipes-devtools/binutils/binutils.inc
> b/meta/recipes-devtools/binutils/binutils.inc
> > index 08c14b2..9a6b9c8 100644
> > --- a/meta/recipes-devtools/binutils/binutils.inc
> > +++ b/meta/recipes-devtools/binutils/binutils.inc
> > @@ -35,11 +35,13 @@ FILES_${PN}-symlinks = " \
> >  	${bindir}/c++filt \
> >  	${bindir}/gprof \
> >  	${bindir}/ld \
> > +	${bindir}/ld.bfd \
> >  	${bindir}/nm \
> >  	${bindir}/objcopy \
> >  	${bindir}/objdump \
> >  	${bindir}/ranlib \
> >  	${bindir}/readelf \
> > +	${bindir}/elfedit \
> >  	${bindir}/size \
> >  	${bindir}/strip"
> 
> Nitin, do you know if the ld.bfd above is a hardlinked copy of ld?
> 
> It may be better to turn this into a symlink if so (although our
> packaging process should preserve hardlinks these days).
> 
Richard,
   The ld.bfd is softlink to <target_tupple>_ld. Hence I put it in the symlinks package.
Nitin


> Cheers,
> 
> Richard
> 
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Nitin A Kamble - July 8, 2011, 9:15 p.m.
> -----Original Message-----
> From: openembedded-core-bounces@lists.openembedded.org
> [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of
> Phil Blundell
> Sent: Friday, July 08, 2011 8:34 AM
> To: Patches and discussions about the oe-core layer
> Subject: Re: [OE-core] [PATCH 4/7] binutils: package unpackaged files
> 
> On Fri, 2011-07-08 at 16:26 +0100, Richard Purdie wrote:
> > > @@ -35,11 +35,13 @@ FILES_${PN}-symlinks = " \
> > >  	${bindir}/c++filt \
> > >  	${bindir}/gprof \
> > >  	${bindir}/ld \
> > > +	${bindir}/ld.bfd \
> > >  	${bindir}/nm \
> > >  	${bindir}/objcopy \
> > >  	${bindir}/objdump \
> > >  	${bindir}/ranlib \
> > >  	${bindir}/readelf \
> > > +	${bindir}/elfedit \
> > >  	${bindir}/size \
> > >  	${bindir}/strip"
> >
> > Nitin, do you know if the ld.bfd above is a hardlinked copy of ld?
> 
> If you're getting ld.bfd at all (at least with our current recipes)
> then
> it probably means that ${bindir}/ld is gold.  So in that case they
> oughtn't to be symlinked.
> 
Just verified that ld.bfd is a soft link to i586-poky-linux-ld.bfd

So what is the right think here, rm -f ld.bfd, or putting it in the symlinks package is good?

Nitin

> p.
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Phil Blundell - July 8, 2011, 9:29 p.m.
On Fri, 2011-07-08 at 14:15 -0700, Kamble, Nitin A wrote:
> Just verified that ld.bfd is a soft link to i586-poky-linux-ld.bfd
> 
> So what is the right think here, rm -f ld.bfd, or putting it in the symlinks package is good?

Do the same thing that you do with ${bindir}/ld, whatever that is.
Hopefully it isn't rm -f :-)

p.

Patch

diff --git a/meta/recipes-devtools/binutils/binutils-cross-canadian_2.21.1.bb b/meta/recipes-devtools/binutils/binutils-cross-canadian_2.21.1.bb
index 7dad2a6..e91e7dc 100644
--- a/meta/recipes-devtools/binutils/binutils-cross-canadian_2.21.1.bb
+++ b/meta/recipes-devtools/binutils/binutils-cross-canadian_2.21.1.bb
@@ -1,3 +1,3 @@ 
 require binutils_${PV}.bb
 require binutils-cross-canadian.inc
-PR = "r0"
+PR = "r1"
diff --git a/meta/recipes-devtools/binutils/binutils-crosssdk_2.21.1.bb b/meta/recipes-devtools/binutils/binutils-crosssdk_2.21.1.bb
index 0d6efff..21289cd 100644
--- a/meta/recipes-devtools/binutils/binutils-crosssdk_2.21.1.bb
+++ b/meta/recipes-devtools/binutils/binutils-crosssdk_2.21.1.bb
@@ -4,7 +4,7 @@  inherit crosssdk
 
 PROVIDES = "virtual/${TARGET_PREFIX}binutils-crosssdk"
 
-PR = "r0"
+PR = "r1"
 
 do_configure_prepend () {
 	sed -i 's#/usr/local/lib /lib /usr/lib#${SDKPATHNATIVE}/lib ${SDKPATHNATIVE}/usr/lib /usr/local/lib /lib /usr/lib#' ${S}/ld/configure.tgt
diff --git a/meta/recipes-devtools/binutils/binutils.inc b/meta/recipes-devtools/binutils/binutils.inc
index 08c14b2..9a6b9c8 100644
--- a/meta/recipes-devtools/binutils/binutils.inc
+++ b/meta/recipes-devtools/binutils/binutils.inc
@@ -35,11 +35,13 @@  FILES_${PN}-symlinks = " \
 	${bindir}/c++filt \
 	${bindir}/gprof \
 	${bindir}/ld \
+	${bindir}/ld.bfd \
 	${bindir}/nm \
 	${bindir}/objcopy \
 	${bindir}/objdump \
 	${bindir}/ranlib \
 	${bindir}/readelf \
+	${bindir}/elfedit \
 	${bindir}/size \
 	${bindir}/strip"
 
diff --git a/meta/recipes-devtools/binutils/binutils_2.21.1.bb b/meta/recipes-devtools/binutils/binutils_2.21.1.bb
index 368ec4a..4eb6566 100644
--- a/meta/recipes-devtools/binutils/binutils_2.21.1.bb
+++ b/meta/recipes-devtools/binutils/binutils_2.21.1.bb
@@ -1,6 +1,6 @@ 
 require binutils.inc
 
-PR = "r0"
+PR = "r1"
 
 LIC_FILES_CHKSUM="\
     file://src-release;endline=17;md5=4830a9ef968f3b18dd5e9f2c00db2d35\