Patchwork weston: add lcms, libpoppler-glib dependenies

login
register
mail settings
Submitter Tim Orling
Date May 9, 2014, 2:31 p.m.
Message ID <1399645908-14499-1-git-send-email-ticotimo@gmail.com>
Download mbox | patch
Permalink /patch/71819/
State New
Headers show

Comments

Tim Orling - May 9, 2014, 2:31 p.m.
From: Tim Orling <TicoTimo@gmail.com>

fixes for JaMa test-dependencies build (oe-core-contrib/jansa/daisy-backports)

Signed-off-by: Tim Orling <TicoTimo@gmail.com>
---
 meta/recipes-graphics/wayland/weston_1.4.0.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Ross Burton - May 9, 2014, 2:42 p.m.
On 9 May 2014 15:31, Tim Orling <ticotimo@gmail.com> wrote:
> +DEPENDS += "wayland virtual/egl pango lcms libpoppler-glib"

For a start libpoppler isn't in oe-core, so this causes a build
failure for everyone not using meta-oe.

These are for the basic test applications: I'd prefer to see a patch
that either forcibly disabled the checks or added configure options so
the dependencies can be controlled.

Ross
Martin Jansa - May 9, 2014, 3:07 p.m.
On Fri, May 09, 2014 at 03:42:37PM +0100, Burton, Ross wrote:
> On 9 May 2014 15:31, Tim Orling <ticotimo@gmail.com> wrote:
> > +DEPENDS += "wayland virtual/egl pango lcms libpoppler-glib"
> 
> For a start libpoppler isn't in oe-core, so this causes a build
> failure for everyone not using meta-oe.
> 
> These are for the basic test applications: I'd prefer to see a patch
> that either forcibly disabled the checks or added configure options so
> the dependencies can be controlled.

FWIW: I've sent WIP patch a while ago, but never finished it
http://patchwork.openembedded.org/patch/57011/

IIRC it doesn't apply to current version now.
Ross Burton - May 9, 2014, 3:18 p.m.
On 9 May 2014 16:07, Martin Jansa <martin.jansa@gmail.com> wrote:
>> For a start libpoppler isn't in oe-core, so this causes a build
>> failure for everyone not using meta-oe.
>>
>> These are for the basic test applications: I'd prefer to see a patch
>> that either forcibly disabled the checks or added configure options so
>> the dependencies can be controlled.
>
> FWIW: I've sent WIP patch a while ago, but never finished it
> http://patchwork.openembedded.org/patch/57011/
>
> IIRC it doesn't apply to current version now.

If definitely doesn't apply to master: weston doesn't check for
poppler anymore as the PDF viewer was removed.

LCMS should have an explicit with/without as it is used for colour
management in the server.

Ross
Tim Orling - May 9, 2014, 4:46 p.m.
Consider this patch DOA. I'll try over the weekend to apply a more
appropriate fix, unless someone else wants to jump in. There are plenty of
other packages on the list :)


On Fri, May 9, 2014 at 8:18 AM, Burton, Ross <ross.burton@intel.com> wrote:

> On 9 May 2014 16:07, Martin Jansa <martin.jansa@gmail.com> wrote:
> >> For a start libpoppler isn't in oe-core, so this causes a build
> >> failure for everyone not using meta-oe.
> >>
> >> These are for the basic test applications: I'd prefer to see a patch
> >> that either forcibly disabled the checks or added configure options so
> >> the dependencies can be controlled.
> >
> > FWIW: I've sent WIP patch a while ago, but never finished it
> > http://patchwork.openembedded.org/patch/57011/
> >
> > IIRC it doesn't apply to current version now.
>
> If definitely doesn't apply to master: weston doesn't check for
> poppler anymore as the PDF viewer was removed.
>
> LCMS should have an explicit with/without as it is used for colour
> management in the server.
>
> Ross
>
Martin Jansa - May 9, 2014, 10:29 p.m.
On Fri, May 09, 2014 at 04:18:36PM +0100, Burton, Ross wrote:
> On 9 May 2014 16:07, Martin Jansa <martin.jansa@gmail.com> wrote:
> >> For a start libpoppler isn't in oe-core, so this causes a build
> >> failure for everyone not using meta-oe.
> >>
> >> These are for the basic test applications: I'd prefer to see a patch
> >> that either forcibly disabled the checks or added configure options so
> >> the dependencies can be controlled.
> >
> > FWIW: I've sent WIP patch a while ago, but never finished it
> > http://patchwork.openembedded.org/patch/57011/
> >
> > IIRC it doesn't apply to current version now.
> 
> If definitely doesn't apply to master: weston doesn't check for
> poppler anymore as the PDF viewer was removed.

Something still links with it as shows in test-dependencies reports:

weston/weston/latest lost dependency on  lcms                                                                                                                 
weston/weston-examples/latest lost dependency on  libpoppler-glib
Tim Orling - May 9, 2014, 11:47 p.m.
From upstream:
clients: Drop pdf viewer sample client
http://cgit.freedesktop.org/wayland/weston/commit/?id=a72d37566780ab8abab235cd21817733962cb1e1



On Fri, May 9, 2014 at 3:29 PM, Martin Jansa <martin.jansa@gmail.com> wrote:

> On Fri, May 09, 2014 at 04:18:36PM +0100, Burton, Ross wrote:
> > On 9 May 2014 16:07, Martin Jansa <martin.jansa@gmail.com> wrote:
> > >> For a start libpoppler isn't in oe-core, so this causes a build
> > >> failure for everyone not using meta-oe.
> > >>
> > >> These are for the basic test applications: I'd prefer to see a patch
> > >> that either forcibly disabled the checks or added configure options so
> > >> the dependencies can be controlled.
> > >
> > > FWIW: I've sent WIP patch a while ago, but never finished it
> > > http://patchwork.openembedded.org/patch/57011/
> > >
> > > IIRC it doesn't apply to current version now.
> >
> > If definitely doesn't apply to master: weston doesn't check for
> > poppler anymore as the PDF viewer was removed.
>
> Something still links with it as shows in test-dependencies reports:
>
> weston/weston/latest lost dependency on  lcms
> weston/weston-examples/latest lost dependency on  libpoppler-glib
>
> --
> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
>
Ross Burton - May 10, 2014, 7:21 a.m.
On 9 May 2014 23:29, Martin Jansa <martin.jansa@gmail.com> wrote:
> Something still links with it as shows in test-dependencies reports:
>
> weston/weston/latest lost dependency on  lcms
> weston/weston-examples/latest lost dependency on  libpoppler-glib

Sorry, I meant weston master, not oe-core master.

Ross

Patch

diff --git a/meta/recipes-graphics/wayland/weston_1.4.0.bb b/meta/recipes-graphics/wayland/weston_1.4.0.bb
index 5213166..abacb58 100644
--- a/meta/recipes-graphics/wayland/weston_1.4.0.bb
+++ b/meta/recipes-graphics/wayland/weston_1.4.0.bb
@@ -16,7 +16,7 @@  SRC_URI[sha256sum] = "74a2319d98e9cdb1acf24659699719aa89ac268cf549759271e326edc5
 inherit autotools pkgconfig useradd
 
 DEPENDS = "libxkbcommon gdk-pixbuf pixman cairo glib-2.0 jpeg"
-DEPENDS += "wayland virtual/egl pango"
+DEPENDS += "wayland virtual/egl pango lcms libpoppler-glib"
 
 EXTRA_OECONF = "--enable-setuid-install \
                 --disable-xwayland \