Patchwork [bitbake-devel,3/5] toaster: fix span2 headings for packages

login
register
mail settings
Submitter Alexandru DAMIAN
Date May 8, 2014, 1:24 p.m.
Message ID <0d19987bd81fb2fc785b05220db22d422e5cc536.1399555312.git.alexandru.damian@intel.com>
Download mbox | patch
Permalink /patch/71773/
State New
Headers show

Comments

Alexandru DAMIAN - May 8, 2014, 1:24 p.m.
From: Dave Lerner <dave.lerner@windriver.com>

[YOCTO 6147]

Fix bug in views.py that put 'span2' class id in a 'clclass' key
instead of the 'dclass' key.  This fix exposed another problem in
target.html and the target view function that used 'package_size'
instead of 'size' as the 'clclass' which is inconsistent with the
model field name, causing table data columns to be shown when
the header is hidden.

Signed-off-by: Dave Lerner <dave.lerner@windriver.com>
---
 lib/toaster/toastergui/templates/target.html | 2 +-
 lib/toaster/toastergui/views.py              | 9 ++++++---
 2 files changed, 7 insertions(+), 4 deletions(-)

Patch

diff --git a/lib/toaster/toastergui/templates/target.html b/lib/toaster/toastergui/templates/target.html
index 86e46dc..564fd27 100644
--- a/lib/toaster/toastergui/templates/target.html
+++ b/lib/toaster/toastergui/templates/target.html
@@ -79,7 +79,7 @@ 
             {{package.version|filtered_packageversion:package.revision}}
             </a>
         </td>
-        <td class="package-size sizecol">
+        <td class="size sizecol">
             {{package.size|filtered_installedsize:package.installed_size|filtered_filesizeformat}}
         </td>
         <td class="size_over_total sizecol">
diff --git a/lib/toaster/toastergui/views.py b/lib/toaster/toastergui/views.py
index 3d2ed4c..e3b24ba 100644
--- a/lib/toaster/toastergui/views.py
+++ b/lib/toaster/toastergui/views.py
@@ -575,13 +575,15 @@  def target(request, build_id, target_id):
                     'qhelp':'The size of the package',
                     'orderfield': _get_toggle_order(request, "size", True),
                     'ordericon':_get_toggle_order_icon(request, "size"),
-                    'clclass': 'package_size span2',
+                    'clclass': 'size',
+                    'dclass' : 'span2',
                     'hidden' : 0,
                 },
                 {
                     'name':'Size over total (%)',
                     'qhelp':'Proportion of the overall included package size represented by this package',
-                    'clclass': 'size_over_total span2',
+                    'clclass': 'size_over_total',
+                    'dclass' : 'span2',
                     'hidden' : 1,
                 },
                 {
@@ -1273,7 +1275,8 @@  def bpackage(request, build_id):
                 'qhelp':'The size of the package',
                 'orderfield': _get_toggle_order(request, "size", True),
                 'ordericon':_get_toggle_order_icon(request, "size"),
-                'clclass': 'size span2', 'hidden': 0,
+                'clclass': 'size', 'hidden': 0,
+                'dclass' : 'span2',
             },
             {
                 'name':'License',