Patchwork [08/13] linuxdoc-tools: remove usage of FILESPATH

login
register
mail settings
Submitter Petter Mabäcker
Date May 7, 2014, 9:19 p.m.
Message ID <f9d97da2b459cde8ed023d1f130b1af580eb436e.1399497346.git.petter@technux.se>
Download mbox | patch
Permalink /patch/71741/
State New
Headers show

Comments

Petter Mabäcker - May 7, 2014, 9:19 p.m.
Fixes [YOCTO #4497]

Usage of FILESPATH is discouraged, since it can make recipes harder to
bbappend. Instead FILESEXTRAPATHS should be used to extend the path.

Signed-off-by: Petter Mabäcker <petter@technux.se>
---
 .../linuxdoc-tools/linuxdoc-tools-native_0.9.69.bb |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Martin Jansa - May 8, 2014, 10:50 a.m.
On Wed, May 07, 2014 at 11:19:54PM +0200, Petter Mabäcker wrote:
> Fixes [YOCTO #4497]
> 
> Usage of FILESPATH is discouraged, since it can make recipes harder to
> bbappend. Instead FILESEXTRAPATHS should be used to extend the path.
> 
> Signed-off-by: Petter Mabäcker <petter@technux.se>
> ---
>  .../linuxdoc-tools/linuxdoc-tools-native_0.9.69.bb |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/meta/recipes-devtools/linuxdoc-tools/linuxdoc-tools-native_0.9.69.bb b/meta/recipes-devtools/linuxdoc-tools/linuxdoc-tools-native_0.9.69.bb
> index fce4178..4f908c3 100644
> --- a/meta/recipes-devtools/linuxdoc-tools/linuxdoc-tools-native_0.9.69.bb
> +++ b/meta/recipes-devtools/linuxdoc-tools/linuxdoc-tools-native_0.9.69.bb
> @@ -5,6 +5,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=077ef64ec3ac257fb0d786531cf26931"
>  
>  DEPENDS = "groff-native openjade-native"
>  
> +FILESEXTRAPATHS_prepend := "${THISDIR}/linuxdoc-tools-native:"

Please use

git mv meta/recipes-devtools/linuxdoc-tools/linuxdoc-tools-native meta/recipes-devtools/linuxdoc-tools/linuxdoc-tools

instead

>  
>  SRC_URI = "${DEBIAN_MIRROR}/main/l/linuxdoc-tools/linuxdoc-tools_${PV}.orig.tar.gz \
>             file://disable_sgml2rtf.patch \
> @@ -15,8 +16,6 @@ SRC_URI = "${DEBIAN_MIRROR}/main/l/linuxdoc-tools/linuxdoc-tools_${PV}.orig.tar.
>  SRC_URI[md5sum] = "1d13d500918a7a145b0edc2f16f61dd1"
>  SRC_URI[sha256sum] = "7103facee18a2ea97186ca459d743d22f7f89ad4b5cd1dfd1c34f83d6bfd4101"
>  
> -FILESPATH = "${FILE_DIRNAME}/linuxdoc-tools-native/"
> -
>  inherit autotools-brokensep native
>  
>  do_configure () {
> -- 
> 1.7.9.5
> 
> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
Petter Mabäcker - May 8, 2014, 2:48 p.m.
2014-05-08 12:50 skrev Martin Jansa:

> On Wed, May 07, 2014 at 11:19:54PM +0200, Petter Mabäcker wrote:
>
>> Fixes [YOCTO #4497] Usage of FILESPATH is discouraged, since it can
>> make recipes harder to bbappend. Instead FILESEXTRAPATHS should be 
>> used
>> to extend the path. Signed-off-by: Petter Mabäcker 
>> <petter@technux.se>
>> --- .../linuxdoc-tools/linuxdoc-tools-native_0.9.69.bb | 3 +-- 1 
>> file
>> changed, 1 insertion(+), 2 deletions(-) diff --git
>> 
>> a/meta/recipes-devtools/linuxdoc-tools/linuxdoc-tools-native_0.9.69.bb
>> 
>> b/meta/recipes-devtools/linuxdoc-tools/linuxdoc-tools-native_0.9.69.bb
>> index fce4178..4f908c3 100644 ---
>> 
>> a/meta/recipes-devtools/linuxdoc-tools/linuxdoc-tools-native_0.9.69.bb
>> +++
>> 
>> b/meta/recipes-devtools/linuxdoc-tools/linuxdoc-tools-native_0.9.69.bb
>> @@ -5,6 +5,7 @@ LIC_FILES_CHKSUM =
>> "file://COPYING;md5=077ef64ec3ac257fb0d786531cf26931" DEPENDS =
>> "groff-native openjade-native" +FILESEXTRAPATHS_prepend :=
>> "${THISDIR}/linuxdoc-tools-native:"
>
> Please use
>
> git mv meta/recipes-devtools/linuxdoc-tools/linuxdoc-tools-native
> meta/recipes-devtools/linuxdoc-tools/linuxdoc-tools
>
> instead

Good point, feels like a better way to solve it that way. Will fix this 
in v2.

>
>> SRC_URI =
>>
> 
> "${DEBIAN_MIRROR}/main/l/linuxdoc-tools/linuxdoc-tools_${PV}.orig.tar.gz
>> file://disable_sgml2rtf.patch [1] @@ -15,8 +16,6 @@ SRC_URI =
>> 
>> "${DEBIAN_MIRROR}/main/l/linuxdoc-tools/linuxdoc-tools_${PV}.orig.tar.
>> SRC_URI[md5sum] = "1d13d500918a7a145b0edc2f16f61dd1" 
>> SRC_URI[sha256sum]
>> = "7103facee18a2ea97186ca459d743d22f7f89ad4b5cd1dfd1c34f83d6bfd4101"
>> -FILESPATH = "${FILE_DIRNAME}/linuxdoc-tools-native/" - inherit
>> autotools-brokensep native do_configure () { -- 1.7.9.5 --
>> _______________________________________________ Openembedded-core
>> mailing list Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core [2]


Links:
------
[1] file://disable_sgml2rtf.patch
[2] http://lists.openembedded.org/mailman/listinfo/openembedded-core

Patch

diff --git a/meta/recipes-devtools/linuxdoc-tools/linuxdoc-tools-native_0.9.69.bb b/meta/recipes-devtools/linuxdoc-tools/linuxdoc-tools-native_0.9.69.bb
index fce4178..4f908c3 100644
--- a/meta/recipes-devtools/linuxdoc-tools/linuxdoc-tools-native_0.9.69.bb
+++ b/meta/recipes-devtools/linuxdoc-tools/linuxdoc-tools-native_0.9.69.bb
@@ -5,6 +5,7 @@  LIC_FILES_CHKSUM = "file://COPYING;md5=077ef64ec3ac257fb0d786531cf26931"
 
 DEPENDS = "groff-native openjade-native"
 
+FILESEXTRAPATHS_prepend := "${THISDIR}/linuxdoc-tools-native:"
 
 SRC_URI = "${DEBIAN_MIRROR}/main/l/linuxdoc-tools/linuxdoc-tools_${PV}.orig.tar.gz \
            file://disable_sgml2rtf.patch \
@@ -15,8 +16,6 @@  SRC_URI = "${DEBIAN_MIRROR}/main/l/linuxdoc-tools/linuxdoc-tools_${PV}.orig.tar.
 SRC_URI[md5sum] = "1d13d500918a7a145b0edc2f16f61dd1"
 SRC_URI[sha256sum] = "7103facee18a2ea97186ca459d743d22f7f89ad4b5cd1dfd1c34f83d6bfd4101"
 
-FILESPATH = "${FILE_DIRNAME}/linuxdoc-tools-native/"
-
 inherit autotools-brokensep native
 
 do_configure () {