Patchwork [3/3] kernel.bbclass: prevent QA warning about kernel-module-lirc-dev

login
register
mail settings
Submitter Paul Eggleton
Date July 7, 2011, 5:32 p.m.
Message ID <fb8c0dba84b1b0d8c1ac548e0379f25f6c1439f3.1310059749.git.paul.eggleton@linux.intel.com>
Download mbox | patch
Permalink /patch/7171/
State Superseded
Headers show

Comments

Paul Eggleton - July 7, 2011, 5:32 p.m.
kernel-module-lirc-dev is not a development package (it's a package for
a kernel module called lirc_dev) so add an INSANE_SKIP that will prevent
it from being flagged up.

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
---
 meta/classes/kernel.bbclass |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
Andreas Müller - July 7, 2011, 7:08 p.m.
On Thursday, July 07, 2011 07:32:48 PM Paul Eggleton wrote:
> kernel-module-lirc-dev is not a development package (it's a package for
> a kernel module called lirc_dev) so add an INSANE_SKIP that will prevent
> it from being flagged up.
> 
> Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
> ---
>  meta/classes/kernel.bbclass |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index 943252a..318f5c2 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -503,3 +503,7 @@ PACKAGES =+ "perf-dbg perf"
>  FILES_perf = "${bindir}/* \
>                ${libexecdir}"
>  FILES_perf-dbg = "${FILES_${PN}-dbg}"
> +
> +# We don't want a warning for kernel-module-lirc-dev
> +INSANE_SKIP_kernel-module-ir-lirc-codec += "dev-deps"
> +
I just received

| WARNING: QA Issue: kernel-modules rdepends on kernel-module-i2c-dev

So I think a better solution is reworking commit 
2e06a1a843756e9d50291c4533b10096af2d852b e.g. by excluding all kernel *modules* 
from *dev check. 

Andreas
Phil Blundell - July 7, 2011, 7:13 p.m.
On Thu, 2011-07-07 at 21:08 +0200, Andreas Mueller wrote:
> So I think a better solution is reworking commit 
> 2e06a1a843756e9d50291c4533b10096af2d852b e.g. by excluding all kernel *modules* 
> from *dev check. 

Yeah, or try to be smarter about determining what exactly is a "dev"
package, e.g. by some sort of flag variable rather than by trying to
guess from the name.

p.

Patch

diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
index 943252a..318f5c2 100644
--- a/meta/classes/kernel.bbclass
+++ b/meta/classes/kernel.bbclass
@@ -503,3 +503,7 @@  PACKAGES =+ "perf-dbg perf"
 FILES_perf = "${bindir}/* \
               ${libexecdir}"
 FILES_perf-dbg = "${FILES_${PN}-dbg}"
+
+# We don't want a warning for kernel-module-lirc-dev
+INSANE_SKIP_kernel-module-ir-lirc-codec += "dev-deps"
+