Patchwork [1/6] kernel-yocto: quote kconfig mode check

mail settings
Submitter Bruce Ashfield
Date May 5, 2014, 2:10 p.m.
Message ID <>
Download mbox | patch
Permalink /patch/71511/
State Accepted
Commit aad19e4381a8a09c354e5899885997c5b4cd115b
Headers show


Bruce Ashfield - May 5, 2014, 2:10 p.m.
We allow inheriting recipes to control the kconfig mode used by
via the KCONFIG_MODE variable. An error crept into the variable reference, and
since it is not quoted, the true condition always runs.

The result is that operations without an explicit kconfig mode cannot trigger
allnoconfig for defconfig builds, which can result in some options being
dropped from the final .config.

Quoting the reference allows it to evaluate properly.

Signed-off-by: Bruce Ashfield <>
 meta/classes/kernel-yocto.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


diff --git a/meta/classes/kernel-yocto.bbclass b/meta/classes/kernel-yocto.bbclass
index 53bc6d443cdb..6010dc94e026 100644
--- a/meta/classes/kernel-yocto.bbclass
+++ b/meta/classes/kernel-yocto.bbclass
@@ -241,7 +241,7 @@  do_kernel_configme() {
 	echo "[INFO] doing kernel configme"
 	export KMETA=${KMETA}
-	if [ -n ${KCONFIG_MODE} ]; then
+	if [ -n "${KCONFIG_MODE}" ]; then
 		# If a defconfig was passed, use =n as the baseline, which is achieved