Patchwork libarchive: add missing e2fsprogs dependency

login
register
mail settings
Submitter Koen Kooi
Date May 5, 2014, 11:26 a.m.
Message ID <1399289179-5662-1-git-send-email-koen.kooi@linaro.org>
Download mbox | patch
Permalink /patch/71507/
State New
Headers show

Comments

Koen Kooi - May 5, 2014, 11:26 a.m.
This fixes the following build error:
	| libarchive/archive_entry.c:59:55: fatal error: ext2fs/ext2_fs.h: No such file or directory

There is no configure options to avoid this dependency.

Signed-off-by: Koen Kooi <koen.kooi@linaro.org>
---
 meta/recipes-extended/libarchive/libarchive_3.1.2.bb | 2 ++
 1 file changed, 2 insertions(+)
Saul Wold - May 5, 2014, 9:54 p.m.
On 05/05/2014 04:26 AM, Koen Kooi wrote:
> This fixes the following build error:
> 	| libarchive/archive_entry.c:59:55: fatal error: ext2fs/ext2_fs.h: No such file or directory
>
> There is no configure options to avoid this dependency.
>
> Signed-off-by: Koen Kooi <koen.kooi@linaro.org>
> ---
>   meta/recipes-extended/libarchive/libarchive_3.1.2.bb | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/meta/recipes-extended/libarchive/libarchive_3.1.2.bb b/meta/recipes-extended/libarchive/libarchive_3.1.2.bb
> index eedbaa7..277d8c8 100644
> --- a/meta/recipes-extended/libarchive/libarchive_3.1.2.bb
> +++ b/meta/recipes-extended/libarchive/libarchive_3.1.2.bb
> @@ -5,6 +5,8 @@ SECTION = "devel"
>   LICENSE = "BSD"
>   LIC_FILES_CHKSUM = "file://COPYING;md5=b4e3ffd607d6686c6cb2f63394370841"
>
> +DEPENDS = "e2fsprogs"
> +

By doing this we also have to extend e2fprogs to be a nativesdk target.

Is there not a way to make this optional by editing the configure.ac and 
adding a switch?  What functionality to we gain or loose with / without 
the ext2fs extensions?

Sau!

>   PACKAGECONFIG ?= "libxml2 zlib bz2"
>
>   PACKAGECONFIG_append_class-target = "\
>
Koen Kooi - May 6, 2014, 5:52 a.m.
Op 5 mei 2014, om 23:54 heeft Saul Wold <sgw@linux.intel.com> het volgende geschreven:

> On 05/05/2014 04:26 AM, Koen Kooi wrote:
>> This fixes the following build error:
>> 	| libarchive/archive_entry.c:59:55: fatal error: ext2fs/ext2_fs.h: No such file or directory
>> 
>> There is no configure options to avoid this dependency.
>> 
>> Signed-off-by: Koen Kooi <koen.kooi@linaro.org>
>> ---
>>  meta/recipes-extended/libarchive/libarchive_3.1.2.bb | 2 ++
>>  1 file changed, 2 insertions(+)
>> 
>> diff --git a/meta/recipes-extended/libarchive/libarchive_3.1.2.bb b/meta/recipes-extended/libarchive/libarchive_3.1.2.bb
>> index eedbaa7..277d8c8 100644
>> --- a/meta/recipes-extended/libarchive/libarchive_3.1.2.bb
>> +++ b/meta/recipes-extended/libarchive/libarchive_3.1.2.bb
>> @@ -5,6 +5,8 @@ SECTION = "devel"
>>  LICENSE = "BSD"
>>  LIC_FILES_CHKSUM = "file://COPYING;md5=b4e3ffd607d6686c6cb2f63394370841"
>> 
>> +DEPENDS = "e2fsprogs"
>> +
> 
> By doing this we also have to extend e2fprogs to be a nativesdk target.
> 
> Is there not a way to make this optional by editing the configure.ac and adding a switch?  What functionality to we gain or loose with / without the ext2fs extensions?

I really have no idea, I just had the above buildfailure yesterday.

regards,

Koen
Paul Eggleton - May 6, 2014, 9:17 a.m.
On Tuesday 06 May 2014 07:52:23 Koen Kooi wrote:
> Op 5 mei 2014, om 23:54 heeft Saul Wold <sgw@linux.intel.com> het volgende 
geschreven:
> > On 05/05/2014 04:26 AM, Koen Kooi wrote:
> >> This fixes the following build error:
> >> 	| libarchive/archive_entry.c:59:55: fatal error: ext2fs/ext2_fs.h: No
> >> 	| such file or directory>> 
> >> There is no configure options to avoid this dependency.
> >> 
> >> Signed-off-by: Koen Kooi <koen.kooi@linaro.org>
> >> ---
> >> 
> >>  meta/recipes-extended/libarchive/libarchive_3.1.2.bb | 2 ++
> >>  1 file changed, 2 insertions(+)
> >> 
> >> diff --git a/meta/recipes-extended/libarchive/libarchive_3.1.2.bb
> >> b/meta/recipes-extended/libarchive/libarchive_3.1.2.bb index
> >> eedbaa7..277d8c8 100644
> >> --- a/meta/recipes-extended/libarchive/libarchive_3.1.2.bb
> >> +++ b/meta/recipes-extended/libarchive/libarchive_3.1.2.bb
> >> @@ -5,6 +5,8 @@ SECTION = "devel"
> >> 
> >>  LICENSE = "BSD"
> >>  LIC_FILES_CHKSUM = "file://COPYING;md5=b4e3ffd607d6686c6cb2f63394370841"
> >> 
> >> +DEPENDS = "e2fsprogs"
> >> +
> > 
> > By doing this we also have to extend e2fprogs to be a nativesdk target.
> > 
> > Is there not a way to make this optional by editing the configure.ac and
> > adding a switch?  What functionality to we gain or loose with / without
> > the ext2fs extensions?
>
> I really have no idea, I just had the above buildfailure yesterday.

FYI this is a bug I was meant to be fixing in the 1.6 cycle (I noticed the 
error in one of my builds a few months ago). Simply adding e2fsprogs to 
DEPENDS adds time to the build, plus when I submitted a patch to do this I 
found that nativesdk-e2fsprogs doesn't actually build at the moment and since 
it's actually only the header it wants, I had in mind to just use the header 
from e2fsprogs-native. I haven't got around to testing the latter solution 
though.

Anyway, I've now done what I should have done earlier and filed a bug:


Cheers,
Paul
Paul Eggleton - May 6, 2014, 9:18 a.m.
On Tuesday 06 May 2014 10:17:03 Paul Eggleton wrote:
> On Tuesday 06 May 2014 07:52:23 Koen Kooi wrote:
> > Op 5 mei 2014, om 23:54 heeft Saul Wold <sgw@linux.intel.com> het volgende
> 
> geschreven:
> > > On 05/05/2014 04:26 AM, Koen Kooi wrote:
> > >> This fixes the following build error:
> > >> 	| libarchive/archive_entry.c:59:55: fatal error: ext2fs/ext2_fs.h: No
> > >> 	| such file or directory>>
> > >> 
> > >> There is no configure options to avoid this dependency.
> > >> 
> > >> Signed-off-by: Koen Kooi <koen.kooi@linaro.org>
> > >> ---
> > >> 
> > >>  meta/recipes-extended/libarchive/libarchive_3.1.2.bb | 2 ++
> > >>  1 file changed, 2 insertions(+)
> > >> 
> > >> diff --git a/meta/recipes-extended/libarchive/libarchive_3.1.2.bb
> > >> b/meta/recipes-extended/libarchive/libarchive_3.1.2.bb index
> > >> eedbaa7..277d8c8 100644
> > >> --- a/meta/recipes-extended/libarchive/libarchive_3.1.2.bb
> > >> +++ b/meta/recipes-extended/libarchive/libarchive_3.1.2.bb
> > >> @@ -5,6 +5,8 @@ SECTION = "devel"
> > >> 
> > >>  LICENSE = "BSD"
> > >>  LIC_FILES_CHKSUM =
> > >>  "file://COPYING;md5=b4e3ffd607d6686c6cb2f63394370841"
> > >> 
> > >> +DEPENDS = "e2fsprogs"
> > >> +
> > > 
> > > By doing this we also have to extend e2fprogs to be a nativesdk target.
> > > 
> > > Is there not a way to make this optional by editing the configure.ac and
> > > adding a switch?  What functionality to we gain or loose with / without
> > > the ext2fs extensions?
> > 
> > I really have no idea, I just had the above buildfailure yesterday.
> 
> FYI this is a bug I was meant to be fixing in the 1.6 cycle (I noticed the
> error in one of my builds a few months ago). Simply adding e2fsprogs to
> DEPENDS adds time to the build, plus when I submitted a patch to do this I
> found that nativesdk-e2fsprogs doesn't actually build at the moment and
> since it's actually only the header it wants, I had in mind to just use the
> header from e2fsprogs-native. I haven't got around to testing the latter
> solution though.
> 
> Anyway, I've now done what I should have done earlier and filed a bug:

Oops, sent too early - bug link:

https://bugzilla.yoctoproject.org/show_bug.cgi?id=6268

Cheers,
Paul
Paul Barker - May 6, 2014, 10:33 a.m.
On Tue, May 06, 2014 at 10:18:41AM +0100, Paul Eggleton wrote:
> On Tuesday 06 May 2014 10:17:03 Paul Eggleton wrote:
> > On Tuesday 06 May 2014 07:52:23 Koen Kooi wrote:
> > > Op 5 mei 2014, om 23:54 heeft Saul Wold <sgw@linux.intel.com> het volgende
> > 
> > geschreven:
> > > > On 05/05/2014 04:26 AM, Koen Kooi wrote:
> > > >> This fixes the following build error:
> > > >> 	| libarchive/archive_entry.c:59:55: fatal error: ext2fs/ext2_fs.h: No
> > > >> 	| such file or directory>>
> > > >> 
> > > >> There is no configure options to avoid this dependency.
> > > >> 
> > > >> Signed-off-by: Koen Kooi <koen.kooi@linaro.org>
> > > >> ---
> > > >> 
> > > >>  meta/recipes-extended/libarchive/libarchive_3.1.2.bb | 2 ++
> > > >>  1 file changed, 2 insertions(+)
> > > >> 
> > > >> diff --git a/meta/recipes-extended/libarchive/libarchive_3.1.2.bb
> > > >> b/meta/recipes-extended/libarchive/libarchive_3.1.2.bb index
> > > >> eedbaa7..277d8c8 100644
> > > >> --- a/meta/recipes-extended/libarchive/libarchive_3.1.2.bb
> > > >> +++ b/meta/recipes-extended/libarchive/libarchive_3.1.2.bb
> > > >> @@ -5,6 +5,8 @@ SECTION = "devel"
> > > >> 
> > > >>  LICENSE = "BSD"
> > > >>  LIC_FILES_CHKSUM =
> > > >>  "file://COPYING;md5=b4e3ffd607d6686c6cb2f63394370841"
> > > >> 
> > > >> +DEPENDS = "e2fsprogs"
> > > >> +
> > > > 
> > > > By doing this we also have to extend e2fprogs to be a nativesdk target.
> > > > 
> > > > Is there not a way to make this optional by editing the configure.ac and
> > > > adding a switch?  What functionality to we gain or loose with / without
> > > > the ext2fs extensions?
> > > 
> > > I really have no idea, I just had the above buildfailure yesterday.
> > 
> > FYI this is a bug I was meant to be fixing in the 1.6 cycle (I noticed the
> > error in one of my builds a few months ago). Simply adding e2fsprogs to
> > DEPENDS adds time to the build, plus when I submitted a patch to do this I
> > found that nativesdk-e2fsprogs doesn't actually build at the moment and
> > since it's actually only the header it wants, I had in mind to just use the
> > header from e2fsprogs-native. I haven't got around to testing the latter
> > solution though.
> > 
> > Anyway, I've now done what I should have done earlier and filed a bug:
> 
> Oops, sent too early - bug link:
> 
> https://bugzilla.yoctoproject.org/show_bug.cgi?id=6268
> 
> Cheers,
> Paul
> 

I just had a quick look at this as I've done a bit of work with libarchive. It
looks like as long as the header isn't found at configure time there's no
problem at compile time. Could we work around this by modifying config.h in a
do_configure_append() function to undefine the relevant symbol
(HAVE_EXT2FS_EXT2_FS_H)?

Thanks,
Paul Eggleton - May 6, 2014, 10:39 a.m.
On Tuesday 06 May 2014 10:33:29 Paul Barker wrote:
> On Tue, May 06, 2014 at 10:18:41AM +0100, Paul Eggleton wrote:
> > On Tuesday 06 May 2014 10:17:03 Paul Eggleton wrote:
> > > On Tuesday 06 May 2014 07:52:23 Koen Kooi wrote:
> > > > Op 5 mei 2014, om 23:54 heeft Saul Wold <sgw@linux.intel.com> het
> > > > volgende
> > > 
> > > geschreven:
> > > > > On 05/05/2014 04:26 AM, Koen Kooi wrote:
> > > > >> This fixes the following build error:
> > > > >> 	| libarchive/archive_entry.c:59:55: fatal error: 
ext2fs/ext2_fs.h:
> > > > >> 	| No
> > > > >> 	| such file or directory>>
> > > > >> 
> > > > >> There is no configure options to avoid this dependency.
> > > > >> 
> > > > >> Signed-off-by: Koen Kooi <koen.kooi@linaro.org>
> > > > >> ---
> > > > >> 
> > > > >>  meta/recipes-extended/libarchive/libarchive_3.1.2.bb | 2 ++
> > > > >>  1 file changed, 2 insertions(+)
> > > > >> 
> > > > >> diff --git a/meta/recipes-extended/libarchive/libarchive_3.1.2.bb
> > > > >> b/meta/recipes-extended/libarchive/libarchive_3.1.2.bb index
> > > > >> eedbaa7..277d8c8 100644
> > > > >> --- a/meta/recipes-extended/libarchive/libarchive_3.1.2.bb
> > > > >> +++ b/meta/recipes-extended/libarchive/libarchive_3.1.2.bb
> > > > >> @@ -5,6 +5,8 @@ SECTION = "devel"
> > > > >> 
> > > > >>  LICENSE = "BSD"
> > > > >>  LIC_FILES_CHKSUM =
> > > > >>  "file://COPYING;md5=b4e3ffd607d6686c6cb2f63394370841"
> > > > >> 
> > > > >> +DEPENDS = "e2fsprogs"
> > > > >> +
> > > > > 
> > > > > By doing this we also have to extend e2fprogs to be a nativesdk
> > > > > target.
> > > > > 
> > > > > Is there not a way to make this optional by editing the configure.ac
> > > > > and
> > > > > adding a switch?  What functionality to we gain or loose with /
> > > > > without
> > > > > the ext2fs extensions?
> > > > 
> > > > I really have no idea, I just had the above buildfailure yesterday.
> > > 
> > > FYI this is a bug I was meant to be fixing in the 1.6 cycle (I noticed
> > > the
> > > error in one of my builds a few months ago). Simply adding e2fsprogs to
> > > DEPENDS adds time to the build, plus when I submitted a patch to do this
> > > I
> > > found that nativesdk-e2fsprogs doesn't actually build at the moment and
> > > since it's actually only the header it wants, I had in mind to just use
> > > the
> > > header from e2fsprogs-native. I haven't got around to testing the latter
> > > solution though.
> > 
> > > Anyway, I've now done what I should have done earlier and filed a bug:
> > Oops, sent too early - bug link:
> > 
> > https://bugzilla.yoctoproject.org/show_bug.cgi?id=6268
> > 
> > Cheers,
> > Paul
> 
> I just had a quick look at this as I've done a bit of work with libarchive.
> It looks like as long as the header isn't found at configure time there's
> no problem at compile time. Could we work around this by modifying config.h
> in a do_configure_append() function to undefine the relevant symbol
> (HAVE_EXT2FS_EXT2_FS_H)?

That's another solution, but then you lose the functionality it needs the 
header to support. While this was an appropriate fix for cmake's internal 
libarchive copy in the native case, I wasn't sure it was appropriate for 
libarchive on the target since we can't be as sure about what people want to 
use it for.

Cheers,
Paul
Khem Raj - May 6, 2014, 6:25 p.m.
On Tue, May 6, 2014 at 3:33 AM, Paul Barker <paul@paulbarker.me.uk> wrote:
> On Tue, May 06, 2014 at 10:18:41AM +0100, Paul Eggleton wrote:
>> On Tuesday 06 May 2014 10:17:03 Paul Eggleton wrote:
>> > On Tuesday 06 May 2014 07:52:23 Koen Kooi wrote:
>> > > Op 5 mei 2014, om 23:54 heeft Saul Wold <sgw@linux.intel.com> het volgende
>> >
>> > geschreven:
>> > > > On 05/05/2014 04:26 AM, Koen Kooi wrote:
>> > > >> This fixes the following build error:
>> > > >>        | libarchive/archive_entry.c:59:55: fatal error: ext2fs/ext2_fs.h: No
>> > > >>        | such file or directory>>
>> > > >>
>> > > >> There is no configure options to avoid this dependency.
>> > > >>
>> > > >> Signed-off-by: Koen Kooi <koen.kooi@linaro.org>
>> > > >> ---
>> > > >>
>> > > >>  meta/recipes-extended/libarchive/libarchive_3.1.2.bb | 2 ++
>> > > >>  1 file changed, 2 insertions(+)
>> > > >>
>> > > >> diff --git a/meta/recipes-extended/libarchive/libarchive_3.1.2.bb
>> > > >> b/meta/recipes-extended/libarchive/libarchive_3.1.2.bb index
>> > > >> eedbaa7..277d8c8 100644
>> > > >> --- a/meta/recipes-extended/libarchive/libarchive_3.1.2.bb
>> > > >> +++ b/meta/recipes-extended/libarchive/libarchive_3.1.2.bb
>> > > >> @@ -5,6 +5,8 @@ SECTION = "devel"
>> > > >>
>> > > >>  LICENSE = "BSD"
>> > > >>  LIC_FILES_CHKSUM =
>> > > >>  "file://COPYING;md5=b4e3ffd607d6686c6cb2f63394370841"
>> > > >>
>> > > >> +DEPENDS = "e2fsprogs"
>> > > >> +
>> > > >
>> > > > By doing this we also have to extend e2fprogs to be a nativesdk target.
>> > > >
>> > > > Is there not a way to make this optional by editing the configure.ac and
>> > > > adding a switch?  What functionality to we gain or loose with / without
>> > > > the ext2fs extensions?
>> > >
>> > > I really have no idea, I just had the above buildfailure yesterday.
>> >
>> > FYI this is a bug I was meant to be fixing in the 1.6 cycle (I noticed the
>> > error in one of my builds a few months ago). Simply adding e2fsprogs to
>> > DEPENDS adds time to the build, plus when I submitted a patch to do this I
>> > found that nativesdk-e2fsprogs doesn't actually build at the moment and
>> > since it's actually only the header it wants, I had in mind to just use the
>> > header from e2fsprogs-native. I haven't got around to testing the latter
>> > solution though.
>> >
>> > Anyway, I've now done what I should have done earlier and filed a bug:
>>
>> Oops, sent too early - bug link:
>>
>> https://bugzilla.yoctoproject.org/show_bug.cgi?id=6268
>>
>> Cheers,
>> Paul
>>
>
> I just had a quick look at this as I've done a bit of work with libarchive. It
> looks like as long as the header isn't found at configure time there's no
> problem at compile time. Could we work around this by modifying config.h in a
> do_configure_append() function to undefine the relevant symbol
> (HAVE_EXT2FS_EXT2_FS_H)?

It can be disabled in many ways and easiest is to cache the autconf
variable and set it to 'no'
but we loose The EXT2 ioctls that are used on Linux to get/set file
flags since our build systems
are mostly linux I would think this is a good thing to enable in libarchive.
Paul Barker - May 6, 2014, 10:57 p.m.
On Tue, May 06, 2014 at 11:25:31AM -0700, Khem Raj wrote:
> On Tue, May 6, 2014 at 3:33 AM, Paul Barker <paul@paulbarker.me.uk> wrote:
> > On Tue, May 06, 2014 at 10:18:41AM +0100, Paul Eggleton wrote:
> >>
> >> Oops, sent too early - bug link:
> >>
> >> https://bugzilla.yoctoproject.org/show_bug.cgi?id=6268
> >>
> >> Cheers,
> >> Paul
> >>
> >
> > I just had a quick look at this as I've done a bit of work with libarchive. It
> > looks like as long as the header isn't found at configure time there's no
> > problem at compile time. Could we work around this by modifying config.h in a
> > do_configure_append() function to undefine the relevant symbol
> > (HAVE_EXT2FS_EXT2_FS_H)?
> 
> It can be disabled in many ways and easiest is to cache the autconf
> variable and set it to 'no'
> but we loose The EXT2 ioctls that are used on Linux to get/set file
> flags since our build systems
> are mostly linux I would think this is a good thing to enable in libarchive.

Yea that makes a lot more sense. I was in effect replying to the bug report
saying "There is no way to hard-disable this dependency.".

Sounds like it's worth using that header if possible though so ignore my
comment.

Cheers,

Patch

diff --git a/meta/recipes-extended/libarchive/libarchive_3.1.2.bb b/meta/recipes-extended/libarchive/libarchive_3.1.2.bb
index eedbaa7..277d8c8 100644
--- a/meta/recipes-extended/libarchive/libarchive_3.1.2.bb
+++ b/meta/recipes-extended/libarchive/libarchive_3.1.2.bb
@@ -5,6 +5,8 @@  SECTION = "devel"
 LICENSE = "BSD"
 LIC_FILES_CHKSUM = "file://COPYING;md5=b4e3ffd607d6686c6cb2f63394370841"
 
+DEPENDS = "e2fsprogs"
+
 PACKAGECONFIG ?= "libxml2 zlib bz2"
 
 PACKAGECONFIG_append_class-target = "\