Patchwork [meta-fsl-arm-extra,V2] nitrogen6x: Add support for i.MX6SDL CPU variants to SOC_FAMILY

login
register
mail settings
Submitter Eric Nelson
Date May 4, 2014, 2:09 p.m.
Message ID <1399212550-6165-1-git-send-email-eric.nelson@boundarydevices.com>
Download mbox | patch
Permalink /patch/71459/
State Changes Requested
Delegated to: Otavio Salvador
Headers show

Comments

Eric Nelson - May 4, 2014, 2:09 p.m.
The Nitrogen6x has options for i.MX6DL and i.MX6S, and
without mx6dl in the SOC_FAMILY, Dual-Lite/Solo features
of other components won't be built.

The problem triggering this patch is the firmware-imx package,
which will not install the Dual-Lite/Solo firmware for the
VPU (lib/firmware/vpu_fw_imx6d.bin).

Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
---
V2 updates the Subject line to include [meta-fsl-arm].
V3 updates the Subject line to include [meta-fsl-arm-extra]
   and proves that I should never submit patches before at
   least two cups of coffee and 15 minutes to allow absorption.

 conf/machine/nitrogen6x.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Gary Thomas - May 4, 2014, 2:15 p.m.
On 2014-05-04 08:09, Eric Nelson wrote:
> The Nitrogen6x has options for i.MX6DL and i.MX6S, and
> without mx6dl in the SOC_FAMILY, Dual-Lite/Solo features
> of other components won't be built.
>
> The problem triggering this patch is the firmware-imx package,
> which will not install the Dual-Lite/Solo firmware for the
> VPU (lib/firmware/vpu_fw_imx6d.bin).
>
> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
> ---
> V2 updates the Subject line to include [meta-fsl-arm].
> V3 updates the Subject line to include [meta-fsl-arm-extra]
>     and proves that I should never submit patches before at
>     least two cups of coffee and 15 minutes to allow absorption.
>
>   conf/machine/nitrogen6x.conf | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/conf/machine/nitrogen6x.conf b/conf/machine/nitrogen6x.conf
> index 868d287..3a3707e 100644
> --- a/conf/machine/nitrogen6x.conf
> +++ b/conf/machine/nitrogen6x.conf
> @@ -31,7 +31,7 @@
>   include conf/machine/include/imx-base.inc
>   include conf/machine/include/tune-cortexa9.inc
>
> -SOC_FAMILY = "mx6:mx6q"
> +SOC_FAMILY = "mx6::mx6dl:mx6q"

I also think that :: is [benignly] incorrect since this is just a list
of colon separated machine/SOC variants.  It would also be incorrect in
at least this one other file:
   meta-fsl-arm-extra/conf/machine/cubox-i.conf:SOC_FAMILY = "mx6::mx6dl:mx6q"

>
>   KERNEL_DEVICETREE = "imx6q-sabrelite.dtb imx6q-nitrogen6x.dtb imx6dl-nitrogen6x.dtb"
>
>
Eric BENARD - May 4, 2014, 2:56 p.m.
Le Sun, 04 May 2014 08:15:21 -0600,
Gary Thomas <gary@mlbassoc.com> a écrit :

> 
> On 2014-05-04 08:09, Eric Nelson wrote:
> > The Nitrogen6x has options for i.MX6DL and i.MX6S, and
> > without mx6dl in the SOC_FAMILY, Dual-Lite/Solo features
> > of other components won't be built.
> >
> > The problem triggering this patch is the firmware-imx package,
> > which will not install the Dual-Lite/Solo firmware for the
> > VPU (lib/firmware/vpu_fw_imx6d.bin).
> >
> > Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
> > ---
> > V2 updates the Subject line to include [meta-fsl-arm].
> > V3 updates the Subject line to include [meta-fsl-arm-extra]
> >     and proves that I should never submit patches before at
> >     least two cups of coffee and 15 minutes to allow absorption.
> >
> >   conf/machine/nitrogen6x.conf | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/conf/machine/nitrogen6x.conf b/conf/machine/nitrogen6x.conf
> > index 868d287..3a3707e 100644
> > --- a/conf/machine/nitrogen6x.conf
> > +++ b/conf/machine/nitrogen6x.conf
> > @@ -31,7 +31,7 @@
> >   include conf/machine/include/imx-base.inc
> >   include conf/machine/include/tune-cortexa9.inc
> >
> > -SOC_FAMILY = "mx6:mx6q"
> > +SOC_FAMILY = "mx6::mx6dl:mx6q"
> 
> I also think that :: is [benignly] incorrect since this is just a list
> of colon separated machine/SOC variants.  It would also be incorrect in
> at least this one other file:
>    meta-fsl-arm-extra/conf/machine/cubox-i.conf:SOC_FAMILY = "mx6::mx6dl:mx6q"
> 
this seems to be a sed effect.

Eric

Patch

diff --git a/conf/machine/nitrogen6x.conf b/conf/machine/nitrogen6x.conf
index 868d287..3a3707e 100644
--- a/conf/machine/nitrogen6x.conf
+++ b/conf/machine/nitrogen6x.conf
@@ -31,7 +31,7 @@ 
 include conf/machine/include/imx-base.inc
 include conf/machine/include/tune-cortexa9.inc
 
-SOC_FAMILY = "mx6:mx6q"
+SOC_FAMILY = "mx6::mx6dl:mx6q"
 
 KERNEL_DEVICETREE = "imx6q-sabrelite.dtb imx6q-nitrogen6x.dtb imx6dl-nitrogen6x.dtb"