Patchwork [meta-oe,PATCHv2,4/4] start-stop-daemon: Add version 1.16.0.2 (initial recipe)

login
register
mail settings
Submitter Michael Lippautz
Date July 7, 2011, 1:36 p.m.
Message ID <52d3dbb81758055099740c437667671b45974a2d.1310045515.git.michael.lippautz@gmail.com>
Download mbox | patch
Permalink /patch/7139/
State Accepted
Commit f7aff2a3a0c99564f34a528f124ae4e013a5a878
Headers show

Comments

Michael Lippautz - July 7, 2011, 1:36 p.m.
Provides a stand-lone s-s-d that is extracted from dpkg of the corresponding
version.

* dpkg_1.16.0.2 is hostedd on sources.oe.org, since debian wipes old versions
  from their mirrors
* Installing only s-s-d (binary) would be covered by automake rules.
  Documentation would be missing. Thus install all and purge non s-s-d files.

Signed-off-by: Michael Lippautz <michael.lippautz@gmail.com>
---
 .../start-stop-daemon_1.16.0.2.bb                  |   31 ++++++++++++++++++++
 1 files changed, 31 insertions(+), 0 deletions(-)
 create mode 100644 meta-oe/recipes-support/start-stop-daemon/start-stop-daemon_1.16.0.2.bb
Paul Menzel - July 7, 2011, 5:44 p.m.
Am Donnerstag, den 07.07.2011, 15:36 +0200 schrieb Michael Lippautz:
> Provides a stand-lone s-s-d that is extracted from dpkg of the corresponding
> version.
> 
> * dpkg_1.16.0.2 is hostedd on sources.oe.org, since debian wipes old versions
>   from their mirrors
> * Installing only s-s-d (binary) would be covered by automake rules.
>   Documentation would be missing. Thus install all and purge non s-s-d files.
> 
> Signed-off-by: Michael Lippautz <michael.lippautz@gmail.com>
> ---
>  .../start-stop-daemon_1.16.0.2.bb                  |   31 ++++++++++++++++++++
>  1 files changed, 31 insertions(+), 0 deletions(-)
>  create mode 100644 meta-oe/recipes-support/start-stop-daemon/start-stop-daemon_1.16.0.2.bb
> 
> diff --git a/meta-oe/recipes-support/start-stop-daemon/start-stop-daemon_1.16.0.2.bb b/meta-oe/recipes-support/start-stop-daemon/start-stop-daemon_1.16.0.2.bb
> new file mode 100644
> index 0000000..9b1084a
> --- /dev/null
> +++ b/meta-oe/recipes-support/start-stop-daemon/start-stop-daemon_1.16.0.2.bb
> @@ -0,0 +1,31 @@
> +DESCRIPTION = "Debian's start-stop-daemon utility extracted from the dpkg \
> +package"
> +LICENSE = "PD"
> +LIC_FILES_CHKSUM = "file://utils/start-stop-daemon.c;md5=a963623e4588f70122865aaa7a370ce4"
> +# start-stop-daemon is usually shipped by dpkg
> +RCONFLICS_${PN} = "dpkg" 

Trailing whitespace again.

> +PR = "r0"
> +
> +SRC_URI = "http://sources.openembedded.org/dpkg_${PV}.tar.bz2"
> +SRC_URI[md5sum] = "d211a84f38987771a49ad1c0f144334a"
> +SRC_URI[sha256sum] = "2a3d4ba83c743b3f004533fdd52372cb7b22f5c1da2042d0a31bbcc2b54c0ea5"
> +
> +inherit autotools gettext
> +
> +S = "${WORKDIR}/dpkg-${PV}"
> +
> +EXTRA_OECONF = " \
> +  --with-start-stop-daemon \
> +  --without-bz2 \
> +  --without-deselect \
> +  --without-install-info \
> +  --without-selinux \
> +  --without-update-alternatives \
> +"
> +
> +do_install_append () {
> +  # remove everything that is not related to start-stop-daemon, since there
> +  # is no explicit rule for only installing ssd
> +  find ${D} -type f -not -name "*start-stop-daemon*" -exec rm {} \;
> +  find ${D} -depth -type d -empty -exec rmdir {} \;
> +}

Just looking at the recipe, the recipe in oe-dev [1] seems to do this
differently and calls `update-alternatives` too. Is that not needed
anymore and is copying the C file to the repository not working anymore?


Thanks,

Paul


[1] http://cgit.openembedded.org/cgit.cgi/openembedded/tree/recipes/start-stop-daemon/start-stop-daemon_1.9.18.bb?id=529b445f1122e3d0de7acff980fa0af114368157
Paul Menzel - July 7, 2011, 6:12 p.m.
Am Donnerstag, den 07.07.2011, 19:44 +0200 schrieb Paul Menzel:
> Am Donnerstag, den 07.07.2011, 15:36 +0200 schrieb Michael Lippautz:
> > Provides a stand-lone s-s-d that is extracted from dpkg of the corresponding
> > version.
> > 
> > * dpkg_1.16.0.2 is hostedd on sources.oe.org, since debian wipes old versions
> >   from their mirrors
> > * Installing only s-s-d (binary) would be covered by automake rules.
> >   Documentation would be missing. Thus install all and purge non s-s-d files.
> > 
> > Signed-off-by: Michael Lippautz <michael.lippautz@gmail.com>
> > ---
> >  .../start-stop-daemon_1.16.0.2.bb                  |   31 ++++++++++++++++++++
> >  1 files changed, 31 insertions(+), 0 deletions(-)
> >  create mode 100644 meta-oe/recipes-support/start-stop-daemon/start-stop-daemon_1.16.0.2.bb
> > 
> > diff --git a/meta-oe/recipes-support/start-stop-daemon/start-stop-daemon_1.16.0.2.bb b/meta-oe/recipes-support/start-stop-daemon/start-stop-daemon_1.16.0.2.bb
> > new file mode 100644
> > index 0000000..9b1084a
> > --- /dev/null
> > +++ b/meta-oe/recipes-support/start-stop-daemon/start-stop-daemon_1.16.0.2.bb
> > @@ -0,0 +1,31 @@
> > +DESCRIPTION = "Debian's start-stop-daemon utility extracted from the dpkg \
> > +package"
> > +LICENSE = "PD"
> > +LIC_FILES_CHKSUM = "file://utils/start-stop-daemon.c;md5=a963623e4588f70122865aaa7a370ce4"
> > +# start-stop-daemon is usually shipped by dpkg
> > +RCONFLICS_${PN} = "dpkg" 
> 
> Trailing whitespace again.
> 
> > +PR = "r0"
> > +
> > +SRC_URI = "http://sources.openembedded.org/dpkg_${PV}.tar.bz2"
> > +SRC_URI[md5sum] = "d211a84f38987771a49ad1c0f144334a"
> > +SRC_URI[sha256sum] = "2a3d4ba83c743b3f004533fdd52372cb7b22f5c1da2042d0a31bbcc2b54c0ea5"
> > +
> > +inherit autotools gettext
> > +
> > +S = "${WORKDIR}/dpkg-${PV}"
> > +
> > +EXTRA_OECONF = " \
> > +  --with-start-stop-daemon \
> > +  --without-bz2 \
> > +  --without-deselect \
> > +  --without-install-info \
> > +  --without-selinux \
> > +  --without-update-alternatives \
> > +"
> > +
> > +do_install_append () {
> > +  # remove everything that is not related to start-stop-daemon, since there
> > +  # is no explicit rule for only installing ssd
> > +  find ${D} -type f -not -name "*start-stop-daemon*" -exec rm {} \;
> > +  find ${D} -depth -type d -empty -exec rmdir {} \;
> > +}
> 
> Just looking at the recipe, the recipe in oe-dev [1] seems to do this
> differently and calls `update-alternatives` too. Is that not needed
> anymore and is copying the C file to the repository not working anymore?

I ported your patch to oe-dev and using `minimal-uclibc` it fails with
the following error.

        statcmd.c:369:2: warning: statement with no effect
        querycmd.c: In function 'main':
        querycmd.c:683:3: warning: statement with no effect
        querycmd.c:684:3: warning: statement with no effect
          CCLD   dpkg
          CCLD   dpkg-divert
          CCLD   dpkg-trigger
        archives.o: In function `fd_writeback_init':
        /oe/build-minimal-uclibc/minimal-uclibc-dev/work/armv7a-oe-linux-uclibceabi/start-stop-daemon-1.16.0.2-r0/dpkg-1.16.0.2/src/archives.c:73: undefined reference to `sync_file_range'
        archives.o: In function `tar_writeback_barrier':
        /oe/build-minimal-uclibc/minimal-uclibc-dev/work/armv7a-oe-linux-uclibceabi/  CCLD   dpkg-statoverride
        start-stop-daemon-1.16.0.2-r0/dpkg-1.16.0.2/src/archives.c:894: undefined reference to `sync_file_range'
        collect2: ld returned 1 exit status
        make[2]: *** [dpkg] Error 1

Building `start-stop-daemon-1.9.18-r1` works fine.


Thanks,

Paul


> [1] http://cgit.openembedded.org/cgit.cgi/openembedded/tree/recipes/start-stop-daemon/start-stop-daemon_1.9.18.bb?id=529b445f1122e3d0de7acff980fa0af114368157
Michael Lippautz - July 8, 2011, 10:04 a.m.
2011/7/7 Paul Menzel <paulepanter@users.sourceforge.net>:
> Am Donnerstag, den 07.07.2011, 15:36 +0200 schrieb Michael Lippautz:
>> Provides a stand-lone s-s-d that is extracted from dpkg of the corresponding
>> version.
>>
>> * dpkg_1.16.0.2 is hostedd on sources.oe.org, since debian wipes old versions
>>   from their mirrors
>> * Installing only s-s-d (binary) would be covered by automake rules.
>>   Documentation would be missing. Thus install all and purge non s-s-d files.
>>
>> Signed-off-by: Michael Lippautz <michael.lippautz@gmail.com>
>> ---
>>  .../start-stop-daemon_1.16.0.2.bb                  |   31 ++++++++++++++++++++
>>  1 files changed, 31 insertions(+), 0 deletions(-)
>>  create mode 100644 meta-oe/recipes-support/start-stop-daemon/start-stop-daemon_1.16.0.2.bb
>>
>> diff --git a/meta-oe/recipes-support/start-stop-daemon/start-stop-daemon_1.16.0.2.bb b/meta-oe/recipes-support/start-stop-daemon/start-stop-daemon_1.16.0.2.bb
>> new file mode 100644
>> index 0000000..9b1084a
>> --- /dev/null
>> +++ b/meta-oe/recipes-support/start-stop-daemon/start-stop-daemon_1.16.0.2.bb
>> @@ -0,0 +1,31 @@
>> +DESCRIPTION = "Debian's start-stop-daemon utility extracted from the dpkg \
>> +package"
>> +LICENSE = "PD"
>> +LIC_FILES_CHKSUM = "file://utils/start-stop-daemon.c;md5=a963623e4588f70122865aaa7a370ce4"
>> +# start-stop-daemon is usually shipped by dpkg
>> +RCONFLICS_${PN} = "dpkg"
>
> Trailing whitespace again.
>
>> +PR = "r0"
>> +
>> +SRC_URI = "http://sources.openembedded.org/dpkg_${PV}.tar.bz2"
>> +SRC_URI[md5sum] = "d211a84f38987771a49ad1c0f144334a"
>> +SRC_URI[sha256sum] = "2a3d4ba83c743b3f004533fdd52372cb7b22f5c1da2042d0a31bbcc2b54c0ea5"
>> +
>> +inherit autotools gettext
>> +
>> +S = "${WORKDIR}/dpkg-${PV}"
>> +
>> +EXTRA_OECONF = " \
>> +  --with-start-stop-daemon \
>> +  --without-bz2 \
>> +  --without-deselect \
>> +  --without-install-info \
>> +  --without-selinux \
>> +  --without-update-alternatives \
>> +"
>> +
>> +do_install_append () {
>> +  # remove everything that is not related to start-stop-daemon, since there
>> +  # is no explicit rule for only installing ssd
>> +  find ${D} -type f -not -name "*start-stop-daemon*" -exec rm {} \;
>> +  find ${D} -depth -type d -empty -exec rmdir {} \;
>> +}
>
> Just looking at the recipe, the recipe in oe-dev [1] seems to do this
> differently and calls `update-alternatives` too. Is that not needed
> anymore and is copying the C file to the repository not working anymore?
>

Well, I (personally) rather take the files from a quite up-to-date
package from a mature distribution, instead of using a C file that has
been comitted 2010-03-30. It also saves (not much but atleast) some
space in the tree.

I can't think of why one would use update-alternatives here, because I
know only one s-s-d and thats the one from Debian's dpkg. Am I wrong
here?

>
> Thanks,
>
> Paul
>
>
> [1] http://cgit.openembedded.org/cgit.cgi/openembedded/tree/recipes/start-stop-daemon/start-stop-daemon_1.9.18.bb?id=529b445f1122e3d0de7acff980fa0af114368157
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>
>

Patch

diff --git a/meta-oe/recipes-support/start-stop-daemon/start-stop-daemon_1.16.0.2.bb b/meta-oe/recipes-support/start-stop-daemon/start-stop-daemon_1.16.0.2.bb
new file mode 100644
index 0000000..9b1084a
--- /dev/null
+++ b/meta-oe/recipes-support/start-stop-daemon/start-stop-daemon_1.16.0.2.bb
@@ -0,0 +1,31 @@ 
+DESCRIPTION = "Debian's start-stop-daemon utility extracted from the dpkg \
+package"
+LICENSE = "PD"
+LIC_FILES_CHKSUM = "file://utils/start-stop-daemon.c;md5=a963623e4588f70122865aaa7a370ce4"
+# start-stop-daemon is usually shipped by dpkg
+RCONFLICS_${PN} = "dpkg" 
+PR = "r0"
+
+SRC_URI = "http://sources.openembedded.org/dpkg_${PV}.tar.bz2"
+SRC_URI[md5sum] = "d211a84f38987771a49ad1c0f144334a"
+SRC_URI[sha256sum] = "2a3d4ba83c743b3f004533fdd52372cb7b22f5c1da2042d0a31bbcc2b54c0ea5"
+
+inherit autotools gettext
+
+S = "${WORKDIR}/dpkg-${PV}"
+
+EXTRA_OECONF = " \
+  --with-start-stop-daemon \
+  --without-bz2 \
+  --without-deselect \
+  --without-install-info \
+  --without-selinux \
+  --without-update-alternatives \
+"
+
+do_install_append () {
+  # remove everything that is not related to start-stop-daemon, since there
+  # is no explicit rule for only installing ssd
+  find ${D} -type f -not -name "*start-stop-daemon*" -exec rm {} \;
+  find ${D} -depth -type d -empty -exec rmdir {} \;
+}