Patchwork [1/3] nettle: add nettle to poky

login
register
mail settings
Submitter Valentin Popa
Date April 30, 2014, 3:39 p.m.
Message ID <cff8f1a8914290689c411c19e78f7118036eda9c.1398871949.git.valentin.popa@intel.com>
Download mbox | patch
Permalink /patch/71331/
State New
Headers show

Comments

Valentin Popa - April 30, 2014, 3:39 p.m.
Newer versions of gnutls depends on nettle.

Signed-off-by: Valentin Popa <valentin.popa@intel.com>
---
 meta/recipes-support/nettle/nettle_2.7.1.bb | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
 create mode 100644 meta/recipes-support/nettle/nettle_2.7.1.bb
Paul Eggleton - May 1, 2014, 11:34 a.m.
Hi Valentin,

On Wednesday 30 April 2014 18:39:31 Valentin Popa wrote:
> Newer versions of gnutls depends on nettle.
> 
> Signed-off-by: Valentin Popa <valentin.popa@intel.com>
> ---
>  meta/recipes-support/nettle/nettle_2.7.1.bb | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
>  create mode 100644 meta/recipes-support/nettle/nettle_2.7.1.bb
> 
> diff --git a/meta/recipes-support/nettle/nettle_2.7.1.bb
> b/meta/recipes-support/nettle/nettle_2.7.1.bb new file mode 100644
> index 0000000..eb7c9de
> --- /dev/null
> +++ b/meta/recipes-support/nettle/nettle_2.7.1.bb
> @@ -0,0 +1,22 @@
> +DESCRIPTION = "A low level cryptographic library"

Since this value is short, could you please set it as SUMMARY instead?

> +HOMEPAGE = "http://www.lysator.liu.se/~nisse/nettle/"
> +SECTION = "libs"
> +LICENSE = "GPLv2+"

Is this license value correct? From the documentation:

"Nettle is distributed under the GNU Lesser General Public License (LGPL), see 
the file COPYING.LIB for details"

It looks like it might be even more complicated than that, since there is also 
a GPLv2 copying file in the 2.7.1 source.

> +LIC_FILES_CHKSUM =
> "file://COPYING.LIB;md5=2d5025d4aa3495befef8f17206a5b0a1"

Given the above we'd probably want to checksum more than just this file.

Cheers,
Paul
Martin Jansa - May 1, 2014, 2:29 p.m.
On Wed, Apr 30, 2014 at 06:39:31PM +0300, Valentin Popa wrote:
> Newer versions of gnutls depends on nettle.

> [OE-core] [PATCH 1/3] nettle: add nettle to poky

This isn't poky.

> 
> Signed-off-by: Valentin Popa <valentin.popa@intel.com>
> ---
>  meta/recipes-support/nettle/nettle_2.7.1.bb | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
>  create mode 100644 meta/recipes-support/nettle/nettle_2.7.1.bb
> 
> diff --git a/meta/recipes-support/nettle/nettle_2.7.1.bb b/meta/recipes-support/nettle/nettle_2.7.1.bb
> new file mode 100644
> index 0000000..eb7c9de
> --- /dev/null
> +++ b/meta/recipes-support/nettle/nettle_2.7.1.bb
> @@ -0,0 +1,22 @@
> +DESCRIPTION = "A low level cryptographic library"
> +HOMEPAGE = "http://www.lysator.liu.se/~nisse/nettle/"
> +SECTION = "libs"
> +LICENSE = "GPLv2+"
> +LIC_FILES_CHKSUM = "file://COPYING.LIB;md5=2d5025d4aa3495befef8f17206a5b0a1"
> +
> +DEPENDS += "gmp"
> +
> +SRC_URI = "http://www.lysator.liu.se/~nisse/archive/${BP}.tar.gz"
> +
> +SRC_URI[md5sum] = "003d5147911317931dd453520eb234a5"
> +SRC_URI[sha256sum] = "bc71ebd43435537d767799e414fce88e521b7278d48c860651216e1fc6555b40"
> +
> +do_configure_prepend() {
> +       if [ ! -e ${S}/acinclude.m4 -a -e ${S}/aclocal.m4 ]; then
> +               cp ${S}/aclocal.m4 ${S}/acinclude.m4
> +       fi
> +}
> +
> +inherit autotools
> +
> +BBCLASSEXTEND = "native"
> -- 
> 1.9.1
> 
> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
Valentin Popa - May 2, 2014, 11:18 a.m.
On 05/01/2014 02:34 PM, Paul Eggleton wrote:
> Hi Valentin,
>
> On Wednesday 30 April 2014 18:39:31 Valentin Popa wrote:
>> Newer versions of gnutls depends on nettle.
>>
>> Signed-off-by: Valentin Popa <valentin.popa@intel.com>
>> ---
>>   meta/recipes-support/nettle/nettle_2.7.1.bb | 22 ++++++++++++++++++++++
>>   1 file changed, 22 insertions(+)
>>   create mode 100644 meta/recipes-support/nettle/nettle_2.7.1.bb
>>
>> diff --git a/meta/recipes-support/nettle/nettle_2.7.1.bb
>> b/meta/recipes-support/nettle/nettle_2.7.1.bb new file mode 100644
>> index 0000000..eb7c9de
>> --- /dev/null
>> +++ b/meta/recipes-support/nettle/nettle_2.7.1.bb
>> @@ -0,0 +1,22 @@
>> +DESCRIPTION = "A low level cryptographic library"
> Since this value is short, could you please set it as SUMMARY instead?
>
>> +HOMEPAGE = "http://www.lysator.liu.se/~nisse/nettle/"
>> +SECTION = "libs"
>> +LICENSE = "GPLv2+"
> Is this license value correct? From the documentation:
>
> "Nettle is distributed under the GNU Lesser General Public License (LGPL), see
> the file COPYING.LIB for details"

I'll add both GPLv2 AND LGPLv2.1 (GPL contamination) .

>
> It looks like it might be even more complicated than that, since there is also
> a GPLv2 copying file in the 2.7.1 source.
>
>> +LIC_FILES_CHKSUM =
>> "file://COPYING.LIB;md5=2d5025d4aa3495befef8f17206a5b0a1"
> Given the above we'd probably want to checksum more than just this file.
>
> Cheers,
> Paul
>

Patch

diff --git a/meta/recipes-support/nettle/nettle_2.7.1.bb b/meta/recipes-support/nettle/nettle_2.7.1.bb
new file mode 100644
index 0000000..eb7c9de
--- /dev/null
+++ b/meta/recipes-support/nettle/nettle_2.7.1.bb
@@ -0,0 +1,22 @@ 
+DESCRIPTION = "A low level cryptographic library"
+HOMEPAGE = "http://www.lysator.liu.se/~nisse/nettle/"
+SECTION = "libs"
+LICENSE = "GPLv2+"
+LIC_FILES_CHKSUM = "file://COPYING.LIB;md5=2d5025d4aa3495befef8f17206a5b0a1"
+
+DEPENDS += "gmp"
+
+SRC_URI = "http://www.lysator.liu.se/~nisse/archive/${BP}.tar.gz"
+
+SRC_URI[md5sum] = "003d5147911317931dd453520eb234a5"
+SRC_URI[sha256sum] = "bc71ebd43435537d767799e414fce88e521b7278d48c860651216e1fc6555b40"
+
+do_configure_prepend() {
+       if [ ! -e ${S}/acinclude.m4 -a -e ${S}/aclocal.m4 ]; then
+               cp ${S}/aclocal.m4 ${S}/acinclude.m4
+       fi
+}
+
+inherit autotools
+
+BBCLASSEXTEND = "native"