Patchwork [meta-fsl-arm] libz160: Add compatible machine to 'mx5'

login
register
mail settings
Submitter Otavio Salvador
Date April 30, 2014, 1:13 p.m.
Message ID <1398863625-2525-1-git-send-email-otavio@ossystems.com.br>
Download mbox | patch
Permalink /patch/71319/
State Accepted
Delegated to: Otavio Salvador
Headers show

Comments

Otavio Salvador - April 30, 2014, 1:13 p.m.
Restrict the recipe to be used for 'mx5' SoCs only.

Change-Id: I9084cc525c7136b23e1c5522079c38bd12df7087
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
 recipes-graphics/amd-gpu-x11-bin/libz160_11.09.01.bb | 2 ++
 1 file changed, 2 insertions(+)
Mario Domenech Goulart - April 30, 2014, 1:31 p.m.
On Wed, 30 Apr 2014 10:13:45 -0300 Otavio Salvador <otavio@ossystems.com.br> wrote:

> Restrict the recipe to be used for 'mx5' SoCs only.

With regard to the patch summary: isn't it the other way around?  I
mean, something like "add mx5 to compatible machine".

> Change-Id: I9084cc525c7136b23e1c5522079c38bd12df7087
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
>  recipes-graphics/amd-gpu-x11-bin/libz160_11.09.01.bb | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/recipes-graphics/amd-gpu-x11-bin/libz160_11.09.01.bb b/recipes-graphics/amd-gpu-x11-bin/libz160_11.09.01.bb
> index 16cfa9f..1ff762a 100644
> --- a/recipes-graphics/amd-gpu-x11-bin/libz160_11.09.01.bb
> +++ b/recipes-graphics/amd-gpu-x11-bin/libz160_11.09.01.bb
> @@ -29,3 +29,5 @@ INSANE_SKIP_${PN} = "ldflags"
>  INSANE_SKIP_${PN}-dev = "ldflags"
>  FILES_${PN} = "${libdir}/*.so"
>  FILES_${PN}-dev = "${includedir}"
> +
> +COMPATIBLE_MACHINE = "(mx5)"
> -- 
> 2.0.0.rc0

Best wishes.
Mario
Otavio Salvador - April 30, 2014, 1:35 p.m.
On Wed, Apr 30, 2014 at 10:31 AM, Mario Domenech Goulart
<mario@ossystems.com.br> wrote:
> On Wed, 30 Apr 2014 10:13:45 -0300 Otavio Salvador <otavio@ossystems.com.br> wrote:
>
>> Restrict the recipe to be used for 'mx5' SoCs only.
>
> With regard to the patch summary: isn't it the other way around?  I
> mean, something like "add mx5 to compatible machine".

Like:

libz160: Add 'mx5' in compatible machine
Restrict the recipe to be used for 'mx5' SoCs only.

Change-Id: I9084cc525c7136b23e1c5522079c38bd12df7087
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Mario Domenech Goulart - April 30, 2014, 1:50 p.m.
On Wed, 30 Apr 2014 10:35:14 -0300 Otavio Salvador <otavio@ossystems.com.br> wrote:

> On Wed, Apr 30, 2014 at 10:31 AM, Mario Domenech Goulart
> <mario@ossystems.com.br> wrote:
>> On Wed, 30 Apr 2014 10:13:45 -0300 Otavio Salvador <otavio@ossystems.com.br> wrote:
>>
>>> Restrict the recipe to be used for 'mx5' SoCs only.
>>
>> With regard to the patch summary: isn't it the other way around?  I
>> mean, something like "add mx5 to compatible machine".
>
> Like:
>
> libz160: Add 'mx5' in compatible machine

Yeah, something like that.  Not really sure if `in' is the right word
for that context (I'd say `to').  To be honest, I'd use the actual
variable name (COMPATIBLE_MACHINE) instead of `compatible machine'.

> Restrict the recipe to be used for 'mx5' SoCs only.
>
> Change-Id: I9084cc525c7136b23e1c5522079c38bd12df7087
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>

Best wishes.
Mario

Patch

diff --git a/recipes-graphics/amd-gpu-x11-bin/libz160_11.09.01.bb b/recipes-graphics/amd-gpu-x11-bin/libz160_11.09.01.bb
index 16cfa9f..1ff762a 100644
--- a/recipes-graphics/amd-gpu-x11-bin/libz160_11.09.01.bb
+++ b/recipes-graphics/amd-gpu-x11-bin/libz160_11.09.01.bb
@@ -29,3 +29,5 @@  INSANE_SKIP_${PN} = "ldflags"
 INSANE_SKIP_${PN}-dev = "ldflags"
 FILES_${PN} = "${libdir}/*.so"
 FILES_${PN}-dev = "${includedir}"
+
+COMPATIBLE_MACHINE = "(mx5)"