Patchwork bitbake do not show error if mkfs.ubifs fail

login
register
mail settings
Submitter Maksym Komar
Date April 25, 2014, 11:22 a.m.
Message ID <20140425112228.GB31049@komar.lab.evologics.de>
Download mbox | patch
Permalink /patch/70955/
State New
Headers show

Comments

Maksym Komar - April 25, 2014, 11:22 a.m.
I spend some time to find why .ubifs generate, but .ubi image do not.
In IMAGE_CMD_ubi it's like "mkfs.ubifs ... && ubinize", and while && is there, "set -e" do not work.

Patch

From e75f2ce250198e12f855f3492168b661b2e672b9 Mon Sep 17 00:00:00 2001
From: Maksym Komar <komar@evologics.de>
Date: Fri, 25 Apr 2014 12:59:52 +0200
Subject: [PATCH] fix not show error if mkfs.ubifs fail

---
 meta/classes/image_types.bbclass | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta/classes/image_types.bbclass b/meta/classes/image_types.bbclass
index f38e3b6..a7d18c7 100644
--- a/meta/classes/image_types.bbclass
+++ b/meta/classes/image_types.bbclass
@@ -93,7 +93,8 @@  IMAGE_CMD_ubi () {
 	echo vol_type=dynamic >> ubinize.cfg 
 	echo vol_name=${UBI_VOLNAME} >> ubinize.cfg 
 	echo vol_flags=autoresize >> ubinize.cfg
-	mkfs.ubifs -r ${IMAGE_ROOTFS} -o ${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ubifs ${MKUBIFS_ARGS} && ubinize -o ${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ubi ${UBINIZE_ARGS} ubinize.cfg
+	mkfs.ubifs -r ${IMAGE_ROOTFS} -o ${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ubifs ${MKUBIFS_ARGS}
+	ubinize -o ${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ubi ${UBINIZE_ARGS} ubinize.cfg
 }
 IMAGE_CMD_ubifs = "mkfs.ubifs -r ${IMAGE_ROOTFS} -o ${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ubifs ${MKUBIFS_ARGS}"
 
-- 
1.9.1