Patchwork report-error: Add posting in the public note

login
register
mail settings
Submitter Saul Wold
Date April 22, 2014, 11:42 p.m.
Message ID <1398210145-15701-1-git-send-email-sgw@linux.intel.com>
Download mbox | patch
Permalink /patch/70739/
State New
Headers show

Comments

Saul Wold - April 22, 2014, 11:42 p.m.
Signed-off-by: Saul Wold <sgw@linux.intel.com>
---
 meta/classes/report-error.bbclass | 1 +
 scripts/send-error-report         | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)

Patch

diff --git a/meta/classes/report-error.bbclass b/meta/classes/report-error.bbclass
index 479b38d..15adc97 100644
--- a/meta/classes/report-error.bbclass
+++ b/meta/classes/report-error.bbclass
@@ -60,6 +60,7 @@  python errorreport_handler () {
                 filename = "error_report_" + e.data.getVar("BUILDNAME")+".txt"
                 datafile = errorreport_savedata(e, jsondata, filename)
                 bb.note("The errors of this build are stored in: %s. You can send the errors to an upstream server by running: send-error-report %s [server]" % (datafile, datafile))
+                bb.note("The contents of these logs will be posted in public if you use the above script. Please ensure you remove any identifying or propriety information before sending.")
 }
 
 addhandler errorreport_handler
diff --git a/scripts/send-error-report b/scripts/send-error-report
index 3d1f7a4..48d983b 100755
--- a/scripts/send-error-report
+++ b/scripts/send-error-report
@@ -97,8 +97,9 @@  def sendData(json_file, server):
 
 if __name__ == '__main__':
     print ("\nSends an error report (if the report-error class was enabled) to a remote server.")
+    print("\nThis scripts sends the contents of the error to a public upstream server.")
+    print("\nPlease remove any identifying information before sending.")
     if len(sys.argv) < 2:
-        print("\nThis scripts sends the contents of a file to an upstream server.")
         print("\nUsage: send-error-report <error_fileName> [server]")
         print("\nIf this is the first when sending a report you'll be asked for your name and optionally your email address.")
         print("They will be associated with your report.\n")