Patchwork [v2] linux-omap-psp: Fix the user button GPIO to the correct value for a BeagleBoard-xM

login
register
mail settings
Submitter Joel A Fernandes
Date July 6, 2011, 1:48 a.m.
Message ID <1309916936-17283-1-git-send-email-agnel.joel@gmail.com>
Download mbox | patch
Permalink /patch/7069/
State New, archived
Headers show

Comments

Joel A Fernandes - July 6, 2011, 1:48 a.m.
Signed-off-by: Joel A Fernandes <agnel.joel@gmail.com>
---
 ...agle-cleaned-up-board-revision-conditions.patch |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Paul Menzel - July 6, 2011, 9:43 a.m.
Dear Joel,


Am Dienstag, den 05.07.2011, 20:48 -0500 schrieb Joel A Fernandes:

1. What has changed in this patch iteration? (You can put that below the
`---`.)
2. Could you elaborate a bit more what the problem was, i. e. how the
situation was before, and how the fix works? For example pointing to the
thread on the BeagleBoard list.(?)
3. Is a similar patch also needed for 2.6.39?

> Signed-off-by: Joel A Fernandes <agnel.joel@gmail.com>
> ---
>  ...agle-cleaned-up-board-revision-conditions.patch |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/recipes/linux/linux-omap-psp-2.6.32/beagleboard-xmc/0008-omap3-beagle-cleaned-up-board-revision-conditions.patch b/recipes/linux/linux-omap-psp-2.6.32/beagleboard-xmc/0008-omap3-beagle-cleaned-up-board-revision-conditions.patch
> index 513a101..fb91cb6 100644
> --- a/recipes/linux/linux-omap-psp-2.6.32/beagleboard-xmc/0008-omap3-beagle-cleaned-up-board-revision-conditions.patch
> +++ b/recipes/linux/linux-omap-psp-2.6.32/beagleboard-xmc/0008-omap3-beagle-cleaned-up-board-revision-conditions.patch
> @@ -143,8 +143,8 @@ index 4bde54b..664a9c6 100644
>   	omap3_beagle_i2c_init();
>   
>  -	if (cpu_is_omap3630()) {
> -+	if ((omap3_beagle_get_rev() != OMAP3BEAGLE_BOARD_XMAB) &&
> -+		(omap3_beagle_get_rev() != OMAP3BEAGLE_BOARD_XMC)) {
> ++	if ((omap3_beagle_get_rev() == OMAP3BEAGLE_BOARD_XMAB) ||
> ++		(omap3_beagle_get_rev() == OMAP3BEAGLE_BOARD_XMC)) {
>   		gpio_buttons[0].gpio = 4;
>   	}


Thanks,

Paul
Joel A Fernandes - July 6, 2011, 3:56 p.m.
Hi Paul,

Thanks for your suggestions.

On Wed, Jul 6, 2011 at 4:43 AM, Paul Menzel
<paulepanter@users.sourceforge.net> wrote:
> Dear Joel,
>
>
> Am Dienstag, den 05.07.2011, 20:48 -0500 schrieb Joel A Fernandes:
>
> 1. What has changed in this patch iteration? (You can put that below the
> `---`.)

Thanks, will do.

> 2. Could you elaborate a bit more what the problem was, i. e. how the
> situation was before, and how the fix works? For example pointing to the
> thread on the BeagleBoard list.(?)

I am not aware of any thread that showed concern about the incorrect
value. It so happened that the user-button wasn't working for me.

> 3. Is a similar patch also needed for 2.6.39?

A similar patch is already included in 2.6.39 and has the correct value.
(line 109 in linux/linux-omap-2.6.39/beagle/0001-OMAP3-beagle-add-support-for-beagleboard-xM-revision.patch)

Thanks,
Joel

Patch

diff --git a/recipes/linux/linux-omap-psp-2.6.32/beagleboard-xmc/0008-omap3-beagle-cleaned-up-board-revision-conditions.patch b/recipes/linux/linux-omap-psp-2.6.32/beagleboard-xmc/0008-omap3-beagle-cleaned-up-board-revision-conditions.patch
index 513a101..fb91cb6 100644
--- a/recipes/linux/linux-omap-psp-2.6.32/beagleboard-xmc/0008-omap3-beagle-cleaned-up-board-revision-conditions.patch
+++ b/recipes/linux/linux-omap-psp-2.6.32/beagleboard-xmc/0008-omap3-beagle-cleaned-up-board-revision-conditions.patch
@@ -143,8 +143,8 @@  index 4bde54b..664a9c6 100644
  	omap3_beagle_i2c_init();
  
 -	if (cpu_is_omap3630()) {
-+	if ((omap3_beagle_get_rev() != OMAP3BEAGLE_BOARD_XMAB) &&
-+		(omap3_beagle_get_rev() != OMAP3BEAGLE_BOARD_XMC)) {
++	if ((omap3_beagle_get_rev() == OMAP3BEAGLE_BOARD_XMAB) ||
++		(omap3_beagle_get_rev() == OMAP3BEAGLE_BOARD_XMC)) {
  		gpio_buttons[0].gpio = 4;
  	}