Patchwork [meta-oe,2/3] gd: add perl to RDEPENDS

login
register
mail settings
Submitter jackie huang
Date April 15, 2014, 7:01 a.m.
Message ID <98585e4f0a807976da5b7fae817d2ed1bf5b012c.1397545082.git.jackie.huang@windriver.com>
Download mbox | patch
Permalink /patch/70595/
State Accepted, archived
Headers show

Comments

jackie huang - April 15, 2014, 7:01 a.m.
From: Hongxu Jia <hongxu.jia@windriver.com>

| Note: adding Smart RPM DB channel
|
| Note: to be installed:  gd@x86_64 run-postinsts@x86_64 kernel-modules@qemux86_64 packagegroup-core-boot@qemux86_64
| Loading cache...
| Updating cache...               ######################################## [100%]
|
| Computing transaction...error: Can't install gd-2.1.0-r0.0@x86_64: no package provides /usr/bin/perl
|
| Saving cache...
|
| WARNING: exit code 1 from a shell command.
| ERROR: Function failed: do_rootfs (log file is located at tmp/work/qemux86_64-wrs-linux/wrlinux-image-glibc-small/1.0-r1/temp/do_rootfs/log.do_rootfs.26487)

Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
---
 meta-oe/recipes-support/gd/gd_2.1.0.bb |    1 +
 1 file changed, 1 insertion(+)
Koen Kooi - April 15, 2014, 8:23 a.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

jackie.huang@windriver.com schreef op 15-04-14 09:01:
> From: Hongxu Jia <hongxu.jia@windriver.com>
> 
> | Note: adding Smart RPM DB channel | | Note: to be installed:  gd@x86_64
> run-postinsts@x86_64 kernel-modules@qemux86_64
> packagegroup-core-boot@qemux86_64 | Loading cache... | Updating cache...
> ######################################## [100%] | | Computing
> transaction...error: Can't install gd-2.1.0-r0.0@x86_64: no package
> provides /usr/bin/perl

That's nice and all, but you don't seem to runtime test this. I'm pretty
sure gd needs additional perl modules installed for its perl sections.

And FWIW, the bits that need perl should be split out in gd-perl

> | | Saving cache... | | WARNING: exit code 1 from a shell command. |
> ERROR: Function failed: do_rootfs (log file is located at
> tmp/work/qemux86_64-wrs-linux/wrlinux-image-glibc-small/1.0-r1/temp/do_rootfs/log.do_rootfs.26487)
>
>  Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com> Signed-off-by:
> Jackie Huang <jackie.huang@windriver.com> --- 
> meta-oe/recipes-support/gd/gd_2.1.0.bb |    1 + 1 file changed, 1
> insertion(+)
> 
> diff --git a/meta-oe/recipes-support/gd/gd_2.1.0.bb
> b/meta-oe/recipes-support/gd/gd_2.1.0.bb index 1b78b9b..3d41eec 100644 
> --- a/meta-oe/recipes-support/gd/gd_2.1.0.bb +++
> b/meta-oe/recipes-support/gd/gd_2.1.0.bb @@ -11,6 +11,7 @@ SECTION =
> "libs" LICENSE = "GD" LIC_FILES_CHKSUM =
> "file://COPYING;md5=c97638cafd3581eb87abd37332137669" DEPENDS = "freetype
> libpng jpeg zlib" +RDEPENDS_${PN} = "perl"

R* variables go below do_install

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
Comment: GPGTools - http://gpgtools.org

iD8DBQFTTOyEMkyGM64RGpERAu1dAJ4xqraqlz5pEmf+uZnOcxSt0gc9HgCghTpX
SWCuUnlnxjLDTnJSvlHHGqQ=
=IivC
-----END PGP SIGNATURE-----
jackie huang - April 16, 2014, 2:29 a.m.
> -----Original Message-----
> From: openembedded-devel-bounces@lists.openembedded.org [mailto:openembedded-devel-
> bounces@lists.openembedded.org] On Behalf Of Koen Kooi
> Sent: Tuesday, April 15, 2014 4:24 PM
> To: openembedded-devel@lists.openembedded.org
> Subject: Re: [oe] [meta-oe][PATCH 2/3] gd: add perl to RDEPENDS
> 
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> jackie.huang@windriver.com schreef op 15-04-14 09:01:
> > From: Hongxu Jia <hongxu.jia@windriver.com>
> >
> > | Note: adding Smart RPM DB channel | | Note: to be installed:
> > | gd@x86_64
> > run-postinsts@x86_64 kernel-modules@qemux86_64
> > packagegroup-core-boot@qemux86_64 | Loading cache... | Updating cache...
> > ######################################## [100%] | | Computing
> > transaction...error: Can't install gd-2.1.0-r0.0@x86_64: no package
> > provides /usr/bin/perl
> 
> That's nice and all, but you don't seem to runtime test this. I'm pretty sure gd needs additional perl
> modules installed for its perl sections.

The tools provided by gd that needs perl is the "fstobdf" which is a simple convertor from bdf to
gd font format, yes, it's using the 'strict' perl module, and I checked that ' perl-module-strict' is rprovided
by 'perl', so it would be fine to rdepends  on 'perl' only, and I did the runtime test and it works fine.

> 
> And FWIW, the bits that need perl should be split out in gd-perl

En.., I didn't realize that. Currently the gd package is providing the the gd graphics library
and a bunch of converts between gd and other graphics formats, one of which is perl script, and I see
that some Linux distribution (e.g. Ubuntu) usually split them into two package: 'libgd' for the library,
libgd-tools for the convert binaries/scripts, rather than splitting the perl script into gd-perl, I prefer
to split all the converts into gd-tools (or libgd-tools), what do you think?

> 
> > | | Saving cache... | | WARNING: exit code 1 from a shell command. |
> > ERROR: Function failed: do_rootfs (log file is located at
> > tmp/work/qemux86_64-wrs-linux/wrlinux-image-glibc-small/1.0-r1/temp/do
> > _rootfs/log.do_rootfs.26487)
> >
> >  Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com> Signed-off-by:
> > Jackie Huang <jackie.huang@windriver.com> ---
> > meta-oe/recipes-support/gd/gd_2.1.0.bb |    1 + 1 file changed, 1
> > insertion(+)
> >
> > diff --git a/meta-oe/recipes-support/gd/gd_2.1.0.bb
> > b/meta-oe/recipes-support/gd/gd_2.1.0.bb index 1b78b9b..3d41eec 100644
> > --- a/meta-oe/recipes-support/gd/gd_2.1.0.bb +++
> > b/meta-oe/recipes-support/gd/gd_2.1.0.bb @@ -11,6 +11,7 @@ SECTION =
> > "libs" LICENSE = "GD" LIC_FILES_CHKSUM =
> > "file://COPYING;md5=c97638cafd3581eb87abd37332137669" DEPENDS =
> > "freetype libpng jpeg zlib" +RDEPENDS_${PN} = "perl"
> 
> R* variables go below do_install

Yeah, thanks, I will re-send for the changes.

Thanks,
Jackie

> 
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.5 (Darwin)
> Comment: GPGTools - http://gpgtools.org
> 
> iD8DBQFTTOyEMkyGM64RGpERAu1dAJ4xqraqlz5pEmf+uZnOcxSt0gc9HgCghTpX
> SWCuUnlnxjLDTnJSvlHHGqQ=
> =IivC
> -----END PGP SIGNATURE-----
> 
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Patch

diff --git a/meta-oe/recipes-support/gd/gd_2.1.0.bb b/meta-oe/recipes-support/gd/gd_2.1.0.bb
index 1b78b9b..3d41eec 100644
--- a/meta-oe/recipes-support/gd/gd_2.1.0.bb
+++ b/meta-oe/recipes-support/gd/gd_2.1.0.bb
@@ -11,6 +11,7 @@  SECTION = "libs"
 LICENSE = "GD"
 LIC_FILES_CHKSUM = "file://COPYING;md5=c97638cafd3581eb87abd37332137669"
 DEPENDS = "freetype libpng jpeg zlib"
+RDEPENDS_${PN} = "perl"
 
 SRC_URI = "https://bitbucket.org/libgd/gd-libgd/downloads/libgd-${PV}.tar.bz2"
 SRC_URI[md5sum] = "5a1d5bab3a4a41d9f111bcceee4ad25b"