Patchwork [bitbake-devel] runqueue: Do not write out stamp files in dry_run mode

login
register
mail settings
Submitter Richard Purdie
Date April 13, 2014, 10:45 a.m.
Message ID <1397385958.15843.47.camel@ted>
Download mbox | patch
Permalink /patch/70553/
State New
Headers show

Comments

Richard Purdie - April 13, 2014, 10:45 a.m.
In dry run mode, stamps for noexec tasks are being written out which
is incorrect. Avoid this.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---

Patch

diff --git a/bitbake/lib/bb/runqueue.py b/bitbake/lib/bb/runqueue.py
index 6ca693d..4ea4970 100644
--- a/bitbake/lib/bb/runqueue.py
+++ b/bitbake/lib/bb/runqueue.py
@@ -1551,7 +1551,8 @@  class RunQueueExecuteTasks(RunQueueExecute):
                 bb.event.fire(startevent, self.cfgData)
                 self.runq_running[task] = 1
                 self.stats.taskActive()
-                bb.build.make_stamp(taskname, self.rqdata.dataCache, fn)
+                if not self.cooker.configuration.dry_run:
+                    bb.build.make_stamp(taskname, self.rqdata.dataCache, fn)
                 self.task_complete(task)
                 return True
             else: