Patchwork [00/17] Various QA/unpackaged files cleanups

login
register
mail settings
Submitter Richard Purdie
Date July 5, 2011, 10:51 p.m.
Message ID <cover.1309906154.git.richard.purdie@linuxfoundation.org>
Download mbox
Permalink /patch/7029/
State New, archived
Headers show

Pull-request

git://git.openembedded.org/openembedded-core-contrib rpurdie/master

Comments

Richard Purdie - July 5, 2011, 10:51 p.m.
This patch series is for a number of QA/unpackaged files cleanups.

The following changes since commit f05b7ee7716d1e5cc1ba0bbab57e91c3a0569e9e:

  x-load: Update to 1.5.0 (2011-07-05 14:16:33 +0100)

are available in the git repository at:
  git://git.openembedded.org/openembedded-core-contrib rpurdie/master
  http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rpurdie/master

Richard Purdie (17):
  gcc: Fix unpackaged files warnings, broken symlink and superfluous
    files
  connman: Package unpackaged .la file
  tslib: Package unpackaged .la file
  btrfs-tools: Fix manpage creation directory
  xcb-proto: Package unshipped files, create python-xcbgen package for
    python xcbgen code
  eds-dbus: Package unpackaged files
  systemtap: Don't set prefix to a path including  so examples get
    placed in the correct path and packaged correctly
  qt4: Package debug source files
  telepathy-python: Remove unneeded and unpackaged files
  librsvg: Clean up unpackaged files
  gtk-engines: Package unpackaged files
  x11perf: Packaged unpackaged files
  apt: Package unpackaged files
  git: Package up python and gitweb files into appropriate packages
  kernelshark/trace-cmd: Clean up QA warnings including fising LDFLAGS
    issues
  opensp: Add unpackaged files
  chrpath: Ensure the package respects the docdir variable

 meta/recipes-connectivity/connman/connman.inc      |    2 +
 meta/recipes-connectivity/connman/connman_0.75.bb  |    2 +-
 .../telepathy/telepathy-python_0.15.19.bb          |    9 ++++-
 meta/recipes-devtools/apt/apt-package.inc          |    2 +-
 meta/recipes-devtools/apt/apt_0.7.14.bb            |    4 +-
 .../btrfs-tools/btrfs-tools/weak-defaults.patch    |   31 ++++++++++++++
 .../btrfs-tools/btrfs-tools_git.bb                 |    3 +-
 .../chrpath/chrpath/standarddoc.patch              |   19 +++++++++
 meta/recipes-devtools/chrpath/chrpath_0.13.bb      |    5 +-
 meta/recipes-devtools/gcc/gcc-package-target.inc   |   25 +++++++++--
 meta/recipes-devtools/git/git.inc                  |    6 +++
 meta/recipes-devtools/opensp/opensp_1.5.bb         |    4 +-
 .../gtk-engines/gtk-engines_2.20.2.bb              |    5 ++-
 meta/recipes-gnome/librsvg/librsvg_2.32.1.bb       |   15 +++++--
 meta/recipes-graphics/tslib/tslib_1.0.bb           |    3 +-
 meta/recipes-graphics/xcb/xcb-proto.inc            |    5 ++-
 meta/recipes-graphics/xcb/xcb-proto_1.6.bb         |    2 +-
 meta/recipes-graphics/xorg-app/x11perf_1.5.3.bb    |    4 +-
 meta/recipes-kernel/systemtap/systemtap_git.bb     |    4 +-
 meta/recipes-kernel/trace-cmd/kernelshark_git.bb   |   10 ++++-
 .../trace-cmd/trace-cmd/addldflags.patch           |   43 ++++++++++++++++++++
 meta/recipes-kernel/trace-cmd/trace-cmd_git.bb     |    5 +-
 meta/recipes-qt/qt4/qt4.inc                        |    4 +-
 meta/recipes-sato/eds/eds-dbus_2.20.0.bb           |    7 ++-
 meta/recipes-sato/eds/eds-dbus_git.bb              |    9 +++-
 25 files changed, 193 insertions(+), 35 deletions(-)
 create mode 100644 meta/recipes-devtools/btrfs-tools/btrfs-tools/weak-defaults.patch
 create mode 100644 meta/recipes-devtools/chrpath/chrpath/standarddoc.patch
 create mode 100644 meta/recipes-kernel/trace-cmd/trace-cmd/addldflags.patch
Otavio Salvador - July 6, 2011, 2:59 a.m.
On Tue, Jul 5, 2011 at 19:51, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> This patch series is for a number of QA/unpackaged files cleanups.

I noticed you have added .la files in some packages. This seems wrong
and useless. In fact I am making a local patchset to drop them all and
I have most build working (fixing last things before posting for
review).

It seems very wrong to depend on .la files for linking and pkg-config
seems to be the most right solution when possible.
Richard Purdie - July 6, 2011, 8:03 a.m.
On Tue, 2011-07-05 at 23:59 -0300, Otavio Salvador wrote:
> On Tue, Jul 5, 2011 at 19:51, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > This patch series is for a number of QA/unpackaged files cleanups.
> 
> I noticed you have added .la files in some packages. This seems wrong
> and useless. In fact I am making a local patchset to drop them all and
> I have most build working (fixing last things before posting for
> review).
> 
> It seems very wrong to depend on .la files for linking and pkg-config
> seems to be the most right solution when possible.

.la files are an interesting problem. I'm not overly fond of them but
even in this modern age they can help on certain targets like darwin and
they can help with static linking since they have dependency information
that often hasn't been added into the .pc files. We don't often do
either of those things but in general the .la files are pretty harmless.

With regard to the patch series, it just adds .la files to -dev packages
so the only impact is to development images and even there its small.

If you wanted to clean things up, dropping all the binconfig scripts
would IMO be a much more useful effort as those are much more ugly to
handle and bug ridden. At least libtool has some notion of sysroot
support these days!

Cheers,

Richard
Phil Blundell - July 6, 2011, 9:06 a.m.
On Tue, 2011-07-05 at 23:59 -0300, Otavio Salvador wrote:
> On Tue, Jul 5, 2011 at 19:51, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > This patch series is for a number of QA/unpackaged files cleanups.
> 
> I noticed you have added .la files in some packages. This seems wrong
> and useless. In fact I am making a local patchset to drop them all and
> I have most build working (fixing last things before posting for
> review).
> 
> It seems very wrong to depend on .la files for linking and pkg-config
> seems to be the most right solution when possible.

I think Richard's patch to add the .las to the appropriate FILES is a
reasonable one.  Whether you actually want the .la files installed or
not is another question, but if your policy is that you don't then I
think the right answer is a global mechanism to suppress them rather
than tinkering with individual recipes.  It would probably be fairly
straightforward to make a new class which did something like:

do_purge_la() {
	find ${D} -name "*.la" | xargs rm -f
}

addtask purge_la after do_install before do_package do_populate_sysroot

which you could then call in from your DISTRO config as and when
desired.

p.