Patchwork [V4,0/1] dbus: fix a hard dependency about dbus-ptest

login
register
mail settings
Submitter Chong.Lu@windriver.com
Date April 8, 2014, 3:30 a.m.
Message ID <cover.1396927648.git.Chong.Lu@windriver.com>
Download mbox
Permalink /patch/70229/
State New
Headers show

Pull-request

git://git.pokylinux.org/poky-contrib chonglu/dbus

Comments

Chong.Lu@windriver.com - April 8, 2014, 3:30 a.m.
Changes since V3:

Add class-target suffix to RDEPENDS_dbus-ptest.

The following changes since commit bb66113bde5361b869dce2bdaece5b938f077ea8:

  bitbake: fetch2: Fix bug in file checksum generation (2014-04-06 11:31:26 +0100)

are available in the git repository at:

  git://git.pokylinux.org/poky-contrib chonglu/dbus
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=chonglu/dbus

Chong Lu (1):
  dbus: fix a hard dependency about dbus-ptest

 meta/recipes-core/dbus/{dbus-ptest_1.6.18.bb => dbus-test_1.6.18.bb} | 0
 meta/recipes-core/dbus/dbus.inc                                      | 4 +++-
 2 files changed, 3 insertions(+), 1 deletion(-)
 rename meta/recipes-core/dbus/{dbus-ptest_1.6.18.bb => dbus-test_1.6.18.bb} (100%)
Javier Viguera - June 16, 2014, 12:04 p.m.
Hi all,

I see this was finally included in oe-core *master*, but the problem is 
still affecting Daisy.

Creating a basic command-line image with dbus pulls in the 
dbus-ptest-ptest package (37MB installed):

# du -sh /usr/lib/dbus-ptest/ptest
37.6M   /usr/lib/dbus-ptest/ptest

Could the fix be backported to Daisy?

-
Thanks,

Javier Viguera
Software Engineer
Digi International® Spain S.A.U.
Ross Burton - June 16, 2014, 1:31 p.m.
If you'd be willing to backport the patch, verify that it works, and
send it to the list, then that would be much appreciated and speed
integration.

Ross

On 16 June 2014 13:04, Javier Viguera <javier.viguera@digi.com> wrote:
> Hi all,
>
> I see this was finally included in oe-core *master*, but the problem is
> still affecting Daisy.
>
> Creating a basic command-line image with dbus pulls in the dbus-ptest-ptest
> package (37MB installed):
>
> # du -sh /usr/lib/dbus-ptest/ptest
> 37.6M   /usr/lib/dbus-ptest/ptest
>
> Could the fix be backported to Daisy?
>
> -
> Thanks,
>
> Javier Viguera
> Software Engineer
> Digi International® Spain S.A.U.
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
Ross Burton - June 16, 2014, 3:12 p.m.
On 16 June 2014 16:10, Javier Viguera <javier.viguera@digi.com> wrote:
> Attached the obvious cherry-pick of the commit from *master* with a basic
> conflict solved. But I don't think this is acceptable in an already-released
> stable branch "Daisy" as it involves a recipe rename (dbus-ptest_1.6.18.bb
> => dbus-test_1.6.18.bb) that probably will break the projects of current
> users of yocto Daisy.
>
> Instead, would a basic change like the following be enough?:
>
>
> -RDEPENDS_dbus = "${@base_contains('DISTRO_FEATURES', 'ptest',
> 'dbus-ptest-ptest', '', d)}"
> +RDEPENDS_dbus = "${@base_contains('PTEST_ENABLED', '1', 'dbus-ptest-ptest',
> '', d)}"
>
> This does not change any recipe name so it seems suitable for a bug-fix only
> branch but unfortunately this goes beyond my skills in Yocto and ptest
> framework so any advise would be appreciated.

That change doesn't solve your problem, so no.  I'm not the daisy
maintainer but I can see a good argument for merging the change even
with the rename.

Ross