Patchwork [RFC] samba: remove talloc from DEPENDS

login
register
mail settings
Submitter Jate S
Date April 4, 2014, 8:37 p.m.
Message ID <CAPphmgb9DTJ+K010b0CaqZM-_DCiOtWj7mhVPzMvArHczbyKLg@mail.gmail.com>
Download mbox | patch
Permalink /patch/70163/
State New
Headers show

Comments

Jate S - April 4, 2014, 8:37 p.m.
I've only tried this out on dora. There are no other changes, so I
think it should work for newer branches.
----
samba: remove talloc from DEPENDS

Samba has a DEPENDS on talloc, but the recipe runs configure
"--without-libtalloc".

The dependency tree causes a rebuild when using a PREMIRROR sstate
cache. Removing talloc from DEPENDS fixes the problem.

Signed-off-by: Jate Sujjavanich <jatedev@gmail.com>
Khem Raj - April 5, 2014, 5:40 a.m.
On Fri, Apr 4, 2014 at 1:37 PM, Jate S <jatedev@gmail.com> wrote:
> samba: remove talloc from DEPENDS
>
> Samba has a DEPENDS on talloc, but the recipe runs configure
> "--without-libtalloc".

FWIW this should become PACKAGECONFIG which is disabled by default
Richard Purdie - April 5, 2014, 9:39 a.m.
On Fri, 2014-04-04 at 16:37 -0400, Jate S wrote:
> I've only tried this out on dora. There are no other changes, so I
> think it should work for newer branches.
> ----
> samba: remove talloc from DEPENDS
> 
> Samba has a DEPENDS on talloc, but the recipe runs configure
> "--without-libtalloc".
> 
> The dependency tree causes a rebuild when using a PREMIRROR sstate
> cache. Removing talloc from DEPENDS fixes the problem.
> 
> Signed-off-by: Jate Sujjavanich <jatedev@gmail.com>
> 
> diff --git a/meta-oe/recipes-connectivity/samba/samba.inc b/meta-oe/recipes-conn
> index 7391bbf..42979c8 100644
> --- a/meta-oe/recipes-connectivity/samba/samba.inc
> +++ b/meta-oe/recipes-connectivity/samba/samba.inc

This is a meta-oe change so it needs to go to openembedded-devel (as per
the README).

Cheers,

Richard

Patch

diff --git a/meta-oe/recipes-connectivity/samba/samba.inc b/meta-oe/recipes-conn
index 7391bbf..42979c8 100644
--- a/meta-oe/recipes-connectivity/samba/samba.inc
+++ b/meta-oe/recipes-connectivity/samba/samba.inc
@@ -1,6 +1,6 @@ 
 SECTION = "console/network"
 LICENSE = "GPL-3.0"
-DEPENDS = "readline virtual/libiconv talloc zlib popt"
+DEPENDS = "readline virtual/libiconv zlib popt"

 SRC_URI = "http://samba.org/samba/ftp/stable/samba-${PV}.tar.gz \
            file://volatiles.03_samba \