Patchwork [bitbake-devel,11/14] toaster: Make tables happy in Chrome

login
register
mail settings
Submitter Alexandru DAMIAN
Date April 4, 2014, 2:10 p.m.
Message ID <dc171602d99b180b49ed1e6c34a0409c005bc8c4.1396620556.git.alexandru.damian@intel.com>
Download mbox | patch
Permalink /patch/70129/
State New
Headers show

Comments

Alexandru DAMIAN - April 4, 2014, 2:10 p.m.
From: Belen Barros Pena <belen.barros.pena@intel.com>

There is a known layout issue with Bootstrap tables in
Chrome. This change applies a css fix for it, and changes
the span classes in the variables table to improve
formatting.

Signed-off-by: Belen Barros Pena <belen.barros.pena@intel.com>
---
 lib/toaster/toastergui/static/css/default.css | 3 +++
 lib/toaster/toastergui/views.py               | 4 +---
 2 files changed, 4 insertions(+), 3 deletions(-)

Patch

diff --git a/lib/toaster/toastergui/static/css/default.css b/lib/toaster/toastergui/static/css/default.css
index b4345da..baf70fb 100644
--- a/lib/toaster/toastergui/static/css/default.css
+++ b/lib/toaster/toastergui/static/css/default.css
@@ -109,6 +109,9 @@  select { width: auto; }
 .hero-unit > .close { font-size:40px; }
 .hero-actions { margin-top: 30px; }
 
+/* make tables Chrome-happy (me, not so much) */
+#otable { table-layout: fixed; word-wrap: break-word; }
+
 
 
 
diff --git a/lib/toaster/toastergui/views.py b/lib/toaster/toastergui/views.py
index ba69dd8..e346ac4 100644
--- a/lib/toaster/toastergui/views.py
+++ b/lib/toaster/toastergui/views.py
@@ -1142,7 +1142,6 @@  def configvars(request, build_id):
                 'tablecols' : [
                 {'name': 'Variable',
                  'qhelp': "BitBake is a generic task executor that considers a list of tasks with dependencies and handles metadata that consists of variables in a certain format that get passed to the tasks",
-                 'dclass' : "span3",
                  'orderfield': _get_toggle_order(request, "variable_name"),
                  'ordericon':_get_toggle_order_icon(request, "variable_name"),
                 },
@@ -1153,7 +1152,6 @@  def configvars(request, build_id):
                 {'name': 'Set in file',
                  'qhelp': "The last configuration file that touched the variable value",
                  'clclass': 'file', 'hidden' : 0,
-                 'dclass': "span6",
                  'filter' : {
                     'class' : 'vhistory__file_name',
                     'label': 'Show:',
@@ -1169,7 +1167,7 @@  def configvars(request, build_id):
                 {'name': 'Description',
                  'qhelp': "A brief explanation of the variable",
                  'clclass': 'description', 'hidden' : 0,
-                 'dclass': "span5",
+                 'dclass': "span4",
                  'filter' : {
                     'class' : 'description',
                     'label': 'Show:',