Patchwork [RFC] files/device_table-minimal.txt: cleanup

login
register
mail settings
Submitter Matthieu CRAPET
Date April 2, 2014, 4:46 p.m.
Message ID <1396457186-5961-1-git-send-email-Matthieu.Crapet@ingenico.com>
Download mbox | patch
Permalink /patch/70033/
State Accepted
Commit 62238e1335e16347e9419184b8e30f508ada6e11
Headers show

Comments

Matthieu CRAPET - April 2, 2014, 4:46 p.m.
This device list is only used if USE_DEVFS is set to '0' (which is NOT the default since 2013-12-14,
see commit f54fdd6673a136ee1cee1f3263a8a7820de43ca3) and if IMAGE_DEVICE_TABLE and IMAGE_DEVICE_TABLES are not set.

This is, of course a very subjective list but minimal with 62 (special) files.
However, you should be able to boot correctly a lot of embedded linux around.

Changes:
- add sda, sdb, sda[1234], sdb[1234]
- add mmcblk0, mmcblk0p[1234]
- add rtc0, rtc1
- restrict maximum hdaX from 19 to 4 (pata is old)
- add ttyS1
- remove initctl, apm_bios, tty8, ttySA
- sorted entries

Signed-off-by: Matthieu Crapet <Matthieu.Crapet@ingenico.com>
---
 meta/files/device_table-minimal.txt | 26 +++++++++++++++-----------
 1 file changed, 15 insertions(+), 11 deletions(-)
Richard Purdie - April 3, 2014, 7:26 a.m.
On Wed, 2014-04-02 at 18:46 +0200, Matthieu Crapet wrote:
> This device list is only used if USE_DEVFS is set to '0' (which is NOT the default since 2013-12-14,
> see commit f54fdd6673a136ee1cee1f3263a8a7820de43ca3) and if IMAGE_DEVICE_TABLE and IMAGE_DEVICE_TABLES are not set.
> 
> This is, of course a very subjective list but minimal with 62 (special) files.
> However, you should be able to boot correctly a lot of embedded linux around.
> 
> Changes:
> - add sda, sdb, sda[1234], sdb[1234]
> - add mmcblk0, mmcblk0p[1234]

If I remember correctly, mmc devices are dynamically allocated numbers.
Can we guarantee these are going to be correct?

> - add rtc0, rtc1
> - restrict maximum hdaX from 19 to 4 (pata is old)
> - add ttyS1

I only see ttyS, not S0 or S1?

> - remove initctl, apm_bios, tty8, ttySA
> - sorted entries

Cheers,

Richard

> Signed-off-by: Matthieu Crapet <Matthieu.Crapet@ingenico.com>
> ---
>  meta/files/device_table-minimal.txt | 26 +++++++++++++++-----------
>  1 file changed, 15 insertions(+), 11 deletions(-)
> 
> diff --git a/meta/files/device_table-minimal.txt b/meta/files/device_table-minimal.txt
> index 56c74bb..e4891cc 100644
> --- a/meta/files/device_table-minimal.txt
> +++ b/meta/files/device_table-minimal.txt
> @@ -9,23 +9,27 @@
>  #    p	Fifo (named pipe)
>  
>  /dev		d	755	root	root	-	-	-	-	-
> -/dev/initctl	p	600	root	root	-	-	-	-	-
> -/dev/apm_bios	c	660	root	plugdev	10	134	-	-	-
> +/dev/console	c	662	root	tty	5	1	-	-	-
>  /dev/fb0	c	600	root	root	29	0	-	-	-
>  /dev/hda	b	660	root	disk	3	0	-	-	-
> -/dev/hda	b	660	root	disk	3	1	1	1	19
> +/dev/hda	b	660	root	disk	3	1	1	1	4
>  /dev/kmem	c	640	root	kmem	1	2	-	-	-
>  /dev/kmsg	c	600	root	root	1	11	-	-	-
>  /dev/mem	c	640	root	kmem	1	1	-	-	-
> -/dev/null	c	666	root	root	1	3	-	-	-
> -/dev/ram	b	640	root	root	1	0	0	1	4
> -/dev/tty	c	662	root	tty	5	0	-	-	-
> -/dev/tty	c	666	root	tty	4	0	0	1	9
> -/dev/ttyS	c	640	root	tty	4	64	0	1	1
> -/dev/ttySA	c	640	root	tty	204	5	0	1	1
> -/dev/zero	c	644	root	root	1	5	-	-	-
> +/dev/mmcblk0	b	660	root	disk	179	0	-	-	-
> +/dev/mmcblk0p	b	660	root	disk	179	1	1	1	4
>  /dev/mtd	c	660	root	disk	90	0	0	2	8
>  /dev/mtdblock	b	640	root	root	31	0	0	1	8
> -/dev/console	c	662	root	tty	5	1	-	-	-
> +/dev/null	c	666	root	root	1	3	-	-	-
> +/dev/ram	b	640	root	root	1	0	0	1	4
>  /dev/random	c	644	root	root	1	8	-	-	-
> +/dev/rtc	c	644	root	root	254	0	0	1	2
> +/dev/sda	b	660	root	disk	8	0	-	-	-
> +/dev/sda	b	660	root	disk	8	1	1	1	4
> +/dev/sdb	b	660	root	disk	8	16	-	-	-
> +/dev/sdb	b	660	root	disk	8	17	1	1	4
> +/dev/tty	c	662	root	tty	5	0	-	-	-
> +/dev/tty	c	666	root	tty	4	0	0	1	8
> +/dev/ttyS	c	640	root	tty	4	64	0	1	2
>  /dev/urandom	c	644	root	root	1	9	-	-	-
> +/dev/zero	c	644	root	root	1	5	-	-	-
> -- 
> 1.8.5.4
>
Matthieu CRAPET - April 3, 2014, 7:54 a.m.
Hi Richard,

> If I remember correctly, mmc devices are dynamically allocated numbers.


Well, in my work experience, I always used this.
However, according to include/uapi/linux/major.h:

#define MMC_BLOCK_MAJOR   179

> I only see ttyS, not S0 or S1?


According to file:
/dev/ttyS	c	640	root	tty	4	64	0	1	2

This will create ttyS0 and ttyS1.

Matt


-----Message d'origine-----
De : Richard Purdie [mailto:richard.purdie@linuxfoundation.org] 
Envoyé : jeudi 3 avril 2014 09:27
À : Matthieu CRAPET
Cc : openembedded-core@lists.openembedded.org
Objet : Re: [OE-core] [RFC][PATCH] files/device_table-minimal.txt: cleanup

On Wed, 2014-04-02 at 18:46 +0200, Matthieu Crapet wrote:
> This device list is only used if USE_DEVFS is set to '0' (which is NOT 

> the default since 2013-12-14, see commit f54fdd6673a136ee1cee1f3263a8a7820de43ca3) and if IMAGE_DEVICE_TABLE and IMAGE_DEVICE_TABLES are not set.

> 

> This is, of course a very subjective list but minimal with 62 (special) files.

> However, you should be able to boot correctly a lot of embedded linux around.

> 

> Changes:

> - add sda, sdb, sda[1234], sdb[1234]

> - add mmcblk0, mmcblk0p[1234]


If I remember correctly, mmc devices are dynamically allocated numbers.
Can we guarantee these are going to be correct?

> - add rtc0, rtc1

> - restrict maximum hdaX from 19 to 4 (pata is old)

> - add ttyS1


I only see ttyS, not S0 or S1?

> - remove initctl, apm_bios, tty8, ttySA

> - sorted entries


Cheers,

Richard

> Signed-off-by: Matthieu Crapet <Matthieu.Crapet@ingenico.com>

> ---

>  meta/files/device_table-minimal.txt | 26 +++++++++++++++-----------

>  1 file changed, 15 insertions(+), 11 deletions(-)

> 

> diff --git a/meta/files/device_table-minimal.txt 

> b/meta/files/device_table-minimal.txt

> index 56c74bb..e4891cc 100644

> --- a/meta/files/device_table-minimal.txt

> +++ b/meta/files/device_table-minimal.txt

> @@ -9,23 +9,27 @@

>  #    p	Fifo (named pipe)

>  

>  /dev		d	755	root	root	-	-	-	-	-

> -/dev/initctl	p	600	root	root	-	-	-	-	-

> -/dev/apm_bios	c	660	root	plugdev	10	134	-	-	-

> +/dev/console	c	662	root	tty	5	1	-	-	-

>  /dev/fb0	c	600	root	root	29	0	-	-	-

>  /dev/hda	b	660	root	disk	3	0	-	-	-

> -/dev/hda	b	660	root	disk	3	1	1	1	19

> +/dev/hda	b	660	root	disk	3	1	1	1	4

>  /dev/kmem	c	640	root	kmem	1	2	-	-	-

>  /dev/kmsg	c	600	root	root	1	11	-	-	-

>  /dev/mem	c	640	root	kmem	1	1	-	-	-

> -/dev/null	c	666	root	root	1	3	-	-	-

> -/dev/ram	b	640	root	root	1	0	0	1	4

> -/dev/tty	c	662	root	tty	5	0	-	-	-

> -/dev/tty	c	666	root	tty	4	0	0	1	9

> -/dev/ttyS	c	640	root	tty	4	64	0	1	1

> -/dev/ttySA	c	640	root	tty	204	5	0	1	1

> -/dev/zero	c	644	root	root	1	5	-	-	-

> +/dev/mmcblk0	b	660	root	disk	179	0	-	-	-

> +/dev/mmcblk0p	b	660	root	disk	179	1	1	1	4

>  /dev/mtd	c	660	root	disk	90	0	0	2	8

>  /dev/mtdblock	b	640	root	root	31	0	0	1	8

> -/dev/console	c	662	root	tty	5	1	-	-	-

> +/dev/null	c	666	root	root	1	3	-	-	-

> +/dev/ram	b	640	root	root	1	0	0	1	4

>  /dev/random	c	644	root	root	1	8	-	-	-

> +/dev/rtc	c	644	root	root	254	0	0	1	2

> +/dev/sda	b	660	root	disk	8	0	-	-	-

> +/dev/sda	b	660	root	disk	8	1	1	1	4

> +/dev/sdb	b	660	root	disk	8	16	-	-	-

> +/dev/sdb	b	660	root	disk	8	17	1	1	4

> +/dev/tty	c	662	root	tty	5	0	-	-	-

> +/dev/tty	c	666	root	tty	4	0	0	1	8

> +/dev/ttyS	c	640	root	tty	4	64	0	1	2

>  /dev/urandom	c	644	root	root	1	9	-	-	-

> +/dev/zero	c	644	root	root	1	5	-	-	-

> --

> 1.8.5.4

>
Richard Purdie - April 4, 2014, 11:20 a.m.
On Thu, 2014-04-03 at 07:54 +0000, Matthieu CRAPET wrote:
> Hi Richard,
> 
> > If I remember correctly, mmc devices are dynamically allocated numbers.
> 
> Well, in my work experience, I always used this.
> However, according to include/uapi/linux/major.h:
> 
> #define MMC_BLOCK_MAJOR   179

I guess we should be ok then. I think the partition numbers can fail to
map but it would be rare that would happen and probably not at first
boot, or on the kind of environments the restricted dev directory would
be used in.

> > I only see ttyS, not S0 or S1?
> 
> According to file:
> /dev/ttyS	c	640	root	tty	4	64	0	1	2
> 
> This will create ttyS0 and ttyS1.

Sorry, yes, of course it will. I was getting confused...

Chewers,

Richard

Patch

diff --git a/meta/files/device_table-minimal.txt b/meta/files/device_table-minimal.txt
index 56c74bb..e4891cc 100644
--- a/meta/files/device_table-minimal.txt
+++ b/meta/files/device_table-minimal.txt
@@ -9,23 +9,27 @@ 
 #    p	Fifo (named pipe)
 
 /dev		d	755	root	root	-	-	-	-	-
-/dev/initctl	p	600	root	root	-	-	-	-	-
-/dev/apm_bios	c	660	root	plugdev	10	134	-	-	-
+/dev/console	c	662	root	tty	5	1	-	-	-
 /dev/fb0	c	600	root	root	29	0	-	-	-
 /dev/hda	b	660	root	disk	3	0	-	-	-
-/dev/hda	b	660	root	disk	3	1	1	1	19
+/dev/hda	b	660	root	disk	3	1	1	1	4
 /dev/kmem	c	640	root	kmem	1	2	-	-	-
 /dev/kmsg	c	600	root	root	1	11	-	-	-
 /dev/mem	c	640	root	kmem	1	1	-	-	-
-/dev/null	c	666	root	root	1	3	-	-	-
-/dev/ram	b	640	root	root	1	0	0	1	4
-/dev/tty	c	662	root	tty	5	0	-	-	-
-/dev/tty	c	666	root	tty	4	0	0	1	9
-/dev/ttyS	c	640	root	tty	4	64	0	1	1
-/dev/ttySA	c	640	root	tty	204	5	0	1	1
-/dev/zero	c	644	root	root	1	5	-	-	-
+/dev/mmcblk0	b	660	root	disk	179	0	-	-	-
+/dev/mmcblk0p	b	660	root	disk	179	1	1	1	4
 /dev/mtd	c	660	root	disk	90	0	0	2	8
 /dev/mtdblock	b	640	root	root	31	0	0	1	8
-/dev/console	c	662	root	tty	5	1	-	-	-
+/dev/null	c	666	root	root	1	3	-	-	-
+/dev/ram	b	640	root	root	1	0	0	1	4
 /dev/random	c	644	root	root	1	8	-	-	-
+/dev/rtc	c	644	root	root	254	0	0	1	2
+/dev/sda	b	660	root	disk	8	0	-	-	-
+/dev/sda	b	660	root	disk	8	1	1	1	4
+/dev/sdb	b	660	root	disk	8	16	-	-	-
+/dev/sdb	b	660	root	disk	8	17	1	1	4
+/dev/tty	c	662	root	tty	5	0	-	-	-
+/dev/tty	c	666	root	tty	4	0	0	1	8
+/dev/ttyS	c	640	root	tty	4	64	0	1	2
 /dev/urandom	c	644	root	root	1	9	-	-	-
+/dev/zero	c	644	root	root	1	5	-	-	-