Patchwork [bitbake-devel,dylan] hob: disable layer drag and drop outside the containing widget

login
register
mail settings
Submitter Cristiana Voicu
Date April 2, 2014, 1:50 p.m.
Message ID <BE68E9C8E0850C43B0F0B0B7D57FA5AE34A53ED8@IRSMSX105.ger.corp.intel.com>
Download mbox | patch
Permalink /patch/70023/
State New
Headers show

Comments

Cristiana Voicu - April 2, 2014, 1:50 p.m.
Hi Richard,

Can you please merge this patch on dylan?
This is already on master branch.

Thank,
Cristiana
Paul Eggleton - April 2, 2014, 2 p.m.
Hi Cristiana,

On Wednesday 02 April 2014 13:50:57 Voicu, Cristiana wrote:
> Can you please merge this patch on dylan?
> This is already on master branch.

I think we're just waiting for 1.4.3 to be released at this point, once it 
does this can be merged.

Cheers,
Paul

Patch

diff --git a/bitbake/lib/bb/ui/crumbs/hig/layerselectiondialog.py b/bitbake/lib/bb/ui/crumbs/hig/layerselectiondialog.py
index 783ee73..f6a4d72 100644
--- a/bitbake/lib/bb/ui/crumbs/hig/layerselectiondialog.py
+++ b/bitbake/lib/bb/ui/crumbs/hig/layerselectiondialog.py
@@ -132,12 +132,13 @@  class LayerSelectionDialog (CrumbsDialog):
         tree_selection.set_mode(gtk.SELECTION_SINGLE)

         # Allow enable drag and drop of rows including row move
+        dnd_internal_target = ''
+        dnd_targets = [(dnd_internal_target, gtk.TARGET_SAME_WIDGET, 0)]
         layer_tv.enable_model_drag_source( gtk.gdk.BUTTON1_MASK,
-            self.TARGETS,
-            gtk.gdk.ACTION_DEFAULT|
+            dnd_targets,
+            gtk.gdk.ACTION_MOVE)
+        layer_tv.enable_model_drag_dest(dnd_targets,
             gtk.gdk.ACTION_MOVE)
-        layer_tv.enable_model_drag_dest(self.TARGETS,
-            gtk.gdk.ACTION_DEFAULT)
         layer_tv.connect("drag_data_get", self.drag_data_get_cb)
         layer_tv.connect("drag_data_received", self.drag_data_received_cb)