Patchwork [3/5] gcc-target: remove infodir

login
register
mail settings
Submitter Martin Jansa
Date April 2, 2014, 12:25 p.m.
Message ID <1396441537-2911-3-git-send-email-Martin.Jansa@gmail.com>
Download mbox | patch
Permalink /patch/70007/
State New
Headers show

Comments

Martin Jansa - April 2, 2014, 12:25 p.m.
* it uses autotools but doesn't call autotools_do_install
* fixes QA warning:
  gcc-4.8.2: The /usr/share/info/dir file is not meant to be shipped in a particular package.

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 meta/recipes-devtools/gcc/gcc-target.inc | 4 ++++
 1 file changed, 4 insertions(+)
Khem Raj - April 2, 2014, 5:06 p.m.
On Wed, Apr 2, 2014 at 5:25 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
> +       # Info dir listing isn't interesting at this point so remove it if it exists.
> +       if [ -e "${D}${infodir}/dir" ]; then
> +               rm -f ${D}${infodir}/dir
> +       fi

why check if it exists when you are already using rm -f ?
Martin Jansa - April 2, 2014, 5:20 p.m.
On Wed, Apr 02, 2014 at 10:06:16AM -0700, Khem Raj wrote:
> On Wed, Apr 2, 2014 at 5:25 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
> > +       # Info dir listing isn't interesting at this point so remove it if it exists.
> > +       if [ -e "${D}${infodir}/dir" ]; then
> > +               rm -f ${D}${infodir}/dir
> > +       fi
> 
> why check if it exists when you are already using rm -f ?

Just because I was copying snippet from autotools.bbclass

Patch

diff --git a/meta/recipes-devtools/gcc/gcc-target.inc b/meta/recipes-devtools/gcc/gcc-target.inc
index e1179ac..3412aa8 100644
--- a/meta/recipes-devtools/gcc/gcc-target.inc
+++ b/meta/recipes-devtools/gcc/gcc-target.inc
@@ -104,6 +104,10 @@  FILES_${PN}-doc = "\
 
 do_install () {
 	oe_runmake 'DESTDIR=${D}' install-host
+	# Info dir listing isn't interesting at this point so remove it if it exists.
+	if [ -e "${D}${infodir}/dir" ]; then
+		rm -f ${D}${infodir}/dir
+	fi
 
 	# Cleanup some of the ${libdir}{,exec}/gcc stuff ...
 	rm -r ${D}${libdir}/gcc/${TARGET_SYS}/${BINV}/install-tools