Patchwork [0/1] Remove exported KERNEL_SOURCE

login
register
mail settings
Submitter Anders Darander
Date July 5, 2011, 2:52 p.m.
Message ID <cover.1309877488.git.anders@chargestorm.se>
Download mbox
Permalink /patch/6983/
State Accepted
Headers show

Pull-request

git://github.com/darander/oe-core kernel-source

Comments

Anders Darander - July 5, 2011, 2:52 p.m.
Remove KERNEL-SOURCE as an exported variable. 
When building an external module the 
STAGING_KERNEL_DIR variable can justbas well be used in
the module recipe.

The following changes since commit 2b3bf5350861f62435e2fdf1c56c8a02f4b1b4ac:

  xauth: upgrade from 1.05 to 1.06 (2011-07-04 12:45:01 +0100)

are available in the git repository at:
  git://github.com/darander/oe-core kernel-source
  https://github.com/darander/oe-core/tree/kernel-source

Anders Darander (1):
  module-base: remove KERNEL-SOURCE

 meta/classes/module-base.bbclass |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
Anders Darander - July 6, 2011, 6:41 a.m.
* Anders Darander Anders Darander <anders@chargestorm.se> [07/05/11 04:52 PM]:
> Remove KERNEL-SOURCE as an exported variable.
> When building an external module the
> STAGING_KERNEL_DIR variable can justbas well be used in
> the module recipe.

There is an alternative solution, which is to instead of removing the line
 export KERNEL_SOURCE = "${@base_read_file('${STAGING_KERNEL_DIR}/kernel-
source')}"
replace it with something like:
export KERNEL_SOURCE = "${STAGING_KERNEL_DIR}"

The only benefit from that solution is to prevent breaking of recipes when 
moving from oe.dev to oe-core. However, I prefer the original solution as we 
otherwise would have more redundant variables.

Regards,
Anders
Richard Purdie - July 7, 2011, 10:12 a.m.
On Wed, 2011-07-06 at 08:41 +0200, Anders Darander wrote:
> * Anders Darander Anders Darander <anders@chargestorm.se> [07/05/11 04:52 PM]:
> > Remove KERNEL-SOURCE as an exported variable.
> > When building an external module the
> > STAGING_KERNEL_DIR variable can justbas well be used in
> > the module recipe.
> 
> There is an alternative solution, which is to instead of removing the line
>  export KERNEL_SOURCE = "${@base_read_file('${STAGING_KERNEL_DIR}/kernel-
> source')}"
> replace it with something like:
> export KERNEL_SOURCE = "${STAGING_KERNEL_DIR}"
> 
> The only benefit from that solution is to prevent breaking of recipes when 
> moving from oe.dev to oe-core. However, I prefer the original solution as we 
> otherwise would have more redundant variables.

Since the directory in question doesn't exist, we can likely remove this
as anyone using it should have complained by now...

We can add it back with the corrected version if anyone does turn out to
need it.

Cheers,

Richard