Patchwork connman.inc: Add PACKAGECONFIG support for bluez5

login
register
mail settings
Submitter Florin Sarbu
Date April 1, 2014, 10:09 a.m.
Message ID <1396346945-3782-1-git-send-email-florin.sarbu@windriver.com>
Download mbox | patch
Permalink /patch/69811/
State New
Headers show

Comments

Florin Sarbu - April 1, 2014, 10:09 a.m.
Currently connman can only RDEPEND on bluez4.
This patch adds support for having bluez5 in PACKAGECONFIG
and get connman RDEPEND on bluez5 if desired.

Signed-off-by: Florin Sarbu <florin.sarbu@windriver.com>
---
 meta/recipes-connectivity/connman/connman.inc | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Richard Purdie - April 1, 2014, 10:51 a.m.
On Tue, 2014-04-01 at 13:09 +0300, Florin Sarbu wrote:
> Currently connman can only RDEPEND on bluez4.
> This patch adds support for having bluez5 in PACKAGECONFIG
> and get connman RDEPEND on bluez5 if desired.
> 
> Signed-off-by: Florin Sarbu <florin.sarbu@windriver.com>
> ---
>  meta/recipes-connectivity/connman/connman.inc | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-connectivity/connman/connman.inc b/meta/recipes-connectivity/connman/connman.inc
> index b3147c9..53a6a4f 100644
> --- a/meta/recipes-connectivity/connman/connman.inc
> +++ b/meta/recipes-connectivity/connman/connman.inc
> @@ -32,7 +32,7 @@ EXTRA_OECONF += "\
>  
>  PACKAGECONFIG ??= "wispr \
>                     ${@base_contains('DISTRO_FEATURES', 'wifi','wifi', '', d)} \
> -                   ${@base_contains('DISTRO_FEATURES', 'bluetooth','bluetooth', '', d)} \
> +                   ${@base_contains('DISTRO_FEATURES', 'bluetooth','bluez4', '', d)} \
>                     ${@base_contains('DISTRO_FEATURES', '3g','3g', '', d)} \
>  "
>  
> @@ -42,6 +42,7 @@ PACKAGECONFIG ??= "wispr \
>  
>  PACKAGECONFIG[wifi] = "--enable-wifi, --disable-wifi, wpa-supplicant"
>  PACKAGECONFIG[bluetooth] = "--enable-bluetooth, --disable-bluetooth, bluez4"

You renamed the option above but didn't here and hence broke bluez4.
This is not the quality of patch expected at -rc time for a release :(.

Cheers,

Richard

> +PACKAGECONFIG[bluez5] = "--enable-bluetooth, --disable-bluetooth, bluez5"
>  PACKAGECONFIG[3g] = "--enable-ofono, --disable-ofono, ofono"
>  PACKAGECONFIG[tist] = "--enable-tist,--disable-tist,"
>  PACKAGECONFIG[openvpn] = "--enable-openvpn --with-openvpn=${sbindir}/openvpn,--disable-openvpn,,openvpn"
> @@ -114,6 +115,7 @@ RPROVIDES_${PN} = "\
>  RDEPENDS_${PN} = "\
>  	dbus \
>  	${@base_contains('PACKAGECONFIG', 'bluetooth', 'bluez4', '', d)} \
> +	${@base_contains('PACKAGECONFIG', 'bluez5', 'bluez5', '', d)} \
>  	${@base_contains('PACKAGECONFIG', 'wifi','wpa-supplicant', '', d)} \
>  	${@base_contains('PACKAGECONFIG', '3g','ofono', '', d)} \
>  	xuser-account \
> -- 
> 1.9.1
>
Cristian Iorga - April 1, 2014, 11:23 a.m.
Hi all,

I would also say that is an important change, with some possible unforeseen consequences.
The YP is in the stabilization phase for 1.6 release.
In my opinion, the support for and change to BlueZ (overall) should be postponed to 1.7.
Also, this not the proper solution, because, in the end, if BlueZ4 will still be around in 1.7 (which is not my intention, to be honest), this will be worked out with a Bluetooth stack provider (which can be BZ4 or, preferably, BZ5).

I vote against this patch.

Regards,
Cristian Iorga
YP
Intel Corporation

-----Original Message-----
From: openembedded-core-bounces@lists.openembedded.org [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of Richard Purdie
Sent: Tuesday, April 1, 2014 1:51 PM
To: Sarbu, Florin-Ionut (Wind River)
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH] connman.inc: Add PACKAGECONFIG support for bluez5

On Tue, 2014-04-01 at 13:09 +0300, Florin Sarbu wrote:
> Currently connman can only RDEPEND on bluez4.
> This patch adds support for having bluez5 in PACKAGECONFIG and get 
> connman RDEPEND on bluez5 if desired.
> 
> Signed-off-by: Florin Sarbu <florin.sarbu@windriver.com>
> ---
>  meta/recipes-connectivity/connman/connman.inc | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-connectivity/connman/connman.inc 
> b/meta/recipes-connectivity/connman/connman.inc
> index b3147c9..53a6a4f 100644
> --- a/meta/recipes-connectivity/connman/connman.inc
> +++ b/meta/recipes-connectivity/connman/connman.inc
> @@ -32,7 +32,7 @@ EXTRA_OECONF += "\
>  
>  PACKAGECONFIG ??= "wispr \
>                     ${@base_contains('DISTRO_FEATURES', 'wifi','wifi', '', d)} \
> -                   ${@base_contains('DISTRO_FEATURES', 'bluetooth','bluetooth', '', d)} \
> +                   ${@base_contains('DISTRO_FEATURES', 
> + 'bluetooth','bluez4', '', d)} \
>                     ${@base_contains('DISTRO_FEATURES', '3g','3g', '', 
> d)} \  "
>  
> @@ -42,6 +42,7 @@ PACKAGECONFIG ??= "wispr \
>  
>  PACKAGECONFIG[wifi] = "--enable-wifi, --disable-wifi, wpa-supplicant"
>  PACKAGECONFIG[bluetooth] = "--enable-bluetooth, --disable-bluetooth, bluez4"

You renamed the option above but didn't here and hence broke bluez4.
This is not the quality of patch expected at -rc time for a release :(.

Cheers,

Richard

> +PACKAGECONFIG[bluez5] = "--enable-bluetooth, --disable-bluetooth, bluez5"
>  PACKAGECONFIG[3g] = "--enable-ofono, --disable-ofono, ofono"
>  PACKAGECONFIG[tist] = "--enable-tist,--disable-tist,"
>  PACKAGECONFIG[openvpn] = "--enable-openvpn --with-openvpn=${sbindir}/openvpn,--disable-openvpn,,openvpn"
> @@ -114,6 +115,7 @@ RPROVIDES_${PN} = "\  RDEPENDS_${PN} = "\
>  	dbus \
>  	${@base_contains('PACKAGECONFIG', 'bluetooth', 'bluez4', '', d)} \
> +	${@base_contains('PACKAGECONFIG', 'bluez5', 'bluez5', '', d)} \
>  	${@base_contains('PACKAGECONFIG', 'wifi','wpa-supplicant', '', d)} \
>  	${@base_contains('PACKAGECONFIG', '3g','ofono', '', d)} \
>  	xuser-account \
> --
> 1.9.1
>
Florin Sarbu - April 1, 2014, 12:27 p.m.
Please see inline.

On 04/01/2014 02:23 PM, Iorga, Cristian wrote:
> Hi all,
>
> I would also say that is an important change, with some possible unforeseen consequences.
> The YP is in the stabilization phase for 1.6 release.
> In my opinion, the support for and change to BlueZ (overall) should be postponed to 1.7.
> Also, this not the proper solution, because, in the end, if BlueZ4 will still be around in 1.7 (which is not my intention, to be honest), this will be worked out with a Bluetooth stack provider (which can be BZ4 or, preferably, BZ5).
>
> I vote against this patch.
The idea was that people could just have bluetooth in DISTRO_FEATURES 
and things would be unchanged, as in use bluez4 like now, and if 
somebody else wants bluez5, just add bluez5 to PACKAGECONFIG in some 
.bbappend's and not rely on the bluetooth DISTRO_FEATURE until bluez5 
supersedes bluez4.
At the moment, one cannot use bluez5 as connman and libpcap explicitly 
depend on bluez4.
>
> Regards,
> Cristian Iorga
> YP
> Intel Corporation
>
> -----Original Message-----
> From: openembedded-core-bounces@lists.openembedded.org [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of Richard Purdie
> Sent: Tuesday, April 1, 2014 1:51 PM
> To: Sarbu, Florin-Ionut (Wind River)
> Cc: openembedded-core@lists.openembedded.org
> Subject: Re: [OE-core] [PATCH] connman.inc: Add PACKAGECONFIG support for bluez5
>
> On Tue, 2014-04-01 at 13:09 +0300, Florin Sarbu wrote:
>> Currently connman can only RDEPEND on bluez4.
>> This patch adds support for having bluez5 in PACKAGECONFIG and get
>> connman RDEPEND on bluez5 if desired.
>>
>> Signed-off-by: Florin Sarbu <florin.sarbu@windriver.com>
>> ---
>>   meta/recipes-connectivity/connman/connman.inc | 4 +++-
>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-connectivity/connman/connman.inc
>> b/meta/recipes-connectivity/connman/connman.inc
>> index b3147c9..53a6a4f 100644
>> --- a/meta/recipes-connectivity/connman/connman.inc
>> +++ b/meta/recipes-connectivity/connman/connman.inc
>> @@ -32,7 +32,7 @@ EXTRA_OECONF += "\
>>
>>   PACKAGECONFIG ??= "wispr \
>>                      ${@base_contains('DISTRO_FEATURES', 'wifi','wifi', '', d)} \
>> -                   ${@base_contains('DISTRO_FEATURES', 'bluetooth','bluetooth', '', d)} \
>> +                   ${@base_contains('DISTRO_FEATURES',
>> + 'bluetooth','bluez4', '', d)} \
>>                      ${@base_contains('DISTRO_FEATURES', '3g','3g', '',
>> d)} \  "
>>
>> @@ -42,6 +42,7 @@ PACKAGECONFIG ??= "wispr \
>>
>>   PACKAGECONFIG[wifi] = "--enable-wifi, --disable-wifi, wpa-supplicant"
>>   PACKAGECONFIG[bluetooth] = "--enable-bluetooth, --disable-bluetooth, bluez4"
> You renamed the option above but didn't here and hence broke bluez4.
> This is not the quality of patch expected at -rc time for a release :(.
Sorry, I overlooked the change in that one and the others remaining 
after that.
>
> Cheers,
>
> Richard
>
>> +PACKAGECONFIG[bluez5] = "--enable-bluetooth, --disable-bluetooth, bluez5"
Also, to not get it disable bluetooth when using bluez4, the above line 
should look something like:

+PACKAGECONFIG[bluez5] = "--enable-bluetooth, , bluez5"

Want me to send another patch or we just drop it and people just do what 
they need in their own .bbappend's in order to have bluez5 in?

Thank you,
Florin

>>   PACKAGECONFIG[3g] = "--enable-ofono, --disable-ofono, ofono"
>>   PACKAGECONFIG[tist] = "--enable-tist,--disable-tist,"
>>   PACKAGECONFIG[openvpn] = "--enable-openvpn --with-openvpn=${sbindir}/openvpn,--disable-openvpn,,openvpn"
>> @@ -114,6 +115,7 @@ RPROVIDES_${PN} = "\  RDEPENDS_${PN} = "\
>>        dbus \
>>        ${@base_contains('PACKAGECONFIG', 'bluetooth', 'bluez4', '', d)} \
>> +     ${@base_contains('PACKAGECONFIG', 'bluez5', 'bluez5', '', d)} \
>>        ${@base_contains('PACKAGECONFIG', 'wifi','wpa-supplicant', '', d)} \
>>        ${@base_contains('PACKAGECONFIG', '3g','ofono', '', d)} \
>>        xuser-account \
>> --
>> 1.9.1
>>
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
Cristian Iorga - April 1, 2014, 1:22 p.m.
Hmm,

I am quite sure that connman is ready for BlueZ4 for some time.
I am not sure about libpcap, to be honest, did not investigate that.
Can you please provide some facts related to your statements?
Regards,
Cristian

-----Original Message-----
From: Florin Sarbu [mailto:florin.sarbu@windriver.com] 
Sent: Tuesday, April 1, 2014 3:27 PM
To: Iorga, Cristian
Cc: openembedded-core@lists.openembedded.org; Richard Purdie
Subject: Re: [OE-core] [PATCH] connman.inc: Add PACKAGECONFIG support for bluez5

Please see inline.

On 04/01/2014 02:23 PM, Iorga, Cristian wrote:
> Hi all,
>
> I would also say that is an important change, with some possible unforeseen consequences.
> The YP is in the stabilization phase for 1.6 release.
> In my opinion, the support for and change to BlueZ (overall) should be postponed to 1.7.
> Also, this not the proper solution, because, in the end, if BlueZ4 will still be around in 1.7 (which is not my intention, to be honest), this will be worked out with a Bluetooth stack provider (which can be BZ4 or, preferably, BZ5).
>
> I vote against this patch.
The idea was that people could just have bluetooth in DISTRO_FEATURES and things would be unchanged, as in use bluez4 like now, and if somebody else wants bluez5, just add bluez5 to PACKAGECONFIG in some .bbappend's and not rely on the bluetooth DISTRO_FEATURE until bluez5 supersedes bluez4.
At the moment, one cannot use bluez5 as connman and libpcap explicitly depend on bluez4.
>
> Regards,
> Cristian Iorga
> YP
> Intel Corporation
>
> -----Original Message-----
> From: openembedded-core-bounces@lists.openembedded.org 
> [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of 
> Richard Purdie
> Sent: Tuesday, April 1, 2014 1:51 PM
> To: Sarbu, Florin-Ionut (Wind River)
> Cc: openembedded-core@lists.openembedded.org
> Subject: Re: [OE-core] [PATCH] connman.inc: Add PACKAGECONFIG support 
> for bluez5
>
> On Tue, 2014-04-01 at 13:09 +0300, Florin Sarbu wrote:
>> Currently connman can only RDEPEND on bluez4.
>> This patch adds support for having bluez5 in PACKAGECONFIG and get 
>> connman RDEPEND on bluez5 if desired.
>>
>> Signed-off-by: Florin Sarbu <florin.sarbu@windriver.com>
>> ---
>>   meta/recipes-connectivity/connman/connman.inc | 4 +++-
>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-connectivity/connman/connman.inc
>> b/meta/recipes-connectivity/connman/connman.inc
>> index b3147c9..53a6a4f 100644
>> --- a/meta/recipes-connectivity/connman/connman.inc
>> +++ b/meta/recipes-connectivity/connman/connman.inc
>> @@ -32,7 +32,7 @@ EXTRA_OECONF += "\
>>
>>   PACKAGECONFIG ??= "wispr \
>>                      ${@base_contains('DISTRO_FEATURES', 'wifi','wifi', '', d)} \
>> -                   ${@base_contains('DISTRO_FEATURES', 'bluetooth','bluetooth', '', d)} \
>> +                   ${@base_contains('DISTRO_FEATURES',
>> + 'bluetooth','bluez4', '', d)} \
>>                      ${@base_contains('DISTRO_FEATURES', '3g','3g', 
>> '', d)} \  "
>>
>> @@ -42,6 +42,7 @@ PACKAGECONFIG ??= "wispr \
>>
>>   PACKAGECONFIG[wifi] = "--enable-wifi, --disable-wifi, wpa-supplicant"
>>   PACKAGECONFIG[bluetooth] = "--enable-bluetooth, --disable-bluetooth, bluez4"
> You renamed the option above but didn't here and hence broke bluez4.
> This is not the quality of patch expected at -rc time for a release :(.
Sorry, I overlooked the change in that one and the others remaining after that.
>
> Cheers,
>
> Richard
>
>> +PACKAGECONFIG[bluez5] = "--enable-bluetooth, --disable-bluetooth, bluez5"
Also, to not get it disable bluetooth when using bluez4, the above line should look something like:

+PACKAGECONFIG[bluez5] = "--enable-bluetooth, , bluez5"

Want me to send another patch or we just drop it and people just do what they need in their own .bbappend's in order to have bluez5 in?

Thank you,
Florin

>>   PACKAGECONFIG[3g] = "--enable-ofono, --disable-ofono, ofono"
>>   PACKAGECONFIG[tist] = "--enable-tist,--disable-tist,"
>>   PACKAGECONFIG[openvpn] = "--enable-openvpn --with-openvpn=${sbindir}/openvpn,--disable-openvpn,,openvpn"
>> @@ -114,6 +115,7 @@ RPROVIDES_${PN} = "\  RDEPENDS_${PN} = "\
>>        dbus \
>>        ${@base_contains('PACKAGECONFIG', 'bluetooth', 'bluez4', '', 
>> d)} \
>> +     ${@base_contains('PACKAGECONFIG', 'bluez5', 'bluez5', '', d)} \
>>        ${@base_contains('PACKAGECONFIG', 'wifi','wpa-supplicant', '', d)} \
>>        ${@base_contains('PACKAGECONFIG', '3g','ofono', '', d)} \
>>        xuser-account \
>> --
>> 1.9.1
>>
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
Cristian Iorga - April 1, 2014, 1:27 p.m.
Hello,
I meant, of course, BlueZ5, connman is ready for BlueZ5.

-----Original Message-----
From: openembedded-core-bounces@lists.openembedded.org [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of Iorga, Cristian
Sent: Tuesday, April 1, 2014 4:23 PM
To: Sarbu, Florin-Ionut (Wind River)
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH] connman.inc: Add PACKAGECONFIG support for bluez5

Hmm,

I am quite sure that connman is ready for BlueZ4 for some time.
I am not sure about libpcap, to be honest, did not investigate that.
Can you please provide some facts related to your statements?
Regards,
Cristian

-----Original Message-----
From: Florin Sarbu [mailto:florin.sarbu@windriver.com]
Sent: Tuesday, April 1, 2014 3:27 PM
To: Iorga, Cristian
Cc: openembedded-core@lists.openembedded.org; Richard Purdie
Subject: Re: [OE-core] [PATCH] connman.inc: Add PACKAGECONFIG support for bluez5

Please see inline.

On 04/01/2014 02:23 PM, Iorga, Cristian wrote:
> Hi all,
>
> I would also say that is an important change, with some possible unforeseen consequences.
> The YP is in the stabilization phase for 1.6 release.
> In my opinion, the support for and change to BlueZ (overall) should be postponed to 1.7.
> Also, this not the proper solution, because, in the end, if BlueZ4 will still be around in 1.7 (which is not my intention, to be honest), this will be worked out with a Bluetooth stack provider (which can be BZ4 or, preferably, BZ5).
>
> I vote against this patch.
The idea was that people could just have bluetooth in DISTRO_FEATURES and things would be unchanged, as in use bluez4 like now, and if somebody else wants bluez5, just add bluez5 to PACKAGECONFIG in some .bbappend's and not rely on the bluetooth DISTRO_FEATURE until bluez5 supersedes bluez4.
At the moment, one cannot use bluez5 as connman and libpcap explicitly depend on bluez4.
>
> Regards,
> Cristian Iorga
> YP
> Intel Corporation
>
> -----Original Message-----
> From: openembedded-core-bounces@lists.openembedded.org
> [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of 
> Richard Purdie
> Sent: Tuesday, April 1, 2014 1:51 PM
> To: Sarbu, Florin-Ionut (Wind River)
> Cc: openembedded-core@lists.openembedded.org
> Subject: Re: [OE-core] [PATCH] connman.inc: Add PACKAGECONFIG support 
> for bluez5
>
> On Tue, 2014-04-01 at 13:09 +0300, Florin Sarbu wrote:
>> Currently connman can only RDEPEND on bluez4.
>> This patch adds support for having bluez5 in PACKAGECONFIG and get 
>> connman RDEPEND on bluez5 if desired.
>>
>> Signed-off-by: Florin Sarbu <florin.sarbu@windriver.com>
>> ---
>>   meta/recipes-connectivity/connman/connman.inc | 4 +++-
>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-connectivity/connman/connman.inc
>> b/meta/recipes-connectivity/connman/connman.inc
>> index b3147c9..53a6a4f 100644
>> --- a/meta/recipes-connectivity/connman/connman.inc
>> +++ b/meta/recipes-connectivity/connman/connman.inc
>> @@ -32,7 +32,7 @@ EXTRA_OECONF += "\
>>
>>   PACKAGECONFIG ??= "wispr \
>>                      ${@base_contains('DISTRO_FEATURES', 'wifi','wifi', '', d)} \
>> -                   ${@base_contains('DISTRO_FEATURES', 'bluetooth','bluetooth', '', d)} \
>> +                   ${@base_contains('DISTRO_FEATURES',
>> + 'bluetooth','bluez4', '', d)} \
>>                      ${@base_contains('DISTRO_FEATURES', '3g','3g', 
>> '', d)} \  "
>>
>> @@ -42,6 +42,7 @@ PACKAGECONFIG ??= "wispr \
>>
>>   PACKAGECONFIG[wifi] = "--enable-wifi, --disable-wifi, wpa-supplicant"
>>   PACKAGECONFIG[bluetooth] = "--enable-bluetooth, --disable-bluetooth, bluez4"
> You renamed the option above but didn't here and hence broke bluez4.
> This is not the quality of patch expected at -rc time for a release :(.
Sorry, I overlooked the change in that one and the others remaining after that.
>
> Cheers,
>
> Richard
>
>> +PACKAGECONFIG[bluez5] = "--enable-bluetooth, --disable-bluetooth, bluez5"
Also, to not get it disable bluetooth when using bluez4, the above line should look something like:

+PACKAGECONFIG[bluez5] = "--enable-bluetooth, , bluez5"

Want me to send another patch or we just drop it and people just do what they need in their own .bbappend's in order to have bluez5 in?

Thank you,
Florin

>>   PACKAGECONFIG[3g] = "--enable-ofono, --disable-ofono, ofono"
>>   PACKAGECONFIG[tist] = "--enable-tist,--disable-tist,"
>>   PACKAGECONFIG[openvpn] = "--enable-openvpn --with-openvpn=${sbindir}/openvpn,--disable-openvpn,,openvpn"
>> @@ -114,6 +115,7 @@ RPROVIDES_${PN} = "\  RDEPENDS_${PN} = "\
>>        dbus \
>>        ${@base_contains('PACKAGECONFIG', 'bluetooth', 'bluez4', '', 
>> d)} \
>> +     ${@base_contains('PACKAGECONFIG', 'bluez5', 'bluez5', '', d)} \
>>        ${@base_contains('PACKAGECONFIG', 'wifi','wpa-supplicant', '', d)} \
>>        ${@base_contains('PACKAGECONFIG', '3g','ofono', '', d)} \
>>        xuser-account \
>> --
>> 1.9.1
>>
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

--
Florin Sarbu - April 1, 2014, 1:41 p.m.
On 04/01/2014 04:27 PM, Iorga, Cristian wrote:
> Hello,
> I meant, of course, BlueZ5, connman is ready for BlueZ5.
>
> -----Original Message-----
> From: openembedded-core-bounces@lists.openembedded.org [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of Iorga, Cristian
> Sent: Tuesday, April 1, 2014 4:23 PM
> To: Sarbu, Florin-Ionut (Wind River)
> Cc: openembedded-core@lists.openembedded.org
> Subject: Re: [OE-core] [PATCH] connman.inc: Add PACKAGECONFIG support for bluez5
>
> Hmm,
>
> I am quite sure that connman is ready for BlueZ4 for some time.
> I am not sure about libpcap, to be honest, did not investigate that.
> Can you please provide some facts related to your statements?
Well, as far as I see it, these 2 packages (connman and libpcap) are 
aware only of bluez4 at the moment.
connman.inc has:

PACKAGECONFIG[bluetooth] = "--enable-bluetooth, --disable-bluetooth, bluez4"

which will add a build dependency on bluez4.

And speaking of which, it seems that doing:

RDEPENDS_${PN} = "\
              dbus \
              ${@base_contains('PACKAGECONFIG', 'bluetooth', 'bluez4', 
'', d)} \

is superfluous as it may be achieved by changing the PACKAGECONFIG live 
above to something like:

PACKAGECONFIG[bluetooth] = "--enable-bluetooth, --disable-bluetooth, 
bluez4, bluez4"

to achieve the same thing.

Be it as it may, it looks like at this point, having bluetooth in 
DISTRO_FEATURES drags in bluez4 and no configurable way to use bluez5.

Florin
> Regards,
> Cristian
>
> -----Original Message-----
> From: Florin Sarbu [mailto:florin.sarbu@windriver.com]
> Sent: Tuesday, April 1, 2014 3:27 PM
> To: Iorga, Cristian
> Cc: openembedded-core@lists.openembedded.org; Richard Purdie
> Subject: Re: [OE-core] [PATCH] connman.inc: Add PACKAGECONFIG support for bluez5
>
> Please see inline.
>
> On 04/01/2014 02:23 PM, Iorga, Cristian wrote:
>> Hi all,
>>
>> I would also say that is an important change, with some possible unforeseen consequences.
>> The YP is in the stabilization phase for 1.6 release.
>> In my opinion, the support for and change to BlueZ (overall) should be postponed to 1.7.
>> Also, this not the proper solution, because, in the end, if BlueZ4 will still be around in 1.7 (which is not my intention, to be honest), this will be worked out with a Bluetooth stack provider (which can be BZ4 or, preferably, BZ5).
>>
>> I vote against this patch.
> The idea was that people could just have bluetooth in DISTRO_FEATURES and things would be unchanged, as in use bluez4 like now, and if somebody else wants bluez5, just add bluez5 to PACKAGECONFIG in some .bbappend's and not rely on the bluetooth DISTRO_FEATURE until bluez5 supersedes bluez4.
> At the moment, one cannot use bluez5 as connman and libpcap explicitly depend on bluez4.
>> Regards,
>> Cristian Iorga
>> YP
>> Intel Corporation
>>
>> -----Original Message-----
>> From: openembedded-core-bounces@lists.openembedded.org
>> [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of
>> Richard Purdie
>> Sent: Tuesday, April 1, 2014 1:51 PM
>> To: Sarbu, Florin-Ionut (Wind River)
>> Cc: openembedded-core@lists.openembedded.org
>> Subject: Re: [OE-core] [PATCH] connman.inc: Add PACKAGECONFIG support
>> for bluez5
>>
>> On Tue, 2014-04-01 at 13:09 +0300, Florin Sarbu wrote:
>>> Currently connman can only RDEPEND on bluez4.
>>> This patch adds support for having bluez5 in PACKAGECONFIG and get
>>> connman RDEPEND on bluez5 if desired.
>>>
>>> Signed-off-by: Florin Sarbu <florin.sarbu@windriver.com>
>>> ---
>>>    meta/recipes-connectivity/connman/connman.inc | 4 +++-
>>>    1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/meta/recipes-connectivity/connman/connman.inc
>>> b/meta/recipes-connectivity/connman/connman.inc
>>> index b3147c9..53a6a4f 100644
>>> --- a/meta/recipes-connectivity/connman/connman.inc
>>> +++ b/meta/recipes-connectivity/connman/connman.inc
>>> @@ -32,7 +32,7 @@ EXTRA_OECONF += "\
>>>
>>>    PACKAGECONFIG ??= "wispr \
>>>                       ${@base_contains('DISTRO_FEATURES', 'wifi','wifi', '', d)} \
>>> -                   ${@base_contains('DISTRO_FEATURES', 'bluetooth','bluetooth', '', d)} \
>>> +                   ${@base_contains('DISTRO_FEATURES',
>>> + 'bluetooth','bluez4', '', d)} \
>>>                       ${@base_contains('DISTRO_FEATURES', '3g','3g',
>>> '', d)} \  "
>>>
>>> @@ -42,6 +42,7 @@ PACKAGECONFIG ??= "wispr \
>>>
>>>    PACKAGECONFIG[wifi] = "--enable-wifi, --disable-wifi, wpa-supplicant"
>>>    PACKAGECONFIG[bluetooth] = "--enable-bluetooth, --disable-bluetooth, bluez4"
>> You renamed the option above but didn't here and hence broke bluez4.
>> This is not the quality of patch expected at -rc time for a release :(.
> Sorry, I overlooked the change in that one and the others remaining after that.
>> Cheers,
>>
>> Richard
>>
>>> +PACKAGECONFIG[bluez5] = "--enable-bluetooth, --disable-bluetooth, bluez5"
> Also, to not get it disable bluetooth when using bluez4, the above line should look something like:
>
> +PACKAGECONFIG[bluez5] = "--enable-bluetooth, , bluez5"
>
> Want me to send another patch or we just drop it and people just do what they need in their own .bbappend's in order to have bluez5 in?
>
> Thank you,
> Florin
>
>>>    PACKAGECONFIG[3g] = "--enable-ofono, --disable-ofono, ofono"
>>>    PACKAGECONFIG[tist] = "--enable-tist,--disable-tist,"
>>>    PACKAGECONFIG[openvpn] = "--enable-openvpn --with-openvpn=${sbindir}/openvpn,--disable-openvpn,,openvpn"
>>> @@ -114,6 +115,7 @@ RPROVIDES_${PN} = "\  RDEPENDS_${PN} = "\
>>>         dbus \
>>>         ${@base_contains('PACKAGECONFIG', 'bluetooth', 'bluez4', '',
>>> d)} \
>>> +     ${@base_contains('PACKAGECONFIG', 'bluez5', 'bluez5', '', d)} \
>>>         ${@base_contains('PACKAGECONFIG', 'wifi','wpa-supplicant', '', d)} \
>>>         ${@base_contains('PACKAGECONFIG', '3g','ofono', '', d)} \
>>>         xuser-account \
>>> --
>>> 1.9.1
>>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
Ross Burton - April 1, 2014, 2:16 p.m.
On 1 April 2014 14:41, Florin Sarbu <florin.sarbu@windriver.com> wrote:
> Well, as far as I see it, these 2 packages (connman and libpcap) are aware
> only of bluez4 at the moment.

ConnMan supports both, and libpcap uses the libbluetooth API so that
should link fine against either as that API didn't change much.

Ross
Florin Sarbu - April 1, 2014, 2:24 p.m.
On 04/01/2014 05:16 PM, Burton, Ross wrote:
> On 1 April 2014 14:41, Florin Sarbu <florin.sarbu@windriver.com> wrote:
>> Well, as far as I see it, these 2 packages (connman and libpcap) are aware
>> only of bluez4 at the moment.
> ConnMan supports both, and libpcap uses the libbluetooth API so that
> should link fine against either as that API didn't change much.
Sorry, I meant the recipes are only bluez4 aware.

Florin
> Ross

Patch

diff --git a/meta/recipes-connectivity/connman/connman.inc b/meta/recipes-connectivity/connman/connman.inc
index b3147c9..53a6a4f 100644
--- a/meta/recipes-connectivity/connman/connman.inc
+++ b/meta/recipes-connectivity/connman/connman.inc
@@ -32,7 +32,7 @@  EXTRA_OECONF += "\
 
 PACKAGECONFIG ??= "wispr \
                    ${@base_contains('DISTRO_FEATURES', 'wifi','wifi', '', d)} \
-                   ${@base_contains('DISTRO_FEATURES', 'bluetooth','bluetooth', '', d)} \
+                   ${@base_contains('DISTRO_FEATURES', 'bluetooth','bluez4', '', d)} \
                    ${@base_contains('DISTRO_FEATURES', '3g','3g', '', d)} \
 "
 
@@ -42,6 +42,7 @@  PACKAGECONFIG ??= "wispr \
 
 PACKAGECONFIG[wifi] = "--enable-wifi, --disable-wifi, wpa-supplicant"
 PACKAGECONFIG[bluetooth] = "--enable-bluetooth, --disable-bluetooth, bluez4"
+PACKAGECONFIG[bluez5] = "--enable-bluetooth, --disable-bluetooth, bluez5"
 PACKAGECONFIG[3g] = "--enable-ofono, --disable-ofono, ofono"
 PACKAGECONFIG[tist] = "--enable-tist,--disable-tist,"
 PACKAGECONFIG[openvpn] = "--enable-openvpn --with-openvpn=${sbindir}/openvpn,--disable-openvpn,,openvpn"
@@ -114,6 +115,7 @@  RPROVIDES_${PN} = "\
 RDEPENDS_${PN} = "\
 	dbus \
 	${@base_contains('PACKAGECONFIG', 'bluetooth', 'bluez4', '', d)} \
+	${@base_contains('PACKAGECONFIG', 'bluez5', 'bluez5', '', d)} \
 	${@base_contains('PACKAGECONFIG', 'wifi','wpa-supplicant', '', d)} \
 	${@base_contains('PACKAGECONFIG', '3g','ofono', '', d)} \
 	xuser-account \